Skip to content

Plex config changes#10342

Merged
frenck merged 4 commits into
home-assistant:nextfrom
jjlawren:plex_config_flow_prep
Sep 11, 2019
Merged

Plex config changes#10342
frenck merged 4 commits into
home-assistant:nextfrom
jjlawren:plex_config_flow_prep

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

Description:

  • Default value of host removed
  • New server config option added
  • Some descriptions updated or fixed to reflect current behavior

Pull request in home-assistant (if applicable): home-assistant/core#26583

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Sep 11, 2019
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Sep 11, 2019
MartinHjelmare
MartinHjelmare previously approved these changes Sep 11, 2019
@jjlawren
Copy link
Copy Markdown
Contributor Author

@klaasnicolaas, the YAML example was edited on purpose to show the new minimal config. Either host or token must be included and an empty config will now error on startup. Only providing token is what I'd expect to be the simplest way to configure the component for most users.

@klaasnicolaas
Copy link
Copy Markdown
Member

I saw in the code that both were optional in the list, which is why I removed it. But given your explanation, it is better to add this. You could also put 2 examples with both options 😉

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@frenck frenck merged commit b78cf38 into home-assistant:next Sep 11, 2019
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Sep 11, 2019
@bbrendon bbrendon mentioned this pull request Sep 23, 2019
2 tasks
@jjlawren jjlawren deleted the plex_config_flow_prep branch May 8, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants