Skip to content

Add plex server config options to media_player platform#26458

Merged
MartinHjelmare merged 5 commits into
home-assistant:devfrom
jjlawren:plex_add_mp_server_config
Sep 5, 2019
Merged

Add plex server config options to media_player platform#26458
MartinHjelmare merged 5 commits into
home-assistant:devfrom
jjlawren:plex_add_mp_server_config

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Sep 5, 2019 •
edited by MartinHjelmare
Loading

Description:

Adds config options to platform in addition to non-standard plex.conf file.

Continuation from #26157 & #26444

Pull request with documentation for home-assistant.io (if applicable):
home-assistant/home-assistant.io#10303

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: plex
    host: 10.0.10.5
    token: asdfasdf1234

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

@probot-home-assistant probot-home-assistant Bot added integration: plex small-pr PRs with less than 30 lines. labels Sep 5, 2019
MartinHjelmare
MartinHjelmare requested changes Sep 5, 2019
View reviewed changes
Comment thread homeassistant/components/plex/media_player.py Outdated
Comment thread homeassistant/components/plex/media_player.py Outdated
Comment thread homeassistant/components/plex/media_player.py Outdated
MartinHjelmare
MartinHjelmare reviewed Sep 5, 2019
View reviewed changes
Comment thread homeassistant/components/plex/media_player.py Outdated
MartinHjelmare
MartinHjelmare approved these changes Sep 5, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare changed the title Add server config options to media_player platform Add plex server config options to media_player platform Sep 5, 2019
@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Sep 5, 2019 •
edited
Loading

I will merge this without docs PR since we're moving the config to the component in the next PR.

@MartinHjelmare MartinHjelmare merged commit 23fdc04 into home-assistant:dev Sep 5, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 6, 2019
@jjlawren jjlawren deleted the plex_add_mp_server_config branch October 26, 2019 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

cla-signed integration: plex small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jjlawren @MartinHjelmare @homeassistant