Closed
Conversation
ghost
assigned
2 tasks
* Update credstash.py * Update requirements_all.txt
* Upgrade pytest to 3.10.0 * Upgrade pytest-sugar to 0.9.2
The current version of python-avion doesn't work correctly with Python 3.5. Update it to one that does.
Bump python-avion dependency
houndci-bot
reviewed
Nov 11, 2018
* Better error handling in Tibber * return if received error
The include path is now always relative to the root of the config dir.
* Add type hints to helpers.entityfilter * Add type hints to helpers.deprecation
* Remove notify schema from hangouts platform * Notify platforms shouldn't overwrite the notify component service schema. That has no effect. * Fix hangouts service data key value
…nt#17166) * Fix and improvment of Swiss Hydrological Data component * changed component to get data from a REST API rather than from crawling the website * fixed several issues and lint errors * Fix and improvment of Swiss Hydrological Data component * Minor changes - Simplify the sensor configuration (expose value as attributes rather than sensor) - Make the setup fail if station is not available - Add unique ID - Prepare for config flow
dgomes
requested review from
a team,
Danielhiversen,
cdce8p and
fabaff
as code owners
houndci-bot
reviewed
Nov 11, 2018
| hass.http.register_view(CameraPushReceiver(hass, | ||
| config[CONF_IMAGE_FIELD])) | ||
| try: | ||
| hass.components.webhook.async_register(DOMAIN, 'push', webhook_id, handle_webhook) |
There was a problem hiding this comment.
line too long (90 > 79 characters)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This moves from the temporary webhook solution to the webhook solution in #16817
Related issue (if applicable): fixes #16817
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7451
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: