Skip to content

Fix hangouts notify#18372

Merged
balloob merged 2 commits intohome-assistant:devfrom
MartinHjelmare:fix-hangouts-notify
Nov 11, 2018
Merged

Fix hangouts notify#18372
balloob merged 2 commits intohome-assistant:devfrom
MartinHjelmare:fix-hangouts-notify

Conversation

@MartinHjelmare
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare commented Nov 11, 2018

Description:

  • Only pass the data key value to the hangouts send message service if we receive data from the notify service base call.
  • Remove the notify service schema from the hangouts notify platform, as it isn't used. Platforms can't overwrite base component schemas.

Related issue (if applicable):
fixes #18360

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

* Notify platforms shouldn't overwrite the notify component service
  schema. That has no effect.
@MartinHjelmare
Copy link
Copy Markdown
Member Author

I can't test this live. If someone that is affected by the bug can test this branch, that would be awesome!

@edif30
Copy link
Copy Markdown
Contributor

edif30 commented Nov 11, 2018

Just tested. Seems to be working with this fix!

@balloob balloob merged commit 02cc6a2 into home-assistant:dev Nov 11, 2018
@ghost ghost removed the in progress label Nov 11, 2018
balloob pushed a commit that referenced this pull request Nov 15, 2018
* Remove notify schema from hangouts platform

* Notify platforms shouldn't overwrite the notify component service
  schema. That has no effect.

* Fix hangouts service data key value
@balloob balloob mentioned this pull request Nov 15, 2018
@MartinHjelmare MartinHjelmare deleted the fix-hangouts-notify branch December 3, 2018 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hangouts Notify broken with 0.82.0

4 participants