Skip to content

Update credstash.py#18349

Merged
amelchio merged 2 commits intohome-assistant:devfrom
flamechair:patch-2
Nov 10, 2018
Merged

Update credstash.py#18349
amelchio merged 2 commits intohome-assistant:devfrom
flamechair:patch-2

Conversation

@flamechair
Copy link
Copy Markdown
Contributor

@flamechair flamechair commented Nov 10, 2018

Description:

Fixes #18073

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Nov 10, 2018
@ghost ghost added the in progress label Nov 10, 2018
@amelchio amelchio merged commit 8bd281d into home-assistant:dev Nov 10, 2018
@ghost ghost removed the in progress label Nov 10, 2018
@flamechair flamechair deleted the patch-2 branch November 10, 2018 16:48
@balloob balloob mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed core small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

credstash fails to run on (at least) 0.80.3 and higher

3 participants