Skip to content

Update HAP-python to 2.4.0#18355

Merged
fabaff merged 1 commit intohome-assistant:devfrom
cdce8p:homekit-update-2.4.0
Nov 10, 2018
Merged

Update HAP-python to 2.4.0#18355
fabaff merged 1 commit intohome-assistant:devfrom
cdce8p:homekit-update-2.4.0

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Nov 10, 2018

Description:

Changes

  • Fixed issue that caused revert of Update HAP-python to 2.3.0 #17778
  • AccessoryDriver.safe_mode option to enable pairing through zeroconf errors (PR adding this function will follow soon)
  • Fixed CLOSE_WAIT issue and open sockets
  • Fixed slow shutdown with python3.7

Full changelog: https://github.com/ikalchev/HAP-python/blob/dev/CHANGELOG.md

Related issues:
#15675
#16692
#17365
https://community.home-assistant.io/t/homekit-devices-not-responding/74656

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@dmonagle, @ehendrix23 can you both do some testing with this PR. Especially for your respective issues (CLOSE_WAIT and long time to stop HAP)? I don't want to revert it again if it worsens the connection with HomeKit.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 132bb79 into home-assistant:dev Nov 10, 2018
@ghost ghost removed the in progress label Nov 10, 2018
@cdce8p cdce8p deleted the homekit-update-2.4.0 branch November 10, 2018 17:55
@dmonagle
Copy link
Copy Markdown

@cdce8p I've just had a day off so I've spent a bit of time with this. After replicating my setup on hassbian and manually upgrading HAP-python to 2.4.1, I still have issues running on 82.1. Out of pure interest, I installed the dev branch with the same result.

What I am seeing is that when HomeKit first starts, I have a window of maybe a minute where I can operate switches in the Home interface and see them replicated in the Home Assistant GUI. After this time they get a red "No Response" in Home.

Interestingly, even while the switches all show as No Response, I still seem to get notifications (ie. Garage door was opened)

Please let me know if there is anything you'd like me to run/diagnose on this setup. It's Hassbian running on a Raspberry Pi 3 Model B Rev 1.2

@alessandrocolos
Copy link
Copy Markdown

still having the issue of Homekit intermittent problem with 'No response' on IOS devices :-(
Running one raspberry pi 3, hassio 0.88.1

@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented Feb 23, 2019

@alessandrocolos Please don't comment on closed PR's. For issues use the bug tracker, as you already did if I'm not mistaken. Ones is usually enough.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants