Skip to content

Fix including from sub dir#18378

Merged
balloob merged 1 commit intohome-assistant:devfrom
bramkragten:ruamel-include-sub-dir
Nov 11, 2018
Merged

Fix including from sub dir#18378
balloob merged 1 commit intohome-assistant:devfrom
bramkragten:ruamel-include-sub-dir

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Nov 11, 2018

The include path is now always relative to the root of the config dir.

Description:

After the first include the path would be based on the included file, so multiple includes from sub dirs would fail.

Should go in a hotfix.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

The include path is now always relative to the root of the config dir.
@bramkragten bramkragten requested a review from a team as a code owner November 11, 2018 14:42
@homeassistant homeassistant added core small-pr PRs with less than 30 lines. cla-signed labels Nov 11, 2018
@ghost ghost added the in progress label Nov 11, 2018
@balloob balloob added this to the 0.82.1 milestone Nov 11, 2018
@balloob balloob merged commit b8c06ad into home-assistant:dev Nov 11, 2018
@ghost ghost removed the in progress label Nov 11, 2018
@bramkragten bramkragten deleted the ruamel-include-sub-dir branch November 12, 2018 08:30
balloob pushed a commit that referenced this pull request Nov 15, 2018
The include path is now always relative to the root of the config dir.
@balloob balloob mentioned this pull request Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants