Skip to content

Do not sync entities with an empty name#14181

Merged
balloob merged 1 commit intodevfrom
google-assistant-empty-name
Apr 30, 2018
Merged

Do not sync entities with an empty name#14181
balloob merged 1 commit intodevfrom
google-assistant-empty-name

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 30, 2018

Description:

Do not sync over entities to Google Assistant if they have an empty name. This is not allowed by Google.

Example entry for configuration.yaml (if applicable):

cloud:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Copy link
Copy Markdown
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with a template switch and works 👍

@balloob balloob added this to the 0.68.1 milestone Apr 30, 2018
@balloob balloob merged commit 5dcad89 into dev Apr 30, 2018
@balloob balloob deleted the google-assistant-empty-name branch April 30, 2018 13:18
@balloob balloob mentioned this pull request Apr 30, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants