Add prereqs for HomeKit Controller to Dockerfile#14172
Merged
balloob merged 1 commit intohome-assistant:devfrom May 2, 2018
marthoc:homekit-controller-deps-docker
Merged
Add prereqs for HomeKit Controller to Dockerfile#14172balloob merged 1 commit intohome-assistant:devfrom marthoc:homekit-controller-deps-docker
balloob merged 1 commit intohome-assistant:devfrom
marthoc:homekit-controller-deps-docker
Conversation
Contributor
|
This issue also exists if you are just running HA directly under Rasbian. I had to manually install the gmpy2 libs after I updated to 0.68.0 and configured the HomeKit Controller.
… On Apr 29, 2018, at 12:18 PM, Mark Coombes ***@***.***> wrote:
Description:
The new HomeKit Controller component requires homekit==0.6, which in turn requires gmpy2. Gmpy2 was failing to install inside the Docker image when HomeKit Controller loaded due to missing dependencies, resulting in HomeKit Controller failing to load and issue #14062 <#14062>. This PR adds the required dependencies (libmpc-dev, libmpfr-dev, and libgmp-dev).
You may wish to consider this for a point-release since HomeKit controller is currently broken for anyone using Docker. The Raspberry Pi images will also need to be fixed or the issue will persist for Hass.io users.
cc: @mjg59 <https://github.com/mjg59>
Related issue (if applicable): fixes #14062 <#14062> (but see the Hass.io caveat above).
Checklist:
The code change is tested and works locally.
You can view, comment on, or merge this pull request online at:
#14172 <#14172>
Commit Summary
Add prereqs for HomeKit Controller
File Changes
M virtualization/Docker/setup_docker_prereqs <https://github.com/home-assistant/home-assistant/pull/14172/files#diff-0> (2)
Patch Links:
https://github.com/home-assistant/home-assistant/pull/14172.patch <https://github.com/home-assistant/home-assistant/pull/14172.patch>
https://github.com/home-assistant/home-assistant/pull/14172.diff <https://github.com/home-assistant/home-assistant/pull/14172.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#14172>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA1W1PJrhg-Vl7OqRR9j6pN-OZ6jljXvks5tthIagaJpZM4Tr61D>.
|
Contributor
Author
|
@terrycarlin - yes I’m also planning to open a documentation PR to add the gmpy2 libs requirements as a preliminary step. |
balloob
approved these changes
May 2, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The new HomeKit Controller component requires homekit==0.6, which in turn requires gmpy2. Gmpy2 was failing to load inside the Docker image when HomeKit Controller loaded due to missing dependencies, resulting in HomeKit Controller failing to load and issue #14062. This PR adds the required dependencies (libmpc-dev, libmpfr-dev, and libgmp-dev).
You may wish to consider this for a point-release since HomeKit controller is currently broken for anyone using Docker. The Raspberry Pi images will also need to be fixed or the issue will persist for Hass.io users.
cc: @mjg59
Related issue (if applicable): fixes #14062 (but see the Hass.io caveat above).
Checklist: