Add precipitation to OpenWeatherMap forecast#13971
Merged
fabaff merged 10 commits intohome-assistant:devfrom Apr 29, 2018
Merged
Add precipitation to OpenWeatherMap forecast#13971fabaff merged 10 commits intohome-assistant:devfrom
fabaff merged 10 commits intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
platform: weather.openweathermap
small-pr
pvizeli
previously requested changes
Apr 18, 2018
Member
pvizeli
left a comment
pvizeli
left a comment
There was a problem hiding this comment.
You need do that also on component level. Update demo platform and write tests.
Contributor
Author
|
You're right but there are some more things need to be fixed. |
escoand
force-pushed
the
add-precipitation
branch
from
af3423f to
3bf8a50
Compare
houndci-bot
reviewed
Apr 18, 2018
| return | ||
|
|
||
| self.forecast_data = fcd.get_forecast() | ||
|
|
escoand
force-pushed
the
add-precipitation
branch
from
820fcb7 to
3876128
Compare
houndci-bot
reviewed
Apr 18, 2018
| assert data.get(ATTR_FORECAST)[0].get(ATTR_FORECAST_TEMP) == 22 | ||
| assert data.get(ATTR_FORECAST)[0].get(ATTR_FORECAST_TEMP_LOW) == 15 | ||
| assert data.get(ATTR_FORECAST)[6].get(ATTR_FORECAST_CONDITION) == 'fog' | ||
| assert data.get(ATTR_FORECAST)[6].get(ATTR_FORECAST_PRECIPITATION) == 0.2 |
There was a problem hiding this comment.
line too long (81 > 79 characters)
| assert data.get(ATTR_WEATHER_OZONE) is None | ||
| assert data.get(ATTR_WEATHER_ATTRIBUTION) == \ | ||
| 'Powered by Home Assistant' | ||
| assert data.get(ATTR_FORECAST)[0].get(ATTR_FORECAST_CONDITION) == 'rainy' |
There was a problem hiding this comment.
line too long (81 > 79 characters)
Contributor
Author
|
@pvizeli Is this like you expected? |
Contributor
Author
|
More complaints? |
Contributor
Author
|
Are there any more problems prevent merging? |
Member
|
Could you resolve the merge conflict? |
Contributor
Author
|
@syssi Done! |
Member
|
@fabaff Could you take a look at this PR? Thanks! :-) |
Merged
ghost
added
integration: openweathermap
and removed
platform: weather.openweathermap
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add the precipitation into the forecast of OpenWeatherMap.
The corresponding pull-request for the weather card is: home-assistant/frontend#1098
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass