Skip to content

Allow transitioning to colour temp for tradfri#14157

Merged
lwis merged 1 commit intohome-assistant:devfrom
Hate-Usernames:Tradfri
Apr 29, 2018
Merged

Allow transitioning to colour temp for tradfri#14157
lwis merged 1 commit intohome-assistant:devfrom
Hate-Usernames:Tradfri

Conversation

@Hate-Usernames
Copy link
Copy Markdown
Contributor

Description:

Adds transition time when changing colour of a tradfri light.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

tradfri:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fabaff fabaff requested a review from lwis April 29, 2018 15:37
@lwis lwis changed the title Tradfri allow transitioning between colours Allow transitioning to colour temp for tradfri Apr 29, 2018
@lwis
Copy link
Copy Markdown
Member

lwis commented Apr 29, 2018

Looks good, must have missed this when I did my refactoring. 🐊

@lwis lwis merged commit 113bdc4 into home-assistant:dev Apr 29, 2018
@Hate-Usernames Hate-Usernames deleted the Tradfri branch April 29, 2018 17:52
@balloob balloob mentioned this pull request May 11, 2018
@poldy79
Copy link
Copy Markdown

poldy79 commented May 20, 2018

I just upgraded to version 0.69. Transition is working for brightness but not for kelvin. Color changes instantly, brightness as expected. Any suggestions?

@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants