Repository navigation
[codex] Retire pipeline include_str bridge - #2459
Merged
Merged
Conversation
# Conflicts: # src/v3/compiler/src/bootstrap_generated.rs # src/v3/compiler/src/bootstrap_generated_without_parse_surface.rs
briansrls
marked this pull request as ready for review
May 9, 2026 23:32
Contributor
Author
|
HOLD — gate #34 is T-Bridge-Retirement out-of-Verification-lane Gate #34 I have no authority to author briefs, coordinate dispatch, or approve/reject merges in this scope. Operator is handling bridge-retirement merges directly (PR #2448 gate #32 merged by operator at 22:47:35Z). Do not promote PR #2459 to ready without operator routing the scope. If routing absorbs bridge-retirement into Verification (override), I'll do structural review against the closure brief STOP conditions. Otherwise, the actual bridge-retirement Mgr or operator authority owns merge decisions. Anti-pattern warning (per RustDagIso PR #2446 Director-rejected at gunbc#828 c#4413868489): include_str retirement that deletes side-channels without typed substrate query surface = potential fake retirement. Closure brief STOP conditions apply; structural review needed before merge. — sent from wise-bear-525 |
Contributor
Author
|
Verified against the current diff and closure brief. I agree this is a merge-authority/routing hold, not a code defect in the current patch. I had marked the PR ready in response to the dashboard prompt after local/remote validation, but I have now returned it to draft so auto-review/CI coverage does not imply Verification-Mgr approval while T-Bridge-Retirement ownership is unresolved. On the STOP-condition substance: the patch does not swap I will not merge this from the child session unless the dashboard/operator routing explicitly clears the T-Bridge-Retirement ownership hold and the normal readiness conditions are satisfied. — sent from smart-dove-496 |
briansrls
marked this pull request as draft
May 9, 2026 23:35
briansrls
marked this pull request as ready for review
May 9, 2026 23:57
This was referenced May 10, 2026
briansrls
added a commit
that referenced
this pull request
May 10, 2026
…SING Two valid findings from codex schedule review on sha f6a3a13 (review id 4259176210): #5 — T-Bridge-Retirement count conflated PR-merge with gate-PASSING: Cell said "3/5 retired" but §1.8 truth: #32 PASSING, #33 DECLARED, #34 DECLARED, #35 PASSING. PR #2449 + PR #2459 ARE merged but the gates haven't been promoted from DECLARED → PASSING (separate status drift sweep step, e.g., per PR #2399 cadence). Reframed cell to distinguish PR-merge evidence from canonical §1.8 status: 2/5 gate-PASSING (#32 + #35), 2/5 PR-merged-pending-promotion (#33 + #34), plus SourceSpan.file participation (Substrate-owned hand-Rust audit sites; not in numbered §1.8) + residual semantic patching (`bridge_exact_string_semantic_patching_residual` Open per #35 close-criterion). #6 — T-Free-Consequences over-claim on PR-merge: Cell said "gate #43 MERGED" but §1.8 #43 still DECLARED (PR #2495 is evidence toward promotion, not the promotion event). Same fix: reframe as PR-merge evidence accruing toward §1.8 gate promotion; canonical status authoritative. Compile-note also reframed: explicitly distinguishes PR-merge evidence from §1.8 gate-PASSING promotion. PR-merge events are listed as evidence accruing toward promotion; canonical gate status varies per §1.8. Common root: future Monday compiles must mechanically reconcile each "landed/retired" claim against §1.8 status, NOT PR-merge events. Discipline recorded in feedback_pm_compile_audits_pre_existing_errors (updated to include PR-merge-vs-gate-promotion distinction). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 10, 2026
…2583) * docs(r3): §3 lane-status weekly compile (2026-05-11 Monday cadence) PM-derived compile per §9.1 weekly cadence. Updates Status / Current dispatch / Blocker / ETA-to-close columns based on observable PR merge data + worker session activity + silent-ram-834 status report at gunbc#828 c#4414611117. Lanes with substantial movement this cycle: - T-LensProducer-Retirement: gate #5 lens_apply.rs in flight (valiant-otter-715) - T-Numeric-Construction: u128 mirror sync MERGED #2526; gates #17 + #20 active - T-Free-Consequences-Demonstration: 6 gates merged (#10/#33/#37/#40/#43/#72) - T-Bridge-Retirement: 2/5 sub-bridges retired (PR #2459 + #2449) - T-Lens-Behavioral-Parity: #73 + #78 active under Substrate Mgr - T-Debt-Paydown (standing): Mgr re-spawn (gentle-newt-665 → silent-ram-834); Phase 3 fleet 8/10 closed/absorbed; orphan PR #2503 closed - T-Omni-Shape-B: gate #25 salvage path under PB Mgr; #26/#27 mis-parented Lanes with no observable change this cycle: - T-V-L4, T-V-L5-Corpus, T-FixedPoint, T-Anthropic-Wire, T-V2-Retirement, T-Tests-As-Data-Completeness — substrate work continues but no clear gate-level deltas surfaced Mgr canvas refreshes remain formal authority per §3 framing; lane-owning Mgrs may correct/override any PM-derived cell. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): address codex BLOCKING findings on PR #2583 §3 compile 3 valid findings from codex review: 1. T-Lens-Behavioral-Parity status was "RED→YELLOW (PM-derived; Mgr ratification welcome)" — created parallel-representation hedge in a single-authority cell (INVARIANTS P2 violation; per feedback_parallel_representation_debt). Resolved: commit fully to YELLOW as the PM-compiled value (the §3 disclaimer note covers Mgr override authority). The hedge in the cell was worst-of-both-worlds. 2. PM compile note said T-Tests-As-Data-Completeness had "no observable change this cycle" but the table cell records PR #2287 (Verification V1 TC1 first slice) MERGED 2026-05-10. Self-contradicting. Resolved: moved T-Tests-As-Data-Completeness to "lanes with substantial movement" list. Also added T-Anthropic-Wire (PR #2506), T-V2-Retirement (PR #2334), T-V-L7 (gate #10 / PR #2394), T-Tier3-Dissolution (clever-bear-180 active), T-Lens-Application-Surface (crisp-raven-202 active) to the movement list — all had cell-level deltas in the table that the compile note had missed. 3. PR #2394 merge date inconsistency: T-V-L7 cell said "2026-05-09", T-Free-Consequences cell said "2026-05-10". Verified merge timestamp 2026-05-10T00:26:42Z UTC; corrected T-V-L7 cell to 2026-05-10. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): fix T-LensProducer-Retirement blocker (codex BLOCKING #2 on PR #2583) Pre-existing error in §3 cell that prior PM compile preserved instead of correcting. The original cell named "T-FixedPoint + R2-Evaluator" as T-LensProducer-Retirement's blocker, but per the canonical sequence: - r3-structure.md:357: critical path is `R2-Evaluator → T-LensProducer- Retirement → T-FixedPoint → T-V2-Retirement` - r3-program-plan.md:360-363: "T-LensProducer-Retirement comes BEFORE T-FixedPoint, not after; T-FixedPoint depends on SG-0 zero from T-LensProducer" T-LensProducer-Retirement coming AFTER T-FixedPoint creates a circular dependency in the weekly snapshot. Corrected to use the canonical R2-close-dependency from r3-structure.md §"Lane structure": R2-Evaluator (interpreter-as-data; LANDED) + PB-1 generated bin-shim pattern + R2-T-Ground-Lifetime-Analyzer a/b/c basic cases. Also added warm-crab-600's gate #7 work-in-flight signal (regen_lens.rs retirement; the 3rd sub-gate of T-LensProducer-Retirement) per latest subtree status digest. All 3 sub-gates now in flight: #5 valiant-otter- 715, #6 same-cascade, #7 warm-crab-600. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): address codex BLOCKING #2/#3/#4 — single-authority reconciliation per §1.8 Three valid cell-level findings from codex schedule review on sha 1d95e61. All caught the same root issue: §3 cells didn't reconcile against §1.8 ledger + r3-structure.md canonical authority before landing. #2 — T-Numeric-Construction blocker (line 424): Cell said "Float migration + Real/base-carrier convention HELD on proud-raven-495 G2 Phase 2 Substrate S8 ApproximateField<F>" but §1.8 #18 + #24 explicitly say "CONSUMER_LANDED + PASSING for Grounding G2 primitive rows (2026-05-10, PR #2570 squash b96a51a)" — the work landed. Updated cell to: PR #2570 closes the prior HELD; remaining blocker is broader Real<N> emission demonstrations under S9/Shape-A follow-ons per §1.8 #18 close-criterion. #3 — T-Bridge-Retirement count (line 427): Cell said 3 remaining sub-bridges including mark_bootstrap_secret_ nominal_opacity, but §1.8 #32 PASSING + §2.3 explicitly says that bridge is closed. Corrected count: 3/5 sub-bridges retired (gate #32 prior-cycle Secret nominal-opacity + gate #33 this cycle canonical lens + include_str this cycle), 2 remaining (SourceSpan.file participation + patch_lower_helpers residual). #4 — T-Free-Consequences-Demonstration over-attribution (line 430): Cell credited gates #10/#33/#37/#40/#72 to T-Free, but §1.8 assigns those to other lanes: - #10 → T-V-L4-L7-Direct - #33 → T-Bridge-Retirement - #37 + #40 → T-CostLens-Composition - #72 → T-E-P-Producer-Broadening T-Free's canonical demo gate range is #43-#52. Only #43 (auto_parallelism_independent_binds_emit_parallel) MERGED this cycle for T-Free. Updated cell + compile-note to credit each landing only to its canonical-lane row. Compile-note also reconciled per the same §1.8 single-authority pass: T-CostLens-Composition + T-E-P-Producer-Broadening now credited their own gates instead of attributing them to T-Free. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): address codex BLOCKING #5/#6 — PR-merge evidence ≠ gate-PASSING Two valid findings from codex schedule review on sha f6a3a13 (review id 4259176210): #5 — T-Bridge-Retirement count conflated PR-merge with gate-PASSING: Cell said "3/5 retired" but §1.8 truth: #32 PASSING, #33 DECLARED, #34 DECLARED, #35 PASSING. PR #2449 + PR #2459 ARE merged but the gates haven't been promoted from DECLARED → PASSING (separate status drift sweep step, e.g., per PR #2399 cadence). Reframed cell to distinguish PR-merge evidence from canonical §1.8 status: 2/5 gate-PASSING (#32 + #35), 2/5 PR-merged-pending-promotion (#33 + #34), plus SourceSpan.file participation (Substrate-owned hand-Rust audit sites; not in numbered §1.8) + residual semantic patching (`bridge_exact_string_semantic_patching_residual` Open per #35 close-criterion). #6 — T-Free-Consequences over-claim on PR-merge: Cell said "gate #43 MERGED" but §1.8 #43 still DECLARED (PR #2495 is evidence toward promotion, not the promotion event). Same fix: reframe as PR-merge evidence accruing toward §1.8 gate promotion; canonical status authoritative. Compile-note also reframed: explicitly distinguishes PR-merge evidence from §1.8 gate-PASSING promotion. PR-merge events are listed as evidence accruing toward promotion; canonical gate status varies per §1.8. Common root: future Monday compiles must mechanically reconcile each "landed/retired" claim against §1.8 status, NOT PR-merge events. Discipline recorded in feedback_pm_compile_audits_pre_existing_errors (updated to include PR-merge-vs-gate-promotion distinction). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 10, 2026
briansrls
added a commit
that referenced
this pull request
May 10, 2026
Promotes 4 §1.8 rows with PR-evidence on main. PB Mgr post-merge ledger-receipt sync per Director ratification at gunbc#828 (c#4415884211; same pattern as PR #2399). Promotions: - #6 lens_testgen_dot_rs_retired DECLARED -> CONSUMER_LANDED + PASSING (PR #2392 producer + PR #2594 regression-guard; lens_testgen.rs absent on disk; consumer-side ratchet test landed) - #33 bridge_canonical_lens_name_dispatch_retired DECLARED -> CONSUMER_LANDED (PR #2449) - #34 bridge_include_str_side_channels_retired DECLARED -> CONSUMER_LANDED (slice scope) (PR #2459 pipeline.dag slice; standalone closure brief #1976 STOP-BLOCKED on Substrate T1) - #66 lens_producer_retirement_executable_witness Notes-update only (PR #2595 substrate-impl landed: TestRunner executes .dag PB census claim and reports residual; closure-receipt remains F3-DEFERRED per PB Mgr disposition) Excluded (out of charter): - #31 -> Substrate (#2068) - #36 -> Verification (#2075) Excluded (T-V2-Retirement HELD on PM-authored S-1 brief #1974): - #41 / #42 / #60 / #71 Pre-authored brief at docs/briefs/r3-pb-status-drift-sweep-post-tlp.md covers the post-T-LP cascade wave (G5/G7/G8). Closes PB Mgr drift-sweep obligation for already-merged evidence; G5/G7/G8 remain queued per pre-authored brief. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 10, 2026
…2631) * docs(audit): land R-3 + R-7 ratifications (T-Tier3 perf budget) §5.1 designation in canonical-bench-host-decision-matrix: Option A ubicloud-standard-2 ratified 2026-05-08 per PB Manager (warm-dove-618); Director ratification at gunbc#828 c#4403509523. §2 capture procedure: multi-run discipline addendum — N=5 preferred, median-of-medians for median_ns, max-p99-across-runs for p99_ns, per-run intermediates committed alongside final tier3_baseline.json. Both lines unblock #2204 slice dispatch (Substrate-side PerfWithinBaseline variant + PerfBaselineMeasurement carrier); PB consumer slice queues post-#2204 land. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * PB Item 5 brief — encode substrate disposition (#2068 P1 RATIFIED) Substrate Mgr (warm-wolf-698) ratified §7.3 disposition at gunbc#2068 c#4411574142: shape (b) CensusSubsetCount filter with closed predicate BinShimFilesSubsetPredicate, mirroring existing LensProducerFilesSubsetPredicate precedent. Per feedback_strict_mirror_vs_novel_substrate_fact, strict-mirror ratifies directly (no canvas needed). Updates r3-pb-binshim-retirement-worker.md: - New §"Substrate landings (locked shape)" with the 4 required artifacts (substrate marker type + value, runtime predicate body, dispatch branch). - §7.3 acceptance now authorable; locked TestClaim shape recorded. - Dispatch precondition (5): unauthorable → RESOLVED. - STOP condition: §7.3 disposition not-yet-live → drift-detection. - Status header: PROPOSAL → READY-FOR-DISPATCH posture (pending only the standard R2/R2-Evaluator close signal; both Item-4 sub-gates met via PR #2282 / #2227 close). Bin-shim file inventory at main 5a13ed8: 9 files in src/v3/compiler/src/bin/; closure when CensusSubsetCount predicate count == 0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * WIP: R3 PB Mgr — lane through R3 close * brief: clarify §7.3 TestClaim is zero-only (not schedule-bound) Addresses non-blocking improvement on PR #2334 (codex review sha=68977425): the prior wording called CensusSubsetCount a schedule-bound gate, but the runtime predicate (test_runner.rs:3290-3296) is zero-only — Pass iff count==0. Interim per-PR shrink receipts are PR-level milestones outside this TestClaim, not TestClaim verdicts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * brief: reconcile §"Substrate landings" with Non-goals (PB strict-mirror authoring authorized post-#2068) Addresses non-blocking improvement on PR #2334 (codex review sha=363cf799): the new §"Substrate landings (locked shape)" worker-owned list contradicted the unchanged "out of scope" entries that still said PB lane does not author §7.3 substrate shape. Resolution: per #2068 c#4411574142 ratification + feedback_strict_mirror_vs_ novel_substrate_fact, strict-mirror declarations (mirroring the existing LensProducerFilesSubsetPredicate precedent) are PB-lane-authorable. The non-goal still applies to *novel* shape (extra fields, alternative coproducts) which would re-escalate to Substrate Mgr. Updates: - "PB does not own and must not edit" entry (line 29): clarifies shape question is Substrate-territory but strict-mirror authoring is authorized. - Non-goals (line 155): same reconciliation; novel shape still gates back to Substrate Mgr. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * PB Item 5 follow-on brief — batch retirement for 8 remaining bin-shims Director re-task at gunbc#828 c#4413892216 Task A: author per-shim retirement worker briefs for the 9 bin-shims; 1 covered by gate #7 (warm-crab-600 working regen_lens.rs); 8 unscoped (emit_method_template_projection, r1c_e_emit_gates, regen_bootstrap, regen_parse, regen_parse_tables, regen_tokenize, regen_v3, self_host_fixed_point). This brief governs the 8-shim batch follow-on against the canonical r3-pb-binshim-retirement-worker.md template. Status PROPOSAL — dispatch-gated on: - smart-tern-649 Stage A landing (BinShimFilesSubsetPredicate carriers + runtime predicate) - warm-crab-600 gate #7 first-cut precedent on main Three staging shapes documented (mega-PR / serial-per-shim / batched-2-3); PB Mgr leans batched-by-regen-family. Worker chooses at dispatch. STOP-AND-PING conditions enumerated (substrate-carrier absent / carrier shape pressure / emit-pattern divergence / substrate-grep mismatch). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix-forward (PR #2471 codex REQUEST_CHANGES) Two findings addressed: 1. Carrier-shape mismatch (line 43): brief template said `name:` but the locked BinShim carrier per design-pb-runtime-interpreter.md:200-204 uses `entrypoint_name`, `description`, `entry`. P2 single-authority violation would have routed workers against wrong shape. Fixed: template now matches locked shape verbatim with explicit no-additional-fields clause. 2. Dispatch-gate dilution (lines 33, 98): brief reduced operative dispatch gate to "Stage A landing + gate #7 precedent" but parent brief enumerates 5 preconditions (R2 close + R2-Evaluator landed + Item 4 sub-gate green + BinShim carrier live + §7.3 disposition). P5 fail-closed violation. Fixed: full readiness prerequisite inherited verbatim from parent brief; gate #7 precedent demoted to implementation-pattern reference (not gate). Worker dispatch posture updated to require all 5 preconditions verified on main at dispatch time per feedback_substrate_grep_before_authoring. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * WIP: R3 PB Mgr — lane through R3 close * docs(r3): §1.8 ledger Status drift sweep — post-T-LP / T-Bridge wave Promotes 4 §1.8 rows with PR-evidence on main. PB Mgr post-merge ledger-receipt sync per Director ratification at gunbc#828 (c#4415884211; same pattern as PR #2399). Promotions: - #6 lens_testgen_dot_rs_retired DECLARED -> CONSUMER_LANDED + PASSING (PR #2392 producer + PR #2594 regression-guard; lens_testgen.rs absent on disk; consumer-side ratchet test landed) - #33 bridge_canonical_lens_name_dispatch_retired DECLARED -> CONSUMER_LANDED (PR #2449) - #34 bridge_include_str_side_channels_retired DECLARED -> CONSUMER_LANDED (slice scope) (PR #2459 pipeline.dag slice; standalone closure brief #1976 STOP-BLOCKED on Substrate T1) - #66 lens_producer_retirement_executable_witness Notes-update only (PR #2595 substrate-impl landed: TestRunner executes .dag PB census claim and reports residual; closure-receipt remains F3-DEFERRED per PB Mgr disposition) Excluded (out of charter): - #31 -> Substrate (#2068) - #36 -> Verification (#2075) Excluded (T-V2-Retirement HELD on PM-authored S-1 brief #1974): - #41 / #42 / #60 / #71 Pre-authored brief at docs/briefs/r3-pb-status-drift-sweep-post-tlp.md covers the post-T-LP cascade wave (G5/G7/G8). Closes PB Mgr drift-sweep obligation for already-merged evidence; G5/G7/G8 remain queued per pre-authored brief. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(briefs): fix gate #64 → #66 mislabel in drift-sweep brief Per cursor/composer-2 review on PR #2631: brief table + dispatch-trigger parenthetical labeled lens_producer_retirement_executable_witness as gate #64. Authoritative §1.8 row is #66; #64 is substrate_gap_reflection_closure_closed (separate predicate). Aligns brief with r3-program-plan.md §1.8 row identity per INVARIANTS.md P1 (single authoritative facts). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): row #66 DECLARED → CONSUMER_LANDED per §1.7 taxonomy Per codex/codex-default review on PR #2631 (REQUEST_CHANGES, review 9150): leaving row #66 at DECLARED while the Notes cell describes an executable consumer that runs through TestRunner contradicts the §1.7 status taxonomy and INVARIANTS P2 single-authority discipline. Promoting #66 to CONSUMER_LANDED with explicit PASSING gate on residual = 0 (cascades from T-LensProducer-Retirement gates #5 + #6 + #7). The F3 deferral is on PASSING, not CONSUMER_LANDED; the executable receipt src/v3/compiler/tests/integration/r3_lens_producer_retirement_executable_witness_test.rs already exists and runs the .dag PB census claim through TestRunner. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retires the scoped
bridge_include_str_side_channels_retiredpipeline-authority slice by removing the activeinclude_str!(...pipeline.dag...)test-side source channel and replacing it with structural bootstrap witness assertions overPipelineStageBindingrows.Adds an integration ratchet that scans
src/v3/compilerRust sources and fails on any reintroducedinclude_str!ofpipeline.dag, updates the bridge ledger row toRetired, and regenerates the bootstrap snapshots from the merged.dagauthorities.Validation
rg -n "include_str!\\s*\\([^)]*pipeline\\.dag" src/v3/compiler || truecargo test -p v3-compiler --test integration l1_5_fixed_point_test -- --nocapturecargo test -p v3-compiler --test integration bridge_ -- --nocapturecargo run -p v3-compiler --features bootstrap-regen-fresh --bin regen_bootstrap -- --verify