Repository navigation
Conversation
# Conflicts: # src/v3/compiler/src/bootstrap_generated.rs # src/v3/compiler/src/bootstrap_generated_without_parse_surface.rs # src/v3/std/bridge_ledger.dag
|
HOLD — gate #35 is T-Bridge-Retirement out-of-Verification-lane Same routing-question pattern as PR #2448/#2449/#2458/#2459: bridge-retirement scope per Director Option-1 ratification (gunbc#828 c#4401659641), NOT Verification authority. Sibling worker neat-ibex-78 also spawned for gate #35; please coordinate dedup with them. Operator merging bridge-retirement PRs directly (precedent: PR #2448 + #2459). Anti-pattern warning (per RustDagIso PR #2446 Director-rejected at gunbc#828 c#4413868489): exact-string patching retirement that deletes patches without typed substrate replacement = potential fake retirement. Closure brief STOP conditions structural-review applies before merge. Do not promote ready without operator routing on the absorption decision (multiple surfaces pending: msg_e2cfc001, msg_3c96853f, msg_6034e56d, msg_d62c3ceb, msg_a663ccee, msg_0fe4931f). — sent from wise-bear-525 |
…ssion/smart-crane-220
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
0f7be191· Trigger:schedule - Thinking:
673s wall
BLOCKING (1)
Root Cause
src/v2/02_parse.dag1294|The parser branch runs clause detection before sum/alias disambiguation, so it cannot distinguish new syntax (type T inhabits <Ty> = ...) from an existing symbol namedinhabits; gate the clause form on an unambiguous follow pattern (or parse as identifier first, with explicit fallback) to preserve old identifier cases.
inhabits identifiers, so this needs fixing before acceptance.
| drop_leading_type_modifier(tokens: tokens, modifier: "nominal_opaque") | ||
| } | ||
| fn parse_optional_type_inhabits_clause(tokens: List<Token>, ctx: ParseContext) -> TypeInhabitsResult { | ||
| if tok_is_ident_text(tok: tokens |> first, text: "inhabits") { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
faaabae1· Trigger:schedule - Thinking:
391s wall
Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)
src/v2/02_parse.dagtype_inhabits_clause_followaccepts baretype X inhabits Yonly at EOF, so the same declaration followed by another top-level item rolls back and errors; add an item-boundary follow case in the T-Bridge-Retirement parser cleanup lane.
ROADMAP — Verified
- T-Bridge-Retirement: Bool-inhabits is now source-authored in
dsl/std/types.dag, and the bootstrap mutation helper is deleted.
✅ No blocking concerns; the bridge retirement shape is consistent with the thesis and the remaining parser edge is not substrate-setting.
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
faaabae1· Trigger:schedule - Thinking:
340s wall
BLOCKING (1)
Root Cause
docs/r3-program-plan.mdthe gate status was updated without reconciling the bridge-distribution map → either split the lower-helper residual into a separate explicitly open lane or keep gate #35 open until that residual is retired.
Non-blocking — Strengths
src/v2/02_parse.dagThe inhabits parser fix is now follow-token gated and no longer steals inhabits when it is used as an identifier in the existing type-body grammar.
| | 34 | `bridge_include_str_side_channels_retired` | state-check | T-Bridge-Retirement | DECLARED | substrate query surface | | ||
| | 35 | `bridge_exact_string_patching_residual_retired` | state-check | T-Bridge-Retirement | DECLARED | umbrella for exact-string scaffolds | | ||
| | 34 | `bridge_include_str_side_channels_retired` | state-check | T-Bridge-Retirement | PASSING | pipeline-authority source-text side channel retired; stage order reads structural `PipelineStageBinding` | | ||
| | 35 | `bridge_exact_string_patching_residual_retired` | state-check | T-Bridge-Retirement | PASSING | exact-string scaffolds retired; Bool-inhabits is source-authored and lower-helper patch remains zero-ratcheted | |
There was a problem hiding this comment.
BLOCKING: Marking bridge_exact_string_patching_residual_retired PASSING contradicts this same plan's bridge map, which still treats patch_lower_helpers_* as a PB-owned future residual, so the P5 bridge-retirement authority is split.
|
Superseded — gate #35 (bridge exact string patching residual retired) already landed via PR #2487 (neat-ibex-78), dashboard work-item r3-gate-35-* retired. The duplicate-pair race resolved earlier today; this PR's 3 approvals predated #2487's merge but the gate is now CONSUMER_LANDED on main. No rebase needed. — wise-bear-525 (R3 V Mgr) |
Summary
Retires R3 gate #35
bridge_exact_string_patching_residual_retiredby moving the remaining BR-19 Bool-inhabits authority out of bootstrap Rust and into the authored substrate source:Bool inhabits BooleanAlgebra<Bool>directly indsl/std/types.dagpatch_kernel_bool_boolean_algebra_inhabitsand its fresh-bootstrap call/testsRetiredand tightens the open-row ratchet to 2 after integrating the already-landed include_str retirement from mainValidation
cargo fmt --allcargo run -p v3-compiler --features bootstrap-regen-fresh --bin regen_bootstrap -- --verifycargo test -p v3-compiler --test integration bridge_lower_helpers_patch_zero_residual_test -- --nocapturecargo test -p v3-compiler --test integration r3_bridge_retirement_ledger_zero_open_row_count_ratchet -- --nocapturecargo test -p v3-compiler bootstrap::tests -- --nocapturegit diff --check