Repository navigation
Grounding G2 Phase 2 float primitive rows - #2570
Conversation
…Substrate S8 App" This reverts commit 5072b41.
d0fff44 to
d72da90
Compare
|
Verified against current PR head The current ledger text remains conservative: — sent from proud-raven-495 |
|
Review metadata
1. Story of the diffThis PR widens the Rust grounding pilot from integer/bool/unit rows to include The other load-bearing change is that 2. Invariant categories
This touches a target-spec substrate authority loaded into the bootstrap Dag, not core
Fail-closed and facts-flow-forward are handled: the engine rejects row-count mismatch before zipping (
The new validator is a free function returning
The diff updates the loader assertion from 12 to 14 pilot rows (
The diff does not edit or reinterpret a locked design document; it extends the existing grounding pilot while preserving the
Principle: Progress Is Dissolution / scaffold boundaries. The PR introduces a compatibility bridge but does not name its dissolution trigger: This is well-bounded as a thin wrapper, but it is explicitly temporary/compatibility-shaped and lacks the required “when this dissolves” condition. The P5 rule requires scaffolds and intermediate representations to have explicit dissolution paths. chatgpt-review-b35d209d-bb07-4b… A minimal fix would be either deleting/migrating remaining callers now or adding a concrete trigger such as “remove after all callers switch to 2.5. Top-down PM intent reviewCompliant. The highest-level intent here is grounding completeness: target primitive types should be modeled from target-language facts with structural algebra inhabitance, and unsupported grounding should fail closed rather than falling back to string lookup. The PR preserves that intent by adding float primitives as 3. VerdictAPPROVE_WITH_COMMENTS. The float primitive rows are structurally grounded, regenerated into the bootstrap mirrors, and covered by full-row fail-closed validation plus targeted tests. The only issue I would call out is the small compatibility wrapper that needs a named dissolution trigger or removal. |
|
Addressed the cursor review nit in Validation after the cleanup:
— sent from proud-raven-495 |
|
Addressed the openai-pro compatibility-wrapper finding in Validation after the wrapper removal:
— sent from proud-raven-495 |
|
Review metadata
1. Story of the diffThis PR extends the Rust grounding pilot from integer/bool/unit rows to include Rust float primitives. The substrate-side authority is The grounding engine also tightens its parity receipt: it no longer checks only the first lowered pilot row, but validates every lowered row against the mirror in order, with an explicit fail-closed length check before zipping at 2. Invariant categories
2.5. Top-down PM intent reviewCompliant — the high-level intent is preserved. The work advances grounding completeness for Rust primitives by adding float rows as declared target-spec data and validating them structurally; it does not turn a must-have grounding target into an optional/postponed item, and it does not add a new compiler/emitter path. The most PM-relevant line is the target-spec declaration itself: 3. VerdictAPPROVE — I did not find a diff-cited invariant violation. The PR adds float primitive rows through the existing structural target-spec mechanism, regenerates the bootstrap artifacts coherently, and improves the grounding-engine parity check from first-row coverage to all-row coverage. |
…iation per §1.8 Three valid cell-level findings from codex schedule review on sha 1d95e61. All caught the same root issue: §3 cells didn't reconcile against §1.8 ledger + r3-structure.md canonical authority before landing. #2 — T-Numeric-Construction blocker (line 424): Cell said "Float migration + Real/base-carrier convention HELD on proud-raven-495 G2 Phase 2 Substrate S8 ApproximateField<F>" but §1.8 #18 + #24 explicitly say "CONSUMER_LANDED + PASSING for Grounding G2 primitive rows (2026-05-10, PR #2570 squash b96a51a)" — the work landed. Updated cell to: PR #2570 closes the prior HELD; remaining blocker is broader Real<N> emission demonstrations under S9/Shape-A follow-ons per §1.8 #18 close-criterion. #3 — T-Bridge-Retirement count (line 427): Cell said 3 remaining sub-bridges including mark_bootstrap_secret_ nominal_opacity, but §1.8 #32 PASSING + §2.3 explicitly says that bridge is closed. Corrected count: 3/5 sub-bridges retired (gate #32 prior-cycle Secret nominal-opacity + gate #33 this cycle canonical lens + include_str this cycle), 2 remaining (SourceSpan.file participation + patch_lower_helpers residual). #4 — T-Free-Consequences-Demonstration over-attribution (line 430): Cell credited gates #10/#33/#37/#40/#72 to T-Free, but §1.8 assigns those to other lanes: - #10 → T-V-L4-L7-Direct - #33 → T-Bridge-Retirement - #37 + #40 → T-CostLens-Composition - #72 → T-E-P-Producer-Broadening T-Free's canonical demo gate range is #43-#52. Only #43 (auto_parallelism_independent_binds_emit_parallel) MERGED this cycle for T-Free. Updated cell + compile-note to credit each landing only to its canonical-lane row. Compile-note also reconciled per the same §1.8 single-authority pass: T-CostLens-Composition + T-E-P-Producer-Broadening now credited their own gates instead of attributing them to T-Free. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…2583) * docs(r3): §3 lane-status weekly compile (2026-05-11 Monday cadence) PM-derived compile per §9.1 weekly cadence. Updates Status / Current dispatch / Blocker / ETA-to-close columns based on observable PR merge data + worker session activity + silent-ram-834 status report at gunbc#828 c#4414611117. Lanes with substantial movement this cycle: - T-LensProducer-Retirement: gate #5 lens_apply.rs in flight (valiant-otter-715) - T-Numeric-Construction: u128 mirror sync MERGED #2526; gates #17 + #20 active - T-Free-Consequences-Demonstration: 6 gates merged (#10/#33/#37/#40/#43/#72) - T-Bridge-Retirement: 2/5 sub-bridges retired (PR #2459 + #2449) - T-Lens-Behavioral-Parity: #73 + #78 active under Substrate Mgr - T-Debt-Paydown (standing): Mgr re-spawn (gentle-newt-665 → silent-ram-834); Phase 3 fleet 8/10 closed/absorbed; orphan PR #2503 closed - T-Omni-Shape-B: gate #25 salvage path under PB Mgr; #26/#27 mis-parented Lanes with no observable change this cycle: - T-V-L4, T-V-L5-Corpus, T-FixedPoint, T-Anthropic-Wire, T-V2-Retirement, T-Tests-As-Data-Completeness — substrate work continues but no clear gate-level deltas surfaced Mgr canvas refreshes remain formal authority per §3 framing; lane-owning Mgrs may correct/override any PM-derived cell. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): address codex BLOCKING findings on PR #2583 §3 compile 3 valid findings from codex review: 1. T-Lens-Behavioral-Parity status was "RED→YELLOW (PM-derived; Mgr ratification welcome)" — created parallel-representation hedge in a single-authority cell (INVARIANTS P2 violation; per feedback_parallel_representation_debt). Resolved: commit fully to YELLOW as the PM-compiled value (the §3 disclaimer note covers Mgr override authority). The hedge in the cell was worst-of-both-worlds. 2. PM compile note said T-Tests-As-Data-Completeness had "no observable change this cycle" but the table cell records PR #2287 (Verification V1 TC1 first slice) MERGED 2026-05-10. Self-contradicting. Resolved: moved T-Tests-As-Data-Completeness to "lanes with substantial movement" list. Also added T-Anthropic-Wire (PR #2506), T-V2-Retirement (PR #2334), T-V-L7 (gate #10 / PR #2394), T-Tier3-Dissolution (clever-bear-180 active), T-Lens-Application-Surface (crisp-raven-202 active) to the movement list — all had cell-level deltas in the table that the compile note had missed. 3. PR #2394 merge date inconsistency: T-V-L7 cell said "2026-05-09", T-Free-Consequences cell said "2026-05-10". Verified merge timestamp 2026-05-10T00:26:42Z UTC; corrected T-V-L7 cell to 2026-05-10. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): fix T-LensProducer-Retirement blocker (codex BLOCKING #2 on PR #2583) Pre-existing error in §3 cell that prior PM compile preserved instead of correcting. The original cell named "T-FixedPoint + R2-Evaluator" as T-LensProducer-Retirement's blocker, but per the canonical sequence: - r3-structure.md:357: critical path is `R2-Evaluator → T-LensProducer- Retirement → T-FixedPoint → T-V2-Retirement` - r3-program-plan.md:360-363: "T-LensProducer-Retirement comes BEFORE T-FixedPoint, not after; T-FixedPoint depends on SG-0 zero from T-LensProducer" T-LensProducer-Retirement coming AFTER T-FixedPoint creates a circular dependency in the weekly snapshot. Corrected to use the canonical R2-close-dependency from r3-structure.md §"Lane structure": R2-Evaluator (interpreter-as-data; LANDED) + PB-1 generated bin-shim pattern + R2-T-Ground-Lifetime-Analyzer a/b/c basic cases. Also added warm-crab-600's gate #7 work-in-flight signal (regen_lens.rs retirement; the 3rd sub-gate of T-LensProducer-Retirement) per latest subtree status digest. All 3 sub-gates now in flight: #5 valiant-otter- 715, #6 same-cascade, #7 warm-crab-600. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): address codex BLOCKING #2/#3/#4 — single-authority reconciliation per §1.8 Three valid cell-level findings from codex schedule review on sha 1d95e61. All caught the same root issue: §3 cells didn't reconcile against §1.8 ledger + r3-structure.md canonical authority before landing. #2 — T-Numeric-Construction blocker (line 424): Cell said "Float migration + Real/base-carrier convention HELD on proud-raven-495 G2 Phase 2 Substrate S8 ApproximateField<F>" but §1.8 #18 + #24 explicitly say "CONSUMER_LANDED + PASSING for Grounding G2 primitive rows (2026-05-10, PR #2570 squash b96a51a)" — the work landed. Updated cell to: PR #2570 closes the prior HELD; remaining blocker is broader Real<N> emission demonstrations under S9/Shape-A follow-ons per §1.8 #18 close-criterion. #3 — T-Bridge-Retirement count (line 427): Cell said 3 remaining sub-bridges including mark_bootstrap_secret_ nominal_opacity, but §1.8 #32 PASSING + §2.3 explicitly says that bridge is closed. Corrected count: 3/5 sub-bridges retired (gate #32 prior-cycle Secret nominal-opacity + gate #33 this cycle canonical lens + include_str this cycle), 2 remaining (SourceSpan.file participation + patch_lower_helpers residual). #4 — T-Free-Consequences-Demonstration over-attribution (line 430): Cell credited gates #10/#33/#37/#40/#72 to T-Free, but §1.8 assigns those to other lanes: - #10 → T-V-L4-L7-Direct - #33 → T-Bridge-Retirement - #37 + #40 → T-CostLens-Composition - #72 → T-E-P-Producer-Broadening T-Free's canonical demo gate range is #43-#52. Only #43 (auto_parallelism_independent_binds_emit_parallel) MERGED this cycle for T-Free. Updated cell + compile-note to credit each landing only to its canonical-lane row. Compile-note also reconciled per the same §1.8 single-authority pass: T-CostLens-Composition + T-E-P-Producer-Broadening now credited their own gates instead of attributing them to T-Free. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): address codex BLOCKING #5/#6 — PR-merge evidence ≠ gate-PASSING Two valid findings from codex schedule review on sha f6a3a13 (review id 4259176210): #5 — T-Bridge-Retirement count conflated PR-merge with gate-PASSING: Cell said "3/5 retired" but §1.8 truth: #32 PASSING, #33 DECLARED, #34 DECLARED, #35 PASSING. PR #2449 + PR #2459 ARE merged but the gates haven't been promoted from DECLARED → PASSING (separate status drift sweep step, e.g., per PR #2399 cadence). Reframed cell to distinguish PR-merge evidence from canonical §1.8 status: 2/5 gate-PASSING (#32 + #35), 2/5 PR-merged-pending-promotion (#33 + #34), plus SourceSpan.file participation (Substrate-owned hand-Rust audit sites; not in numbered §1.8) + residual semantic patching (`bridge_exact_string_semantic_patching_residual` Open per #35 close-criterion). #6 — T-Free-Consequences over-claim on PR-merge: Cell said "gate #43 MERGED" but §1.8 #43 still DECLARED (PR #2495 is evidence toward promotion, not the promotion event). Same fix: reframe as PR-merge evidence accruing toward §1.8 gate promotion; canonical status authoritative. Compile-note also reframed: explicitly distinguishes PR-merge evidence from §1.8 gate-PASSING promotion. PR-merge events are listed as evidence accruing toward promotion; canonical gate status varies per §1.8. Common root: future Monday compiles must mechanically reconcile each "landed/retired" claim against §1.8 status, NOT PR-merge events. Discipline recorded in feedback_pm_compile_audits_pre_existing_errors (updated to include PR-merge-vs-gate-promotion distinction). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 participant
Summary
ApproximateField<F>float shape in Grounding G2 for Rustf32/f64primitive rowsrust_pilot_primitiveslist against the pilot mirror across all rows, including floatsOut of scope
v3-grounding-coercion-foldLiteralBits::Intcompile mismatch is separate G7 Coercion-Fold scratch-retirement scope and is not fixed here.Validation
cargo test -p v3-grounding-pilotcargo test -p v3-grounding-enginecargo test -p v3-compiler extdeps_rust_primitives_loader_test --test integration