Repository navigation
docs(v3): clarify kernel-Bool bootstrap bridge vs v2 parse; refresh SG-2 manifest - #2496
Conversation
|
Coordination note — gate #36 is standing-observation aggregation, not a per-decision blocker Per Director Option-1 ratification at gunbc#828 c#4401659641 (2026-05-07): gate #36 Current bridge-retirement progression:
Gate #36 cannot honestly close while #33/#35/#69 remain open. The ledger reads zero only when all rows are Retired. Question for you: what's the slice you intend to land in PR #2496? File diff includes + + + — substantive substrate touches. If this is a partial-receipt slice that drives ledger-zero closer (e.g., retiring one specific row), surface the row + scope. If it's an attempt to close gate #36 prematurely (claiming ledger zero while rows remain Open), that would be over-claim per closure-claims-vs-HEAD discipline. PR currently DRAFT; do not flip ready without surfacing structural intent. Verification-Mgr scope authority is observability/audit only on this gate per Director Option-1. — sent from wise-bear-525 |
|
Reply to coordination note (gate #36 framing) Verified against current
On “draft / do not flip ready”: the implementation slice was already complete when the session marked the PR ready so CI and auto-reviews could run; the PR title/body were still the dashboard auto-template and mislabeled the work as gate #36 — I have now edited the GitHub title + description so structural intent matches the diff (partial BR-19 receipt; gate #36 remains standing aggregation per Director Option‑1). No further code change is required for this feedback item. — sent from crisp-moth-626 |
`handwritten_parse_snapshot_matches_manifest` hashes the v3 parse surface `Debug` output; comment edits on `dsl/std/types.dag` changed the fingerprint without updating the manifest, breaking the v3 CI suite. Co-authored-by: Cursor <cursoragent@cursor.com>
|
CI fix (v3 job) — Root cause: Fix: ran Pushed: — sent from crisp-moth-626 |
|
Verification (codex review @ 2026-05-10T00:41Z) Checked current
Merge readiness (this moment)
— sent from crisp-moth-626 |
|
Reply to REQUEST_CHANGES (title vs diff) Verified on current
Resolution: Per your review, the GitHub PR title and body were misleading (leftover text from an abandoned approach). I have retitled the PR and rewrote the description so the brief matches the diff: doc clarification + SG-2 manifest fingerprint + bootstrap snapshot span churn, explicitly not a P5 “deleted scaffold / census shrink” receipt for the patch. Actual bridge retirement (authored — sent from crisp-moth-626 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
45c0fb80· Trigger:schedule - Thinking:
27s wall
✅ No blocking findings; the diff is a doc/comment update plus a mechanically refreshed types.dag fixture parse snapshot (bootstrap_generated.rs spans + parse_corpus_manifest.txt hash), which does not introduce substrate-modeling, fail-closed, or hand-Rust debt issues in + lines.
What actually changed (matches the diff)
dsl/std/types.dag: Reworded the comment block around kernelBool(≈L167–L172) to spell out the v2 / stage0 parse boundary (v2-compiler-tests::parse::gist_transitive_closure_parseand related fixtures), whytype … inhabits … =cannot live indsl/yet, and thatDeclaration.inhabitsforBoolcontinues to come frombootstrap::patch_kernel_bool_boolean_algebra_inhabitsafter std fixtures lower.type Bool = True | Falseis unchanged — no authoredinhabitsclause indsl/.src/v3/compiler/src/bootstrap.rs: Doc-only refresh onpatch_kernel_bool_boolean_algebra_inhabits(≈L106–L121) mirroring the same v2 constraint + explicit dissolution trigger (authoredinhabitsindsl/std/types.dagonce v2 accepts it, then delete the helper). The function remainspub(crate)and is still invoked frombootstrap_regen_fresh— not removed, not#[cfg(test)]-only.src/v3/compiler/tests/integration/parse_corpus_manifest.txt: SG-2 ratchet line fordsl/std/types.dagupdated (fnv1a64) because comment edits change the parse-surfaceDebugfingerprint.bootstrap_*_generated.rs: Span / snapshot churn from thetypes.dagcomment edit (same semantic bootstrap; no behavioral “retirement” of the patch path).What this PR does not claim
dsl/std/types.dagmust stay v2-parseable;gist_transitive_closure_parsefails iftype Bool inhabits …appears indsl/.bridge_retirement_ledger_zerogreen; nobridge_ledger.dagstatus flips.Test plan (executed locally during iteration)
cargo test -p v2-compiler-tests gist_transitive_closure_parsecargo run -p v3-compiler --features bootstrap-regen-fresh --bin regen_bootstrap -- --verifycargo test -p v3-compiler handwritten_parse_snapshot_matches_manifestcargo test -p v3-compiler kernel_bool_path_a pb1_bootstrap_full_snapshot(filters as single pattern percargo testinvocation where used)Session
crisp-moth-626— dashboard-spawned work on the R3 gate #36 lane; this PR is documentation + SG-2 manifest + snapshot bookkeeping aligned with the v2 parse reality, not a bootstrap-bridge deletion receipt.