[codex] Add lens producer retirement witness by briansrls · Pull Request #2595 · gunb-ai/gunbc

briansrls · 2026-05-10T15:23:33Z

SG-0 hand-path delta: +1
SG-0 pairing: (c) follow-up dispatch remains tracked by docs/briefs/r3-pb-t-lensproducer-sub1-lens-apply-retirement.md and docs/briefs/r3-pb-t-lensproducer-sub2-lens-testgen-retirement.md for Item 4 retirement preconditions.

Summary

add a focused R3 gate Tighten SDLC design gaps for dry-run deployment readiness #66 integration receipt for lens_producer_retirement_executable_witness
execute the existing .dag PB census claim through TestRunner and assert it reports the live lens-producer residual count instead of NotYetImplemented
register the test in the consolidated integration binary and SG-0 hand-authored test census

Validation

cargo fmt
cargo test -p v3-compiler --test integration r3_gate_66_lens_producer_retirement_claim_executes_against_live_census

Work item: dashboard://work-items/r3-gate-66-39ea103d

briansrls · 2026-05-10T15:32:46Z

Review metadata

Provider / model: openai-pro / gpt-5-5-pro
Commit: 387e782d · Trigger: manual
Comparison: main @ dbccd6d5 ... session/snappy-cat-716 @ 387e782d
Conversation: View conversation

1. Story of the diff

This PR adds an executable R3 gate witness for lens-producer retirement. Instead of treating the PB census claim as a prose receipt, the new integration test compiles the existing r1_pb_census_gates.dag fixture, runs r1_pb_census_gates_suite through TestRunner, finds the lens_producer_files_remaining claim, and verifies it is no longer NotYetImplemented while still reporting the live residual count when the retirement preconditions are open (src/v3/compiler/tests/integration/r3_lens_producer_retirement_executable_witness_test.rs:15-19, :23-39, :45-56). The test is wired into the integration harness (src/v3/compiler/tests/integration.rs:182-183) and registered in the SG-0 hand-authored test census as a bounded residual bridge (src/v3/compiler/tests/integration/sg0_census_test.rs:568-572).

2. Invariant categories

LAYER MODEL — N/A. The diff is Rust test harness only: it does not introduce or mutate substrate types, Dag storage, cross-pass carriers, or dag.rs; it reads an already-compiled DAG through TestRunner (src/v3/compiler/tests/integration/r3_lens_producer_retirement_executable_witness_test.rs:39).
INVARIANTS.md + modeling-discipline.md — Compliant. Boundary discipline / single authority is preserved: the Rust test does not create a second residual-set walker; it executes the existing .dag census claim by suite and claim name (src/v3/compiler/tests/integration/r3_lens_producer_retirement_executable_witness_test.rs:17-18, :39-42). Fail-closed is also handled for the witness boundary: a missing claim panics instead of silently succeeding, and NotYetImplemented is rejected (src/v3/compiler/tests/integration/r3_lens_producer_retirement_executable_witness_test.rs:43, :55-56).
CODING.md — Compliant. The test keeps dependencies explicit as constants for fixture source, fixture path, suite name, claim name, and current expected residual count (src/v3/compiler/tests/integration/r3_lens_producer_retirement_executable_witness_test.rs:15-19), and handles CompileError::Semantic distinctly rather than collapsing all compile failures into an ambiguous unwrap (:23-37).
TESTING.md — Compliant. This is appropriately integration-level because the behavior under test is “a .dag TestClaim executes through TestRunner,” not a narrow lens helper. The test makes one focused claim, compiles the minimal named fixture, runs one suite, selects one claim, and rejects NYI (src/v3/compiler/tests/integration/r3_lens_producer_retirement_executable_witness_test.rs:22-23, :39-42, :55-56).
LOCKED DESIGN DECISIONS — N/A. The diff does not alter a locked design document or change the meaning of a locked plan; it adds a receipt test and census accounting only.
TRACKED vs UNTRACKED DEBT — Compliant. The new hand-authored Rust test is tracked rather than hidden: the file documents its purpose and dissolution condition — “the gate turns green when the three named producer surfaces retire” (src/v3/compiler/tests/integration/r3_lens_producer_retirement_executable_witness_test.rs:5-9) — and the SG-0 census bounds the scaffold to a single explicit path while naming the open Row-4 / Item 4 preconditions (src/v3/compiler/tests/integration/sg0_census_test.rs:568-572).

2.5. Top-down PM intent review

Compliant. The PM-level intent is not diluted: the change makes a paper retirement receipt executable by running the .dag PB census claim through TestRunner (src/v3/compiler/tests/integration/r3_lens_producer_retirement_executable_witness_test.rs:5-9, :39) while also keeping the added hand-Rust surface visible in the SG-0 census (src/v3/compiler/tests/integration/sg0_census_test.rs:568-572). It does not introduce a permanent parallel authority for lens-producer state; it delegates the state check to the existing .dag claim and only verifies that the claim is executable and non-NYI.

3. Verdict

APPROVE. The PR is a narrowly scoped test receipt, and the added hand-authored test is registered as tracked residual debt. I do not see a diff-cited substrate, modeling, or PM-intent violation.

Promotes 4 §1.8 rows with PR-evidence on main. PB Mgr post-merge ledger-receipt sync per Director ratification at gunbc#828 (c#4415884211; same pattern as PR #2399). Promotions: - #6 lens_testgen_dot_rs_retired DECLARED -> CONSUMER_LANDED + PASSING (PR #2392 producer + PR #2594 regression-guard; lens_testgen.rs absent on disk; consumer-side ratchet test landed) - #33 bridge_canonical_lens_name_dispatch_retired DECLARED -> CONSUMER_LANDED (PR #2449) - #34 bridge_include_str_side_channels_retired DECLARED -> CONSUMER_LANDED (slice scope) (PR #2459 pipeline.dag slice; standalone closure brief #1976 STOP-BLOCKED on Substrate T1) - #66 lens_producer_retirement_executable_witness Notes-update only (PR #2595 substrate-impl landed: TestRunner executes .dag PB census claim and reports residual; closure-receipt remains F3-DEFERRED per PB Mgr disposition) Excluded (out of charter): - #31 -> Substrate (#2068) - #36 -> Verification (#2075) Excluded (T-V2-Retirement HELD on PM-authored S-1 brief #1974): - #41 / #42 / #60 / #71 Pre-authored brief at docs/briefs/r3-pb-status-drift-sweep-post-tlp.md covers the post-T-LP cascade wave (G5/G7/G8). Closes PB Mgr drift-sweep obligation for already-merged evidence; G5/G7/G8 remain queued per pre-authored brief. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…2631) * docs(audit): land R-3 + R-7 ratifications (T-Tier3 perf budget) §5.1 designation in canonical-bench-host-decision-matrix: Option A ubicloud-standard-2 ratified 2026-05-08 per PB Manager (warm-dove-618); Director ratification at gunbc#828 c#4403509523. §2 capture procedure: multi-run discipline addendum — N=5 preferred, median-of-medians for median_ns, max-p99-across-runs for p99_ns, per-run intermediates committed alongside final tier3_baseline.json. Both lines unblock #2204 slice dispatch (Substrate-side PerfWithinBaseline variant + PerfBaselineMeasurement carrier); PB consumer slice queues post-#2204 land. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * PB Item 5 brief — encode substrate disposition (#2068 P1 RATIFIED) Substrate Mgr (warm-wolf-698) ratified §7.3 disposition at gunbc#2068 c#4411574142: shape (b) CensusSubsetCount filter with closed predicate BinShimFilesSubsetPredicate, mirroring existing LensProducerFilesSubsetPredicate precedent. Per feedback_strict_mirror_vs_novel_substrate_fact, strict-mirror ratifies directly (no canvas needed). Updates r3-pb-binshim-retirement-worker.md: - New §"Substrate landings (locked shape)" with the 4 required artifacts (substrate marker type + value, runtime predicate body, dispatch branch). - §7.3 acceptance now authorable; locked TestClaim shape recorded. - Dispatch precondition (5): unauthorable → RESOLVED. - STOP condition: §7.3 disposition not-yet-live → drift-detection. - Status header: PROPOSAL → READY-FOR-DISPATCH posture (pending only the standard R2/R2-Evaluator close signal; both Item-4 sub-gates met via PR #2282 / #2227 close). Bin-shim file inventory at main 5a13ed8: 9 files in src/v3/compiler/src/bin/; closure when CensusSubsetCount predicate count == 0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * WIP: R3 PB Mgr — lane through R3 close * brief: clarify §7.3 TestClaim is zero-only (not schedule-bound) Addresses non-blocking improvement on PR #2334 (codex review sha=68977425): the prior wording called CensusSubsetCount a schedule-bound gate, but the runtime predicate (test_runner.rs:3290-3296) is zero-only — Pass iff count==0. Interim per-PR shrink receipts are PR-level milestones outside this TestClaim, not TestClaim verdicts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * brief: reconcile §"Substrate landings" with Non-goals (PB strict-mirror authoring authorized post-#2068) Addresses non-blocking improvement on PR #2334 (codex review sha=363cf799): the new §"Substrate landings (locked shape)" worker-owned list contradicted the unchanged "out of scope" entries that still said PB lane does not author §7.3 substrate shape. Resolution: per #2068 c#4411574142 ratification + feedback_strict_mirror_vs_ novel_substrate_fact, strict-mirror declarations (mirroring the existing LensProducerFilesSubsetPredicate precedent) are PB-lane-authorable. The non-goal still applies to *novel* shape (extra fields, alternative coproducts) which would re-escalate to Substrate Mgr. Updates: - "PB does not own and must not edit" entry (line 29): clarifies shape question is Substrate-territory but strict-mirror authoring is authorized. - Non-goals (line 155): same reconciliation; novel shape still gates back to Substrate Mgr. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * PB Item 5 follow-on brief — batch retirement for 8 remaining bin-shims Director re-task at gunbc#828 c#4413892216 Task A: author per-shim retirement worker briefs for the 9 bin-shims; 1 covered by gate #7 (warm-crab-600 working regen_lens.rs); 8 unscoped (emit_method_template_projection, r1c_e_emit_gates, regen_bootstrap, regen_parse, regen_parse_tables, regen_tokenize, regen_v3, self_host_fixed_point). This brief governs the 8-shim batch follow-on against the canonical r3-pb-binshim-retirement-worker.md template. Status PROPOSAL — dispatch-gated on: - smart-tern-649 Stage A landing (BinShimFilesSubsetPredicate carriers + runtime predicate) - warm-crab-600 gate #7 first-cut precedent on main Three staging shapes documented (mega-PR / serial-per-shim / batched-2-3); PB Mgr leans batched-by-regen-family. Worker chooses at dispatch. STOP-AND-PING conditions enumerated (substrate-carrier absent / carrier shape pressure / emit-pattern divergence / substrate-grep mismatch). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix-forward (PR #2471 codex REQUEST_CHANGES) Two findings addressed: 1. Carrier-shape mismatch (line 43): brief template said `name:` but the locked BinShim carrier per design-pb-runtime-interpreter.md:200-204 uses `entrypoint_name`, `description`, `entry`. P2 single-authority violation would have routed workers against wrong shape. Fixed: template now matches locked shape verbatim with explicit no-additional-fields clause. 2. Dispatch-gate dilution (lines 33, 98): brief reduced operative dispatch gate to "Stage A landing + gate #7 precedent" but parent brief enumerates 5 preconditions (R2 close + R2-Evaluator landed + Item 4 sub-gate green + BinShim carrier live + §7.3 disposition). P5 fail-closed violation. Fixed: full readiness prerequisite inherited verbatim from parent brief; gate #7 precedent demoted to implementation-pattern reference (not gate). Worker dispatch posture updated to require all 5 preconditions verified on main at dispatch time per feedback_substrate_grep_before_authoring. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * WIP: R3 PB Mgr — lane through R3 close * docs(r3): §1.8 ledger Status drift sweep — post-T-LP / T-Bridge wave Promotes 4 §1.8 rows with PR-evidence on main. PB Mgr post-merge ledger-receipt sync per Director ratification at gunbc#828 (c#4415884211; same pattern as PR #2399). Promotions: - #6 lens_testgen_dot_rs_retired DECLARED -> CONSUMER_LANDED + PASSING (PR #2392 producer + PR #2594 regression-guard; lens_testgen.rs absent on disk; consumer-side ratchet test landed) - #33 bridge_canonical_lens_name_dispatch_retired DECLARED -> CONSUMER_LANDED (PR #2449) - #34 bridge_include_str_side_channels_retired DECLARED -> CONSUMER_LANDED (slice scope) (PR #2459 pipeline.dag slice; standalone closure brief #1976 STOP-BLOCKED on Substrate T1) - #66 lens_producer_retirement_executable_witness Notes-update only (PR #2595 substrate-impl landed: TestRunner executes .dag PB census claim and reports residual; closure-receipt remains F3-DEFERRED per PB Mgr disposition) Excluded (out of charter): - #31 -> Substrate (#2068) - #36 -> Verification (#2075) Excluded (T-V2-Retirement HELD on PM-authored S-1 brief #1974): - #41 / #42 / #60 / #71 Pre-authored brief at docs/briefs/r3-pb-status-drift-sweep-post-tlp.md covers the post-T-LP cascade wave (G5/G7/G8). Closes PB Mgr drift-sweep obligation for already-merged evidence; G5/G7/G8 remain queued per pre-authored brief. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(briefs): fix gate #64 → #66 mislabel in drift-sweep brief Per cursor/composer-2 review on PR #2631: brief table + dispatch-trigger parenthetical labeled lens_producer_retirement_executable_witness as gate #64. Authoritative §1.8 row is #66; #64 is substrate_gap_reflection_closure_closed (separate predicate). Aligns brief with r3-program-plan.md §1.8 row identity per INVARIANTS.md P1 (single authoritative facts). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): row #66 DECLARED → CONSUMER_LANDED per §1.7 taxonomy Per codex/codex-default review on PR #2631 (REQUEST_CHANGES, review 9150): leaving row #66 at DECLARED while the Notes cell describes an executable consumer that runs through TestRunner contradicts the §1.7 status taxonomy and INVARIANTS P2 single-authority discipline. Promoting #66 to CONSUMER_LANDED with explicit PASSING gate on residual = 0 (cascades from T-LensProducer-Retirement gates #5 + #6 + #7). The F3 deferral is on PASSING, not CONSUMER_LANDED; the executable receipt src/v3/compiler/tests/integration/r3_lens_producer_retirement_executable_witness_test.rs already exists and runs the .dag PB census claim through TestRunner. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…2657) acceptance per r3-structure.md:184 Reverts row #66 lens_producer_retirement_executable_witness in docs/r3-program-plan.md from CONSUMER_LANDED back to DECLARED with explicit canonical-acceptance framing. Per briansrls + codex/codex-default BLOCKING reviews on merged PR #2631 (post-merge inline + main review at 2026-05-10T20:15Z): the lens_producer_files_remaining census check shipped via PR #2595 is the r3-structure.md:184 "near-term demo = retirement state-check + doc receipts" placeholder, NOT the canonical demonstration consumer. The canonical Pass-condition is "lens_apply reflection routes via PB-Runtime on representative lens program" with execution-ready witness DEFERRED to Row-4 equivalence receipt + Item 4 landing per docs/design-pb-runtime-interpreter.md §5.1. Promoting row #66 to CONSUMER_LANDED on the basis of substrate plumbing dilutes the demonstration gate against INVARIANTS.md P2 single-authority discipline. Status re-promotes only when Row-4 + Item 4 receipts land. Also removes #66 from the post-T-LP drift-sweep brief's promotion set with explicit exclusion-by-canonical-acceptance-scope rationale. Other promotions in PR #2631 (#6 PASSING, #33 / #34 CONSUMER_LANDED) stand — those rows have canonical-fit consumers landed. Refs: PR #2631 #issuecomment thread (briansrls inline reviews + codex review at sha 18d279c); r3-structure.md:184; design-pb-runtime -interpreter.md §5.1. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…te-landing tests) (#2665) * docs(audit): SG-0 trajectory snapshot 2026-05-11 (+4 vs prior EOD) PM standing daily-cadence duty per docs/audit/r3-sg0-trajectory-tracker.md §5. Today (31acf43): non_test=53 test=112 fragments=2 total=167. Delta vs 2026-05-10 EOD baseline (163): +4 test entries. The 4 new entries are gate-landing tests, identified via per-entry diff: - lens_behavioral_parity_demonstration_test.rs (gate #73, snappy-raven-508 PR #2525) - r3_gate_87_lens_cementing_regen_receipts_test.rs (gate #87 PR #2639) - r3_lens_producer_retirement_executable_witness_test.rs (PR #2595) - t_ci_workflow_as_data_demo_test.rs (T-Workflow-As-Data demo) Many gates landed during the 2026-05-10 → 2026-05-11 cycle (T-Tests-As-Data #84/#85/#86/#87; T-Bridge-Retirement #31; T-LensProducer #5+#6; T-V-L4 #11/#13; T-V-L7 #10/#15; #74 + #27 + #26 and many others). Cluster M Phase 3 bulk-port has NOT yet kicked in to shrink the census — calm-newt-602 (gate #84) + silent-swift-300 (cementing+behavioral-parity census slice) are active workers; their migration work is what flips trajectory from accumulating to shrinking. 11-day cumulative is +47 entries; per-day avg +4.3. Velocity tripwire status remains pending/uncomputed until Phase 3 migration begins producing dissolution events. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(audit): address codex BLOCKING on PR #2665 — PR-merge vs §1.8 gate-PASSING Same root cause as PR #2583 codex BLOCKING #5/#6 (memorized as feedback_pm_compile_audits_pre_existing_errors): PR-merge events ≠ §1.8 gate-PASSING promotion. Cell text said "T-Tests-As-Data gates #84/#85/#86/#87 landed". Verified against §1.8 ledger at HEAD: - #84 `every_rust_test_ports_to_dag_or_generated`: DECLARED — cannot promote until EXPECTED_HAND_AUTHORED_TEST = 0 (Phase 3 bulk-port close criterion) - #85 `forall_exists_quantifier_substrate_landed`: DECLARED — carriers landed via PR #2647 but CONSUMER_LANDED not yet claimed; §P2 requires generated consumer of declared surface - #86 `program_generator_carrier_landed`: CONSUMER_LANDED + PASSING ✓ - #87 `lens_cementing_test_discipline_complete`: CONSUMER_LANDED (PR #2639), NOT PASSING — 8 regen harnesses still Compiles-only placeholders per §1.8 close-criterion Only #86 is fully PASSING. Cell reframed to distinguish PR-merge evidence from canonical §1.8 status per memorized discipline; row notes the status drift sweep step that promotes evidence to PASSING. Same reframe applied to T-Bridge-Retirement #31, T-LensProducer #5/#6, T-V-L7 #10 — PR-merges with §1.8 status drift sweep pending. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Add lens producer retirement witness

387e782

briansrls mentioned this pull request May 10, 2026

session/warm-dove-618 · R3 PB Mgr — lane through R3 close #2074

Closed

briansrls marked this pull request as ready for review May 10, 2026 15:24

briansrls added 2 commits May 10, 2026 15:35

Add SG-0 receipt for PR 2595

8ca415d

Merge remote-tracking branch 'origin/main' into session/snappy-cat-716

83ec067

briansrls mentioned this pull request May 10, 2026

R3 PB Mgr — lane through R3 close #1942

Closed

briansrls merged commit a085f6e into main May 10, 2026
4 checks passed

briansrls deleted the session/snappy-cat-716 branch May 10, 2026 15:52

briansrls mentioned this pull request May 10, 2026

session/zesty-bear-812 · gunbc Director #828

Closed

briansrls mentioned this pull request May 10, 2026

docs(r3): §1.8 ledger Status drift sweep — post-T-LP / T-Bridge wave #2631

Merged

briansrls mentioned this pull request May 10, 2026

docs(r3): revert row #66 over-promotion — preserve canonical PB-Runtime acceptance #2657

Merged

briansrls mentioned this pull request May 11, 2026

docs(audit): SG-0 trajectory snapshot 2026-05-11 (+4 vs prior EOD; gate-landing tests) #2665

Merged

5 tasks done

briansrls mentioned this pull request May 12, 2026

session/deep-wolf-155 · deep-wolf-155 #846

Closed

Navigation Menu

Repository navigation

[codex] Add lens producer retirement witness - #2595

[codex] Add lens producer retirement witness#2595
briansrls merged 3 commits into
mainfrom
session/snappy-cat-716

briansrls commented May 10, 2026 •

edited

Loading

Uh oh!

briansrls commented May 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

briansrls commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

briansrls commented May 10, 2026

1. Story of the diff

2. Invariant categories

2.5. Top-down PM intent review

3. Verdict

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

briansrls commented May 10, 2026 •

edited

Loading