internal/xds: change xds_resolver to use dependency manager#8711
Merged
eshitachandwani merged 14 commits intogrpc:masterfrom Dec 3, 2025
Merged
internal/xds: change xds_resolver to use dependency manager#8711eshitachandwani merged 14 commits intogrpc:masterfrom
eshitachandwani merged 14 commits intogrpc:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8711 +/- ##
==========================================
- Coverage 83.31% 83.20% -0.11%
==========================================
Files 419 418 -1
Lines 32429 32356 -73
==========================================
- Hits 27017 26922 -95
- Misses 4038 4049 +11
- Partials 1374 1385 +11
🚀 New features to boost your workflow:
|
arjan-bal
reviewed
Nov 17, 2025
Contributor
|
Is the PR description out of date? I don't see any changes about switching the dependency manager to use the serializer again. |
easwars
reviewed
Nov 17, 2025
Member
Author
Yeah sorry , I was making that change earlier but Arjan suggested a different way, so that got changed. |
arjan-bal
reviewed
Nov 27, 2025
| @@ -411,9 +411,6 @@ func (s) TestResolverBadServiceUpdate_NACKedWithCache(t *testing.T) { | |||
| // Expect an error update from the resolver. Since the resource is cached, | |||
Contributor
There was a problem hiding this comment.
This comment probably needs to be updated since the resolver doesn't report an error for ambient listener and route errors anymore.
arjan-bal
reviewed
Dec 1, 2025
This was referenced Apr 23, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is part of A74 implementation.
This PR removes the listener and route watchers from resolver and changes it so that we get the resources from xds dependency manager.
RELEASE NOTES: