client: Roll-forward PR #8278(with changes): Restore the existing behavior to return io.EOF on repeated RecvMsg() calls for client-streaming RPCs#8523
Merged
Pranjali-2501 merged 7 commits intogrpc:masterfrom Aug 25, 2025
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8523 +/- ##
==========================================
+ Coverage 81.82% 82.06% +0.24%
==========================================
Files 413 412 -1
Lines 40518 40462 -56
==========================================
+ Hits 33153 33205 +52
+ Misses 5989 5888 -101
+ Partials 1376 1369 -7
🚀 New features to boost your workflow:
|
Contributor
|
Can you please keep the revert commit as part of the PR? This will make it easier to review only the new changes. Also, could you please update the PR title to accurately reflect what is being changed? Since this is an impure rollforward, the current title is a bit misleading. You can mention that it's rolling forward the reverted changes in the PR description. Finally, please add release notes for these changes. Thanks! |
Pranjali-2501
changed the title
dfawley
changed the title
dfawley
approved these changes
Aug 25, 2025
Member
dfawley
left a comment
dfawley
left a comment
There was a problem hiding this comment.
Minor grammar nit otherwise LGTM
test/end2end_test.go
Outdated
|
|
||
| // Tests that a client receives a cardinality violation error for client-streaming | ||
| // RPCs if the server call SendMsg multiple times. | ||
| // RPCs if the server call SendMsg() multiple times. |
Member
There was a problem hiding this comment.
Suggested change
| // RPCs if the server call SendMsg() multiple times. | |
| // RPCs if the server calls SendMsg() multiple times. |
arjan-bal
approved these changes
Aug 25, 2025
Contributor
arjan-bal
left a comment
arjan-bal
left a comment
There was a problem hiding this comment.
LGTM with a minor comment.
stream.go
Outdated
|
|
||
| sentLast bool // sent an end stream | ||
|
|
||
| recvFirstMsg bool // set after the first message is received |
Contributor
There was a problem hiding this comment.
nit: Please expand recv to received. The abbreviation is a bit ambiguous and could be interpreted as either receive or received.
eshitachandwani
pushed a commit
to eshitachandwani/grpc-go
that referenced
this pull request
Aug 29, 2025
… behavior to return io.EOF on repeated RecvMsg() calls for client-streaming RPCs (grpc#8523) Partially addresses: grpc#7286 This reverts commit grpc@20bd1e7 Changes: - Modifies client.RecvMsg() so that successive calls after stream ends return io.EOF. - Adds extra state to track calls to client.recvmsg(required to return Cardinality Violation only in case zero response) RELEASE NOTES: * client: Return status code INTERNAL when a server sends 0 response messages for a unary or client streaming RPC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses: #7286
This reverts commit 20bd1e7
Changes:
RELEASE NOTES: