grpc: initialize decompressor for health check streams#8765
Merged
eshitachandwani merged 1 commit intogrpc:masterfrom Jan 8, 2026
Merged
grpc: initialize decompressor for health check streams#8765eshitachandwani merged 1 commit intogrpc:masterfrom
eshitachandwani merged 1 commit intogrpc:masterfrom
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8765 +/- ##
==========================================
- Coverage 83.51% 83.33% -0.19%
==========================================
Files 418 418
Lines 32485 32486 +1
==========================================
- Hits 27130 27072 -58
- Misses 3992 4027 +35
- Partials 1363 1387 +24
🚀 New features to boost your workflow:
|
eshitachandwani
approved these changes
Dec 31, 2025
mbissa
approved these changes
Jan 8, 2026
eshitachandwani
changed the title
mbissa
pushed a commit
to mbissa/grpc-go
that referenced
this pull request
Feb 16, 2026
stream: initialize decompressor for health check streams Fixes grpc#8162 Health checks fail when using legacy compression options (WithDecompressor on client or RPCDecompressor on server). The health check stream created via newNonRetryClientStream does not initialize the decompressorV0 field with the legacy decompressor from dial options, causing an Internal error when attempting to decompress server responses. This fix initializes the decompressorV0 field in addrConnStream with ac.cc.dopts.dc, matching the behavior of the regular clientStream path (line 492) to ensure health check streams can properly decompress responses when legacy compression options are configured. RELEASE NOTES: * health: Fixed health checks failing when using legacy compression options WithDecompressor or RPCDecompressor.
This was referenced Apr 23, 2026
Closed
Closed
fix(deps): vuln minor upgrades — 11 packages (minor: 7 · patch: 4) [server]
DataDog/temporalio-ui#27
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream: initialize decompressor for health check streams
Fixes #8162
Health checks fail when using legacy compression options (WithDecompressor on client or RPCDecompressor on server). The health check stream created via newNonRetryClientStream does not initialize the decompressorV0 field with the legacy decompressor from dial options, causing an Internal error when attempting to decompress server responses.
This fix initializes the decompressorV0 field in addrConnStream with ac.cc.dopts.dc, matching the behavior of the regular clientStream path (line 492) to ensure health check streams can properly decompress responses when legacy compression options are configured.
RELEASE NOTES: