stats/otel: a79 scaffolding to register an async gauge metric and api to record it- part 3#8780
Merged
mbissa merged 8 commits intogrpc:masterfrom Jan 5, 2026
Conversation
mbissa
added
Type: Feature
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8780 +/- ##
==========================================
- Coverage 83.47% 83.24% -0.23%
==========================================
Files 419 418 -1
Lines 32595 33004 +409
==========================================
+ Hits 27208 27475 +267
- Misses 4017 4114 +97
- Partials 1370 1415 +45
🚀 New features to boost your workflow:
|
mbissa
force-pushed
the
a79-async-gauge-metrics-with-leak-check
branch
from
942656f to
6d78be5
Compare
arjan-bal
reviewed
Dec 24, 2025
mbissa
force-pushed
the
a79-async-gauge-metrics-with-leak-check
branch
from
26bc587 to
e1c3b2e
Compare
arjan-bal
reviewed
Jan 2, 2026
arjan-bal
approved these changes
Jan 5, 2026
| } | ||
|
|
||
| func TestLeakChecker_DetectsLeak(t *testing.T) { | ||
| // 1. Setup the tracker (swaps the delegate in internal). |
Contributor
There was a problem hiding this comment.
nit: Please avoid putting numbers in the comments. The step numbers may go out of sync with the code when it's changed.
Contributor
Author
There was a problem hiding this comment.
Will be doing this in follow up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is the third part of the scaffolding required to support asynchronous metrics (e.g., OpenTelemetry Observable Gauges). It updates the MetricsRecorder interface to support registering asynchronous metric reporters and wires up the corresponding logic in the OpenTelemetry implementation.
RELEASE NOTES:
experimental/stats: Updated the MetricsRecorder interface with mustEmbedUnimplementedMetricsRecorder that is provided by a new Noop struct UnimplementedMetricsRecorder which needs to be embedded going forward in all implementations of MetricsRecorder.
stats/otel: Enabled support for registering asynchronous metric reporters via the MetricsRecorder interface.