xds: remove references to ResolverState.Addresses#8841
Merged
arjan-bal merged 5 commits intogrpc:masterfrom Jan 21, 2026
Merged
xds: remove references to ResolverState.Addresses#8841arjan-bal merged 5 commits intogrpc:masterfrom
arjan-bal merged 5 commits intogrpc:masterfrom
Conversation
arjan-bal
added
Type: Internal Cleanup
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8841 +/- ##
==========================================
- Coverage 83.26% 82.90% -0.36%
==========================================
Files 414 414
Lines 32771 32773 +2
==========================================
- Hits 27288 27172 -116
- Misses 4051 4116 +65
- Partials 1432 1485 +53
🚀 New features to boost your workflow:
|
arjan-bal
force-pushed
the
xds-remove-resolver-state-addresses
branch
from
16e56f1 to
0351951
Compare
easwars
approved these changes
Jan 20, 2026
Contributor
There was a problem hiding this comment.
Doesn't have to be part of this PR, but looks like this test could be moved to hierarchy_test package since it only uses exported functions and doing so will ensure that in the future as well.
Contributor
|
@eshitachandwani : FYI for the changes in the dependency manager. |
arjan-bal
added a commit
that referenced
this pull request
Jan 21, 2026
As requested in #8841 (comment), this PR moves existing tests to a different package to enforce the use of public APIs. One test remains in the old package as it requires access to the private attribute key type. RELEASE NOTES: N/A
mbissa
pushed a commit
to mbissa/grpc-go
that referenced
this pull request
Feb 16, 2026
This change removes the usages of `ResolverState.Addresses` in xds code. Prior to Dualstack support, xDS LB policies relied exclusively on the `Addresses` field. As part of the Dualstack initiative, these policies were updated to support both `Endpoints` and `Addresses`. This PR removes the `Addresses` propagation logic in favor of relying solely on `Endpoints`. RELEASE NOTES: * balancer/weightedtarget: Remove handling of `Addresses` and only handle `Endpoints` in resolver updates.
mbissa
pushed a commit
to mbissa/grpc-go
that referenced
this pull request
Feb 16, 2026
As requested in grpc#8841 (comment), this PR moves existing tests to a different package to enforce the use of public APIs. One test remains in the old package as it requires access to the private attribute key type. RELEASE NOTES: N/A
This was referenced Apr 23, 2026
Closed
Closed
fix(deps): vuln minor upgrades — 11 packages (minor: 7 · patch: 4) [server]
DataDog/temporalio-ui#27
Closed
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the usages of
ResolverState.Addressesin xds code. Prior to Dualstack support, xDS LB policies relied exclusively on theAddressesfield. As part of the Dualstack initiative, these policies were updated to support bothEndpointsandAddresses. This PR removes theAddressespropagation logic in favor of relying solely onEndpoints.RELEASE NOTES:
Addressesand only handleEndpointsin resolver updates.