transport/client: Return status code Unknown on malformed grpc-status#8735
Merged
eshitachandwani merged 1 commit intogrpc:masterfrom Dec 3, 2025
Merged
transport/client: Return status code Unknown on malformed grpc-status#8735eshitachandwani merged 1 commit intogrpc:masterfrom
Unknown on malformed grpc-status#8735eshitachandwani merged 1 commit intogrpc:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8735 +/- ##
==========================================
+ Coverage 83.22% 83.37% +0.15%
==========================================
Files 419 419
Lines 32454 32454
==========================================
+ Hits 27009 27060 +51
+ Misses 4057 4028 -29
+ Partials 1388 1366 -22
🚀 New features to boost your workflow:
|
mbissa
approved these changes
Dec 2, 2025
easwars
approved these changes
Dec 2, 2025
This was referenced Apr 23, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #8713
Unknown is defined as follows in grpc/grpc@master/doc/statuscodes.md
It also mentions of returning Unknown for parsing errors in the table in the above doc.
We are currently returning Internal for status parsing errors as well, which is contrary to what is mentioned in the above spec. This PR changes it to return Unknown.
RELEASE NOTES:
Unknownon malformed grpc-status.