Adding session recording plugin for age#55120
Merged
Conversation
Joerger
approved these changes
May 23, 2025
avatus
approved these changes
May 23, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from rudream
eriktate
force-pushed
the
eriktate/encrypted-recording-manager
branch
2 times, most recently
from
88375d9 to
e944d7d
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
144d102 to
05d9bdd
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-manager
branch
from
e944d7d to
848b135
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
05d9bdd to
91b056c
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-manager
branch
2 times, most recently
from
549fcd0 to
37bcbfe
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
91b056c to
6cbe77d
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-manager
branch
from
37bcbfe to
06206eb
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
6cbe77d to
b3233d2
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-manager
branch
2 times, most recently
from
54c711f to
df2ca7c
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
b3233d2 to
7804aab
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-manager
branch
6 times, most recently
from
1c454f1 to
2aff1c8
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
7804aab to
fdfc71a
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-manager
branch
from
2aff1c8 to
cff5c92
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
fdfc71a to
40380b1
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-manager
branch
2 times, most recently
from
786b240 to
bc89945
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
2d8ce0a to
43e3753
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-manager
branch
from
2ba2ca1 to
bd87bb8
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
43e3753 to
d4f7490
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-manager
branch
from
bd87bb8 to
eb4376b
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
d4f7490 to
e2f11a4
Compare
…ops more complex than CRUD
eriktate
force-pushed
the
eriktate/encrypted-recording-manager
branch
from
821079b to
189e643
Compare
…tation with hooks to more efficiently lookup private keys given their respective public key
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
e2f11a4 to
92a6d14
Compare
eriktate
added
the
no-changelog
eriktate
added a commit
that referenced
this pull request
Jun 30, 2025
* adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key
eriktate
added a commit
that referenced
this pull request
Jul 1, 2025
* adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key
eriktate
added a commit
that referenced
this pull request
Jul 1, 2025
* adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key
eriktate
added a commit
that referenced
this pull request
Jul 1, 2025
* adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key
eriktate
added a commit
that referenced
this pull request
Aug 15, 2025
* adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key
eriktate
added a commit
that referenced
this pull request
Aug 27, 2025
* adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key
eriktate
added a commit
that referenced
this pull request
Sep 2, 2025
* adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key
eriktate
added a commit
that referenced
this pull request
Sep 2, 2025
* adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key
eriktate
added a commit
that referenced
this pull request
Sep 2, 2025
* adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key
eriktate
added a commit
that referenced
this pull request
Sep 3, 2025
* adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
* adding support for encryption/decryption keys to keystore manager (#54428, #55652) * adds new protos for resources related to encrypted session recordings and updates the existing SessionRecordingConfig protos to include a Status (#54780) * adding local service implementation for recording encryption resources (#54816) * adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD (#55078) * Adding session recording plugin for `age` (#55120) * adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key * Adding recording encryption and playback for `sync` modes (#54901) * adding cache for RecordingEncryption (#55857) * adding recording_encryption service protos (#55121) * adding async recording encryption with gRPC multipart uploader (#55859) * adding file configuration for encrypted session recording (#56200) * Switching recording encryption to unwrap keys using direct keystore RSA decryption (#56776) * adding manual key management config (#56920) * updating protos for recording encryption (#57055) * Add missing handling for recording encryption configs and keys (#57279) * updating protos for recording encryption * changing labels for encryption keys to prevent automatic cleanup, adjusting pkcs11 host UUID check to allow for key sharing of encryption keys, preventing cloud tenants from enabling manual key management, preventing use of recording encryption in FIPS mode * adding new protos for rotated keys and the local service for interacting (#57576) with them * Switching encryption keys from PEM to ASN.1 DER encoding (#58137) * using pregenerated RSA4096 key for keystore tests because generation is too slow (#58138) * extending precomputed RSA keys to support 4096-bit keys (#58251) * adding rotation process to Manager and exposing with new RPCs and (#57577) * adding rotation sub commands for recording encryption keys and fixing (#57780) broken session_recording_config when using fileconf * using more reliable method of validating key bit length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
ageplugin to better facilitate session recording encryption and decryption. It adds an additional stanza containing the public key used to wrap the file key which can be used at decryption time to more efficiently find the related private key. The actual internals for how filekeys are wrapped and unwrapped are unchanged from theagedefault forX25519keypairs.