Add missing handling for recording encryption configs and keys#57279
Merged
Add missing handling for recording encryption configs and keys#57279
Conversation
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
3c160d0 to
e99bcc2
Compare
eriktate
force-pushed
the
eriktate/add-tags-to-encryption-keys
branch
2 times, most recently
from
8101eed to
28c2293
Compare
eriktate
requested review from
camscale,
doggydogworld,
fheinecke,
hugoShaka,
klizhentas,
r0mant,
rosstimothy,
russjones,
strideynet,
tigrato and
zmb3
as code owners
|
@eriktate - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
e99bcc2 to
7b9deac
Compare
eriktate
removed request for
camscale,
doggydogworld,
fheinecke,
hugoShaka,
klizhentas,
r0mant,
russjones,
strideynet,
tigrato and
zmb3
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
71ad8e4 to
850c067
Compare
eriktate
force-pushed
the
eriktate/add-tags-to-encryption-keys
branch
from
adc5214 to
53cf180
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
850c067 to
b5a7837
Compare
eriktate
force-pushed
the
eriktate/add-tags-to-encryption-keys
branch
from
cf216c2 to
6954ed8
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
b5a7837 to
c82d3de
Compare
eriktate
force-pushed
the
eriktate/add-tags-to-encryption-keys
branch
from
6954ed8 to
9756e5d
Compare
eriktate
commented
Aug 12, 2025
eriktate
added
the
no-changelog
Contributor
Author
|
@nklaassen @gzdunek friendly bump! |
zmb3
approved these changes
Aug 12, 2025
tigrato
approved these changes
Aug 12, 2025
public-teleport-github-review-bot
Bot
removed request for
gzdunek and
nklaassen
…usting pkcs11 host UUID check to allow for key sharing of encryption keys, preventing cloud tenants from enabling manual key management, preventing use of recording encryption in FIPS mode
eriktate
force-pushed
the
eriktate/add-tags-to-encryption-keys
branch
from
82748f6 to
b9fbaad
Compare
Base automatically changed from
eriktate/refactor-encrypted-recording-protos
to
master
August 13, 2025 14:06
eriktate
added a commit
that referenced
this pull request
Aug 15, 2025
* updating protos for recording encryption * changing labels for encryption keys to prevent automatic cleanup, adjusting pkcs11 host UUID check to allow for key sharing of encryption keys, preventing cloud tenants from enabling manual key management, preventing use of recording encryption in FIPS mode
eriktate
added a commit
that referenced
this pull request
Aug 27, 2025
* updating protos for recording encryption * changing labels for encryption keys to prevent automatic cleanup, adjusting pkcs11 host UUID check to allow for key sharing of encryption keys, preventing cloud tenants from enabling manual key management, preventing use of recording encryption in FIPS mode
eriktate
added a commit
that referenced
this pull request
Sep 2, 2025
* updating protos for recording encryption * changing labels for encryption keys to prevent automatic cleanup, adjusting pkcs11 host UUID check to allow for key sharing of encryption keys, preventing cloud tenants from enabling manual key management, preventing use of recording encryption in FIPS mode
eriktate
added a commit
that referenced
this pull request
Sep 2, 2025
* updating protos for recording encryption * changing labels for encryption keys to prevent automatic cleanup, adjusting pkcs11 host UUID check to allow for key sharing of encryption keys, preventing cloud tenants from enabling manual key management, preventing use of recording encryption in FIPS mode
eriktate
added a commit
that referenced
this pull request
Sep 2, 2025
* updating protos for recording encryption * changing labels for encryption keys to prevent automatic cleanup, adjusting pkcs11 host UUID check to allow for key sharing of encryption keys, preventing cloud tenants from enabling manual key management, preventing use of recording encryption in FIPS mode
eriktate
added a commit
that referenced
this pull request
Sep 3, 2025
* updating protos for recording encryption * changing labels for encryption keys to prevent automatic cleanup, adjusting pkcs11 host UUID check to allow for key sharing of encryption keys, preventing cloud tenants from enabling manual key management, preventing use of recording encryption in FIPS mode
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
* adding support for encryption/decryption keys to keystore manager (#54428, #55652) * adds new protos for resources related to encrypted session recordings and updates the existing SessionRecordingConfig protos to include a Status (#54780) * adding local service implementation for recording encryption resources (#54816) * adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD (#55078) * Adding session recording plugin for `age` (#55120) * adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key * Adding recording encryption and playback for `sync` modes (#54901) * adding cache for RecordingEncryption (#55857) * adding recording_encryption service protos (#55121) * adding async recording encryption with gRPC multipart uploader (#55859) * adding file configuration for encrypted session recording (#56200) * Switching recording encryption to unwrap keys using direct keystore RSA decryption (#56776) * adding manual key management config (#56920) * updating protos for recording encryption (#57055) * Add missing handling for recording encryption configs and keys (#57279) * updating protos for recording encryption * changing labels for encryption keys to prevent automatic cleanup, adjusting pkcs11 host UUID check to allow for key sharing of encryption keys, preventing cloud tenants from enabling manual key management, preventing use of recording encryption in FIPS mode * adding new protos for rotated keys and the local service for interacting (#57576) with them * Switching encryption keys from PEM to ASN.1 DER encoding (#58137) * using pregenerated RSA4096 key for keystore tests because generation is too slow (#58138) * extending precomputed RSA keys to support 4096-bit keys (#58251) * adding rotation process to Manager and exposing with new RPCs and (#57577) * adding rotation sub commands for recording encryption keys and fixing (#57780) broken session_recording_config when using fileconf * using more reliable method of validating key bit length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few missing pieces to recording encryption:
manual_key_management