Adding encrypted recordings for async recording modes#55859
Merged
Conversation
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
from
e111b80 to
8f5347a
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-service-proto
branch
from
6528a81 to
951fe6a
Compare
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
from
8f5347a to
fe05558
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-service-proto
branch
from
951fe6a to
9951b3c
Compare
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
from
fe05558 to
67c47c7
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-service-proto
branch
from
9951b3c to
4c47222
Compare
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
from
67c47c7 to
88fbbc2
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-service-proto
branch
from
4c47222 to
b9d371a
Compare
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
from
88fbbc2 to
f0f55a6
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-service-proto
branch
from
b9d371a to
a046cd8
Compare
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
from
f0f55a6 to
60ae572
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-service-proto
branch
from
5aa67b2 to
e049d5b
Compare
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
from
60ae572 to
6c57ee9
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-service-proto
branch
from
e049d5b to
780f861
Compare
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
2 times, most recently
from
8618e9d to
a3728fe
Compare
github-actions
Bot
added
application-access
audit-log
eriktate
force-pushed
the
eriktate/encrypted-recording-service-proto
branch
from
780f861 to
a3a28cb
Compare
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
from
a3728fe to
151b238
Compare
eriktate
added
the
no-changelog
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
from
fd050fc to
7be7d31
Compare
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
from
f25460a to
7ef3cde
Compare
creack
reviewed
Jun 29, 2025
creack
reviewed
Jun 29, 2025
creack
approved these changes
Jun 29, 2025
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
2 times, most recently
from
8f9a48a to
771d23f
Compare
rosstimothy
reviewed
Jun 30, 2025
rosstimothy
approved these changes
Jun 30, 2025
public-teleport-github-review-bot
Bot
removed request for
greedy52 and
probakowski
eriktate
force-pushed
the
eriktate/async-recording-encryption-multipart
branch
from
224b201 to
cbd0e19
Compare
This was referenced Jun 30, 2025
eriktate
added a commit
that referenced
this pull request
Aug 15, 2025
eriktate
added a commit
that referenced
this pull request
Aug 27, 2025
eriktate
added a commit
that referenced
this pull request
Sep 2, 2025
eriktate
added a commit
that referenced
this pull request
Sep 2, 2025
eriktate
added a commit
that referenced
this pull request
Sep 2, 2025
eriktate
added a commit
that referenced
this pull request
Sep 3, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
* adding support for encryption/decryption keys to keystore manager (#54428, #55652) * adds new protos for resources related to encrypted session recordings and updates the existing SessionRecordingConfig protos to include a Status (#54780) * adding local service implementation for recording encryption resources (#54816) * adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD (#55078) * Adding session recording plugin for `age` (#55120) * adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key * Adding recording encryption and playback for `sync` modes (#54901) * adding cache for RecordingEncryption (#55857) * adding recording_encryption service protos (#55121) * adding async recording encryption with gRPC multipart uploader (#55859) * adding file configuration for encrypted session recording (#56200) * Switching recording encryption to unwrap keys using direct keystore RSA decryption (#56776) * adding manual key management config (#56920) * updating protos for recording encryption (#57055) * Add missing handling for recording encryption configs and keys (#57279) * updating protos for recording encryption * changing labels for encryption keys to prevent automatic cleanup, adjusting pkcs11 host UUID check to allow for key sharing of encryption keys, preventing cloud tenants from enabling manual key management, preventing use of recording encryption in FIPS mode * adding new protos for rotated keys and the local service for interacting (#57576) with them * Switching encryption keys from PEM to ASN.1 DER encoding (#58137) * using pregenerated RSA4096 key for keystore tests because generation is too slow (#58138) * extending precomputed RSA keys to support 4096-bit keys (#58251) * adding rotation process to Manager and exposing with new RPCs and (#57577) * adding rotation sub commands for recording encryption keys and fixing (#57780) broken session_recording_config when using fileconf * using more reliable method of validating key bit length
Contributor
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds recording encryption support for async recording modes. It replaces the existing per event upload of on-disk
.tarrecordings with a multipart upload of the individually encrypted parts over gRPC.