Feature implementation from commits 2ef0bf3..ba724c2#1
Open
yashuatla wants to merge 15 commits intofeature-base-1from
Open
Feature implementation from commits 2ef0bf3..ba724c2#1yashuatla wants to merge 15 commits intofeature-base-1from
yashuatla wants to merge 15 commits intofeature-base-1from
Conversation
* feat: Add bot instance cache * Finalise cache implementation and add tests * Appease the linter * Return early in paging logic * Fix import ordering/grouping * Fix test cache setup * Revert BotCache rename * Clean-up commented code * Revert imports order change * Refactor to use generic getter and lister
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x5af856fc3494]
goroutine 62984 [running]:
github.com/gravitational/teleport/lib/backend/firestore.(*Backend).Items.func3-range1(0xc0001991f0, {0x0?, 0x0?})
github.com/gravitational/teleport/lib/backend/firestore/firestorebk.go:586 +0x134
github.com/gravitational/teleport/lib/backend/firestore.(*Backend).Items.func3.(*Backend).mergedRecords.2-range1(0x5af85ed273a0?, {0x0, 0x0?})
github.com/gravitational/teleport/lib/backend/firestore/firestorebk.go:655 +0x4f
github.com/gravitational/teleport/lib/itertools/stream.MergeStreams[...].func1()
github.com/gravitational/teleport/lib/itertools/stream/stream.go:378 +0x236
github.com/gravitational/teleport/lib/backend/firestore.(*Backend).Items.func3.(*Backend).mergedRecords.2(0xc000e52500)
github.com/gravitational/teleport/lib/backend/firestore/firestorebk.go:654 +0x89b
github.com/gravitational/teleport/lib/backend/firestore.(*Backend).Items.func3(0xc003bb4cc0)
github.com/gravitational/teleport/lib/backend/firestore/firestorebk.go:579 +0x3bf
```
The above panic is caused by the snapShot not being set and thus
resulting in a nil dereference. The snapShot is now assigned outside
of the switch to ensure that all records that are successfully
created contain a reference to a valid DocumentSnapshot.
…nal#55433) * Add support for rocky and almalinux to CDN install script Extends gravitational#44171 * Add rocky and alma as search keywords on discover page * Add rocky and alma as search keywords on discover page * Fix prettier * Fix prettier
* Add info to tsh tests * Specify session id
…al#55693) We had been updating the client activity tracker any time a message was sent from the client (browser or Teleport Connect) to the remote host. This approach was fine for the original RDP implmentation, as all messages sent in this direction were for user input (keypresses, mouse movement, scroll wheel, etc), but it is insufficient with the current RemoteFX implementation as there are some messages sent by the remote Windows hosts which require client acknowledgements. These acknowledgements were mistakenly being counted as client activity. Closes gravitational#55691
…mplete (gravitational#56020) * [vnet] fix: close proxied channel after source channel terminates * buffer error chan, avoid unecessary error wrap
…ops more complex than CRUD (gravitational#55078)
* adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key
* Add SSO MFA support for desktop access. * Update lib/web/desktop.go Co-authored-by: Przemko Robakowski <przemko.robakowski@goteleport.com> * Address style comments. --------- Co-authored-by: Przemko Robakowski <przemko.robakowski@goteleport.com>
* Add Sigstore to workload attestation reference * Remove replaced page * Remove duplicated paragraph * Fix old redirect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes from a range of commits from the original repository.
Commit Range:
2ef0bf3..ba724c2Files Changed: 101 (86 programming files)
Programming Ratio: 85.1%
Commits included:
age(Adding session recording plugin foragegravitational/teleport#55120)... and 5 more commits