Adding recording encryption and playback for sync modes#54901
Merged
Adding recording encryption and playback for sync modes#54901
sync modes#54901Conversation
eriktate
force-pushed
the
eriktate/integrating-recording-encryption-service
branch
from
74655a4 to
e2ffb6f
Compare
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
from
105b5cc to
e7a2e93
Compare
eriktate
changed the base branch from
eriktate/integrating-recording-encryption-service
to
eriktate/encrypted-recording-manager
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
from
e7a2e93 to
13c4954
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-manager
branch
2 times, most recently
from
1a198d9 to
7713063
Compare
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
from
13c4954 to
2b59995
Compare
eriktate
changed the base branch from
eriktate/encrypted-recording-manager
to
eriktate/encrypted-recording-age-plugin
github-actions
Bot
added
audit-log
rosstimothy
reviewed
May 27, 2025
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
3 times, most recently
from
91b056c to
6cbe77d
Compare
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
from
2b59995 to
28e5480
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
6cbe77d to
b3233d2
Compare
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
2 times, most recently
from
d7299df to
01e20fb
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
b3233d2 to
7804aab
Compare
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
from
01e20fb to
04c6341
Compare
rosstimothy
reviewed
May 30, 2025
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
@eriktate what do you think about splitting out the changes here that are dedicated to caching and the event stream to a separate PR?
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
2 times, most recently
from
f5a8502 to
946c684
Compare
|
@eriktate - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
2 times, most recently
from
fdfc71a to
40380b1
Compare
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
from
946c684 to
affe736
Compare
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
2 times, most recently
from
25e862e to
d40fb37
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
43e3753 to
d4f7490
Compare
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
from
d40fb37 to
41804ad
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
d4f7490 to
e2f11a4
Compare
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
from
41804ad to
e9ec376
Compare
eriktate
force-pushed
the
eriktate/encrypted-recording-age-plugin
branch
from
e2f11a4 to
92a6d14
Compare
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
from
e9ec376 to
5d49ccd
Compare
rosstimothy
approved these changes
Jun 24, 2025
Base automatically changed from
eriktate/encrypted-recording-age-plugin
to
master
June 24, 2025 21:57
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
from
fddaaf7 to
f6fc84e
Compare
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
from
f6fc84e to
f5e7591
Compare
Contributor
Author
|
@doggydogworld friendly bump! |
Joerger
reviewed
Jun 25, 2025
Contributor
Joerger
left a comment
Joerger
left a comment
There was a problem hiding this comment.
Can you add a PR description / link to relevant issues?
In particular I'd like to understand how strict the encryption is or any configuration needed to make it work.
Overall LGTM though.
| ) | ||
|
|
||
| func TestEncryptedIO(t *testing.T) { | ||
| ctx := context.Background() |
Contributor
There was a problem hiding this comment.
Did you mean to apply this suggestion?
eriktate
force-pushed
the
eriktate/sync-recording-encryption
branch
from
10d4693 to
9bd4a4a
Compare
Joerger
reviewed
Jun 26, 2025
Joerger
approved these changes
Jun 26, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from doggydogworld
This was referenced Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is in support of the encrypted session recordings RFD. It adds encrypted session recording with decrypted playback for
syncrecording modes. It can be enabled by usingtctlto setencryption.enabled: truein yoursession_recording_config:It will use whichever CA keystore is configured in order to provision the necessary key encryption keys, which by default uses software keys