Refactoring encrypted recording protos#57055
Merged
Conversation
eriktate
force-pushed
the
eriktate/manual-encryption-keys
branch
from
29da268 to
3f8ea79
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
6fe04d5 to
8f04bb8
Compare
eriktate
force-pushed
the
eriktate/manual-encryption-keys
branch
from
3f8ea79 to
6c7edeb
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
8f04bb8 to
96c32a3
Compare
eriktate
force-pushed
the
eriktate/manual-encryption-keys
branch
from
6c7edeb to
174da72
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
96c32a3 to
2dac31e
Compare
eriktate
force-pushed
the
eriktate/manual-encryption-keys
branch
from
174da72 to
836f806
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
2 times, most recently
from
5fb1808 to
6c78ec7
Compare
eriktate
force-pushed
the
eriktate/manual-encryption-keys
branch
from
61d2a6e to
300641f
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
6c78ec7 to
3c160d0
Compare
eriktate
added
the
no-changelog
eriktate
force-pushed
the
eriktate/manual-encryption-keys
branch
2 times, most recently
from
6f668f3 to
27e5b9c
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
3c160d0 to
e99bcc2
Compare
eriktate
force-pushed
the
eriktate/manual-encryption-keys
branch
from
d114b67 to
3d01dd2
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
2 times, most recently
from
7b9deac to
62e79de
Compare
eriktate
force-pushed
the
eriktate/manual-encryption-keys
branch
from
3d01dd2 to
0372b0a
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
62e79de to
b222099
Compare
eriktate
force-pushed
the
eriktate/manual-encryption-keys
branch
from
0372b0a to
2c98b5d
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
2 times, most recently
from
31d2f5b to
ba80699
Compare
Contributor
|
Amplify deployment status
|
rosstimothy
approved these changes
Aug 7, 2025
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
93f5e0a to
71ad8e4
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
71ad8e4 to
850c067
Compare
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
850c067 to
b5a7837
Compare
Contributor
Author
|
@hugoShaka @kiosion friendly bump! |
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
b5a7837 to
c82d3de
Compare
hugoShaka
approved these changes
Aug 12, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
eriktate
added a commit
that referenced
this pull request
Aug 15, 2025
eriktate
added a commit
that referenced
this pull request
Aug 27, 2025
eriktate
added a commit
that referenced
this pull request
Sep 2, 2025
eriktate
added a commit
that referenced
this pull request
Sep 2, 2025
eriktate
added a commit
that referenced
this pull request
Sep 2, 2025
eriktate
added a commit
that referenced
this pull request
Sep 3, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
* adding support for encryption/decryption keys to keystore manager (#54428, #55652) * adds new protos for resources related to encrypted session recordings and updates the existing SessionRecordingConfig protos to include a Status (#54780) * adding local service implementation for recording encryption resources (#54816) * adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD (#55078) * Adding session recording plugin for `age` (#55120) * adding Manager for RecordingEncryption resources that handles shared ops more complex than CRUD * adding age plugin wrapping default X25519 Identity/Recipient implementation with hooks to more efficiently lookup private keys given their respective public key * Adding recording encryption and playback for `sync` modes (#54901) * adding cache for RecordingEncryption (#55857) * adding recording_encryption service protos (#55121) * adding async recording encryption with gRPC multipart uploader (#55859) * adding file configuration for encrypted session recording (#56200) * Switching recording encryption to unwrap keys using direct keystore RSA decryption (#56776) * adding manual key management config (#56920) * updating protos for recording encryption (#57055) * Add missing handling for recording encryption configs and keys (#57279) * updating protos for recording encryption * changing labels for encryption keys to prevent automatic cleanup, adjusting pkcs11 host UUID check to allow for key sharing of encryption keys, preventing cloud tenants from enabling manual key management, preventing use of recording encryption in FIPS mode * adding new protos for rotated keys and the local service for interacting (#57576) with them * Switching encryption keys from PEM to ASN.1 DER encoding (#58137) * using pregenerated RSA4096 key for keystore tests because generation is too slow (#58138) * extending precomputed RSA keys to support 4096-bit keys (#58251) * adding rotation process to Manager and exposing with new RPCs and (#57577) * adding rotation sub commands for recording encryption keys and fixing (#57780) broken session_recording_config when using fileconf * using more reliable method of validating key bit length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the protos for recording encryption to match some of the recent changes made to the RFD