Fix - Updated logic to choose/create the feed for product sync#2989
Closed
mshymon wants to merge 2 commits intofacebook:mainfrom
Closed
Fix - Updated logic to choose/create the feed for product sync#2989mshymon wants to merge 2 commits intofacebook:mainfrom
mshymon wants to merge 2 commits intofacebook:mainfrom
Conversation
mshymon
force-pushed
the
fix_only_use_new_feed
branch
from
2e5f1a0 to
25dbcd6
Compare
Contributor
|
@mshymon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
tzahgr
pushed a commit
that referenced
this pull request
Apr 1, 2025
Summary: ## Description Problem. We selecting a product feed for creating one-time feed upload sessions to sync products, we are prioritising to choose an existing product feed created by MBE onboarding. The problem is that in production some of the catalogs have that default feed already in use for creating and updating products (from some 3rd party sources). In those cases, by uploading new one-time feed upload sessions, we are deleting all products previously ingested by the feed (as 3rd party source are almost for sure have different population of product Retailer IDs). Fix. We should avoid choosing the default MBE created feed and just choose/create the unique Facebook for WooCommerce plugin feed. ### Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) ## Screenshots See below in the test plan. Pull Request resolved: #2989 Test Plan: Manual testing on my catalog. Before start, I have two feeds, including the default MBE feed, which was used by earlier logic: <img width="1975" alt="Screenshot 2025-03-31 at 19 20 47" src="https://github.com/user-attachments/assets/d4af0d82-a34f-465d-ab6d-c3ddbc604eae" /> I manually triggered feed file generation, which then selects a feed and start the one-time upload session. The new feed was created and chosen. <img width="1936" alt="Screenshot 2025-03-31 at 19 24 08" src="https://github.com/user-attachments/assets/7e3158d5-e34f-42fb-aaa5-dd3476a45e26" /> Have this reflected in the WooCommerce facebook log file: <img width="2479" alt="Screenshot 2025-03-31 at 19 23 22" src="https://github.com/user-attachments/assets/65766d31-d9cd-4673-8ff5-cc12a3b75835" /> When triggered feed file generation again, the same feed (2096188910809232) was chosen. ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry Fix - Updated logic to choose/create the feed for product sync Reviewed By: vinkmeta Differential Revision: D72183913 Pulled By: mshymon fbshipit-source-id: 36d7a528ee370f10c5e135bf4e7cf64c218bfe45
SayanPandey
pushed a commit
to SayanPandey/facebook-for-woocommerce
that referenced
this pull request
Apr 1, 2025
…ook#2989) Summary: ## Description Problem. We selecting a product feed for creating one-time feed upload sessions to sync products, we are prioritising to choose an existing product feed created by MBE onboarding. The problem is that in production some of the catalogs have that default feed already in use for creating and updating products (from some 3rd party sources). In those cases, by uploading new one-time feed upload sessions, we are deleting all products previously ingested by the feed (as 3rd party source are almost for sure have different population of product Retailer IDs). Fix. We should avoid choosing the default MBE created feed and just choose/create the unique Facebook for WooCommerce plugin feed. ### Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) ## Screenshots See below in the test plan. Pull Request resolved: facebook#2989 Test Plan: Manual testing on my catalog. Before start, I have two feeds, including the default MBE feed, which was used by earlier logic: <img width="1975" alt="Screenshot 2025-03-31 at 19 20 47" src="https://github.com/user-attachments/assets/d4af0d82-a34f-465d-ab6d-c3ddbc604eae" /> I manually triggered feed file generation, which then selects a feed and start the one-time upload session. The new feed was created and chosen. <img width="1936" alt="Screenshot 2025-03-31 at 19 24 08" src="https://github.com/user-attachments/assets/7e3158d5-e34f-42fb-aaa5-dd3476a45e26" /> Have this reflected in the WooCommerce facebook log file: <img width="2479" alt="Screenshot 2025-03-31 at 19 23 22" src="https://github.com/user-attachments/assets/65766d31-d9cd-4673-8ff5-cc12a3b75835" /> When triggered feed file generation again, the same feed (2096188910809232) was chosen. ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry Fix - Updated logic to choose/create the feed for product sync Reviewed By: vinkmeta Differential Revision: D72183913 Pulled By: mshymon fbshipit-source-id: 36d7a528ee370f10c5e135bf4e7cf64c218bfe45
This was referenced Apr 2, 2025
Merged
This was referenced Apr 10, 2025
Closed
Closed
mradmeta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: ## Description Problem. We selecting a product feed for creating one-time feed upload sessions to sync products, we are prioritising to choose an existing product feed created by MBE onboarding. The problem is that in production some of the catalogs have that default feed already in use for creating and updating products (from some 3rd party sources). In those cases, by uploading new one-time feed upload sessions, we are deleting all products previously ingested by the feed (as 3rd party source are almost for sure have different population of product Retailer IDs). Fix. We should avoid choosing the default MBE created feed and just choose/create the unique Facebook for WooCommerce plugin feed. ### Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) ## Screenshots See below in the test plan. Pull Request resolved: #2989 Test Plan: Manual testing on my catalog. Before start, I have two feeds, including the default MBE feed, which was used by earlier logic: <img width="1975" alt="Screenshot 2025-03-31 at 19 20 47" src="https://github.com/user-attachments/assets/d4af0d82-a34f-465d-ab6d-c3ddbc604eae" /> I manually triggered feed file generation, which then selects a feed and start the one-time upload session. The new feed was created and chosen. <img width="1936" alt="Screenshot 2025-03-31 at 19 24 08" src="https://github.com/user-attachments/assets/7e3158d5-e34f-42fb-aaa5-dd3476a45e26" /> Have this reflected in the WooCommerce facebook log file: <img width="2479" alt="Screenshot 2025-03-31 at 19 23 22" src="https://github.com/user-attachments/assets/65766d31-d9cd-4673-8ff5-cc12a3b75835" /> When triggered feed file generation again, the same feed (2096188910809232) was chosen. ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry Fix - Updated logic to choose/create the feed for product sync Reviewed By: vinkmeta Differential Revision: D72183913 Pulled By: mshymon fbshipit-source-id: 36d7a528ee370f10c5e135bf4e7cf64c218bfe45
This was referenced Apr 18, 2025
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem. We selecting a product feed for creating one-time feed upload sessions to sync products, we are prioritising to choose an existing product feed created by MBE onboarding. The problem is that in production some of the catalogs have that default feed already in use for creating and updating products (from some 3rd party sources). In those cases, by uploading new one-time feed upload sessions, we are deleting all products previously ingested by the feed (as 3rd party source are almost for sure have different population of product Retailer IDs).
Fix. We should avoid choosing the default MBE created feed and just choose/create the unique Facebook for WooCommerce plugin feed.
Type of change
Please delete options that are not relevant.
Screenshots
See below in the test plan.
Test Plan
Manual testing on my catalog.
Before start, I have two feeds, including the default MBE feed, which was used by earlier logic:
I manually triggered feed file generation, which then selects a feed and start the one-time upload session. The new feed was created and chosen.
Have this reflected in the WooCommerce facebook log file:
When triggered feed file generation again, the same feed (2096188910809232) was chosen.
Checklist
Changelog entry
Fix - Updated logic to choose/create the feed for product sync