Conversation
…essary op-proposer dependency in tooling
Every L2 predeploy that has `Semver` must be built so that it's immutables are handled, even though they are hardcoded in the bytecode. Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Moves the `GovernanceToken` into `contracts-bedrock` so that its artifact can be easily inspected. This is the first step in deleting `contracts-governance`. The other files should be moved to `contracts-periphery`.
Use `hardhat compile` so that it ensures that the artifacts used by the generator are up to date
* op-node: Add heartbeater * Update op-node/heartbeat/service.go Co-authored-by: Joshua Gutow <jgutow@optimism.io> * imports Co-authored-by: Joshua Gutow <jgutow@optimism.io>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 96111d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
tynes
requested review from
mslipper and
trianglesphere
and removed request for
mslipper
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
smartcontracts
approved these changes
Sep 10, 2022
Updates the StandardBridge to use immutable variables instead of state variables. Primary reason for this change is to guarantee that the storage layout will not be a problem during the upgrade. Plus, there's really no reason why these variables shouldn't be immutable.
chore: Upgrade foundry
feat(ctb): make StandardBridge vars immutable
These are no longer used, in favor of the `op-node` commands that generate the genesis files instead. contracts-bedrock: delete imports
Tweaks the storage layout of the CrossDomainMessenger base contract to reduce the number of changes with the existing system. The L1CrossDomainMessenger has no storage diff after this PR.
Improve the error message during genesis generation
feat(ctb): tweak XDM storage layout
* op-node: sync start update func signature, port over tests from safe-head-fix pr * op-node: sync start now starts with current heads by label * op-node: single loop find-heads * op-node: sync - clean up go doc * op-node: use sync fn in engine queue * op-node: fix engine queue finalization test * op-node: sync off-by-one fix * op-node: fix highest l2 block with canon origin, need to reset when l1 reorg * op-node: handle non-standard safe/finalized not found errors * op-node: sync start review fixes / comment typos * op-node: seq window size check with l1 origin, update engine queue test with extra l1 origin, now that off by 1 fix applies properly to chains with multiple L2 blocks per L1 block * op-node: start from parent block before seq nr 0 * Update op-node/rollup/sync/start.go Co-authored-by: Joshua Gutow <jgutow@optimism.io> * review fixes * fix lint Co-authored-by: Joshua Gutow <jgutow@optimism.io> Co-authored-by: Matthew Slipper <me@matthewslipper.com>
op-chain-ops: better error message
contracts-bedrock: regenerate storage layout
* add wsteth to indexer * changeset Co-authored-by: Will Cory <willcory@Wills-MacBook-Pro.local> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
contracts-bedrock: delete hardhat genesis tasks
op-node,op-proposer: move rollup client bindings
* op-node: goimports * op-batcher: goimports * op-proposer: goimports * Fix deleted line due to overeager sed * fix imports Co-authored-by: protolambda <proto@protolambda.com>
* contracts-bedrock: Fix deployment script * Don't lint more files
op-bindings: remove executable flag on files
* contracts-bedrock: Fix deployment * lint
Speeds up the storage snapshot by using fully qualified paths to the contracts. This makes it such that foundry will not recompile the contracts each time.
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
This calls a FCU to set the unsafe head of the L2 execution client immediately after NewPayload is called on the execution client. This means that the unsafe head in the node state matches the unsafe head on the execution client. This commit removes the FCU prior to the NewPayload call because we assert that the unsafe block that we are inserting extends the current unsafe head. As such, the L2 execution client is in a state to accept the new block.
check-changed was breaking when develop -> master PRs were open. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* contracts-bedrock: Make initialization serial, add logging * lint
contracts-bedrock: speed up storage snapshot
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* indexer: scan eth/standard bridge for deposits * indexer: fix standard bridge addr, add eth bridge * indexer: use predeploy addr const * indexer: map chainID -> default bridge address * indexer: l2 - map chainID to bridge addresses Co-authored-by: Matthew Slipper <me@matthewslipper.com>
contracts-bedrock: Remove Goerli deployment, replace with alpha testnet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Begin triggering releases