Skip to content

op-node,op-proposer: move rollup client bindings#3367

Merged
tynes merged 3 commits intodevelopfrom
rollup-client-move
Sep 10, 2022
Merged

op-node,op-proposer: move rollup client bindings#3367
tynes merged 3 commits intodevelopfrom
rollup-client-move

Conversation

@protolambda
Copy link
Contributor

@protolambda protolambda commented Sep 9, 2022

move rollup bindings into op-node to avoid unnecessary op-proposer dependency in tooling / batcher.

  • left rollupclient with alias type / constructor call for backwards compatibility.
  • SyncStatus was moved to eth package to avoid import cycles with bindings and driver.

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2022

⚠️ No Changeset found

Latest commit: d61365a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@protolambda protolambda requested a review from mslipper September 9, 2022 09:00
@mslipper
Copy link
Contributor

mslipper commented Sep 9, 2022

Can you update the Make target that updates packages? Or do we not have to update it because we have the alias?

Copy link
Contributor

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending response to the requested Makefile changes.

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2022

Merge failed. Please see automated check logs for more details.

@mergify mergify bot removed the on-merge-train label Sep 10, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2022

This PR has been added to the merge queue, and will be merged soon.

@tynes tynes merged commit 62b2ef9 into develop Sep 10, 2022
@tynes tynes deleted the rollup-client-move branch September 10, 2022 19:24
@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2022

Merge failed. Please see automated check logs for more details.

@mergify mergify bot removed the on-merge-train label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants