op-node/batcher/proposer: Standardize goimports#3403
Conversation
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
|
LGTM, can you put the script in CI? Like the other diff checks, we can run it, and then check if there's a diff to confirm the contents are formatted correctly. |
Not reliably. There's two parts of this: killing the newlines between the different import sections & doing goimports. We already have goimports, but this mainly does does the killing newlines. Unfortunately the sed script is not reliable enough when there is a single import line to run. |
|
Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review. |
|
Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review. |
3725a6f to
cd28ab8
Compare
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
* op-node: goimports * op-batcher: goimports * op-proposer: goimports * Fix deleted line due to overeager sed * fix imports Co-authored-by: protolambda <proto@protolambda.com>
* op-node: goimports * op-batcher: goimports * op-proposer: goimports * Fix deleted line due to overeager sed * fix imports Co-authored-by: protolambda <proto@protolambda.com>
Description
This standardizes go imports across the three go codebases. This removes
empty lines between import sections & relies on
goimportsto sort the rest.Imports from the
ethereum-optimismandgo-ethereumrepositories aretreated as local imports.
Additional Information
I used the following script to implement this change: