op-node: Call FCU on new unsafe payload#3418
Merged
mergify[bot] merged 1 commit intodevelopfrom Sep 11, 2022
Merged
Conversation
This calls a FCU to set the unsafe head of the L2 execution client immediately after NewPayload is called on the execution client. This means that the unsafe head in the node state matches the unsafe head on the execution client. This commit removes the FCU prior to the NewPayload call because we assert that the unsafe block that we are inserting extends the current unsafe head. As such, the L2 execution client is in a state to accept the new block.
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
protolambda
approved these changes
Sep 11, 2022
mslipper
approved these changes
Sep 11, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
This calls a FCU to set the unsafe head of the L2 execution client immediately after NewPayload is called on the execution client. This means that the unsafe head in the node state matches the unsafe head on the execution client. This commit removes the FCU prior to the NewPayload call because we assert that the unsafe block that we are inserting extends the current unsafe head. As such, the L2 execution client is in a state to accept the new block.
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
This calls a FCU to set the unsafe head of the L2 execution client immediately after NewPayload is called on the execution client. This means that the unsafe head in the node state matches the unsafe head on the execution client. This commit removes the FCU prior to the NewPayload call because we assert that the unsafe block that we are inserting extends the current unsafe head. As such, the L2 execution client is in a state to accept the new block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This calls a FCU to set the unsafe head of the L2 execution client immediately after NewPayload is called on the execution client. This means that the unsafe head in the node state matches the unsafe head on the execution client.
This commit removes the FCU prior to the NewPayload call because we assert that the unsafe block that we are inserting extends the current unsafe head. As such, the L2 execution client is in a state to accept the new block.
Tests
No new tests.