Conversation
🦋 Changeset detectedLatest commit: 3d228a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
Contributor
|
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
tynes
approved these changes
Sep 10, 2022
Tweaks the storage layout of the CrossDomainMessenger base contract to reduce the number of changes with the existing system. The L1CrossDomainMessenger has no storage diff after this PR.
smartcontracts
force-pushed
the
sc/ctb-fix-xdm-slots
branch
from
c153d89 to
3d228a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tweaks the storage layout of the CrossDomainMessenger base contract to reduce the number of changes with the existing system. The L1CrossDomainMessenger has no storage diff after this PR.
Tests
No logic is changing, so no tests are needed. We will eventually want a script that verifies the storage layout diff, though.