specs: Add deposit gas metering spec #2679
Conversation
|
trianglesphere
requested review from
norswap and
protolambda
and removed request for
Inphi
trianglesphere
force-pushed
the
jg/deposit_fee_spec
branch
from
d523223 to
ebd12d2
Compare
trianglesphere
requested review from
tynes
and removed request for
Inphi and
mslipper
|
@trianglesphere it'll just keep putting those reviewers back. I can remove that in Mergify. |
I didn't realize it was mergify that kept adding them. If you use GH code owners it doesn't re-add them if you manually remove them (also code owners lints for people to make sure they are in the project). |
norswap
left a comment
norswap
left a comment
There was a problem hiding this comment.
It's in pretty good shape!
trianglesphere
force-pushed
the
jg/deposit_fee_spec
branch
2 times, most recently
from
1803af6 to
50c5367
Compare
trianglesphere
force-pushed
the
jg/deposit_fee_spec
branch
from
50c5367 to
e6418ee
Compare
norswap
left a comment
norswap
left a comment
There was a problem hiding this comment.
Made some followup comments, fix to you liking, and after that gtg!
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
* Deposit Fee Spec * Update guaranteed-gas-market.md * Update guaranteed-gas-market.md * Update guaranteed-gas-market.md * PR Fixes * PR Changes Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Deposit Fee Spec * Update guaranteed-gas-market.md * Update guaranteed-gas-market.md * Update guaranteed-gas-market.md * PR Fixes * PR Changes Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
## Description Bootstraps the integration tests crate for kona services. For now we only have a very basic p2p test that spins off two networks and perform a check that those two are properly connected to each other Progress on #2623
…uce test flakiness (#2693) ## Description This PR achieves the following goals: - Extend the simple p2p connection tests of #2679 with more comprehensive tests involving block signature and propagation (a follow PR will add the cases for higher block versions, it requires updating the rollup config with hardfork times) - Fixes the network bootstrap logic to remove flakiness. In particular, it uses kernel allocated ports for discovery/gossip to avoid static modification races. - It adds random valid block building logic
…uce test flakiness (op-rs/kona#2693) ## Description This PR achieves the following goals: - Extend the simple p2p connection tests of #2679 with more comprehensive tests involving block signature and propagation (a follow PR will add the cases for higher block versions, it requires updating the rollup config with hardfork times) - Fixes the network bootstrap logic to remove flakiness. In particular, it uses kernel allocated ports for discovery/gossip to avoid static modification races. - It adds random valid block building logic
5 participants
Description
Add specs for the new deposit fee model.
Implementation is done in the following PRs:
Metadata