This repository was archived by the owner on Aug 20, 2022. It is now read-only.
core: Add version to DepositTx#19
Merged
trianglesphere merged 1 commit intooptimism-prototypefrom May 24, 2022
Merged
Conversation
This adds a second byte after the EIP-2718 Type byte to deposit transactions that versions the deposit. It is placed prior to the start of the RLP to make it easier to extend the transaction in the future. We choose to version inside the EIP-2718 envelope to limit the number of EIP-2718 prefixes we take for deposit transactions.
trianglesphere
added a commit
that referenced
this pull request
May 24, 2022
This adds a second byte after the EIP-2718 Type byte to deposit transactions that versions the deposit. It is placed prior to the start of the RLP to make it easier to extend the transaction in the future. We choose to version inside the EIP-2718 envelope to limit the number of EIP-2718 prefixes we take for deposit transactions.
protolambda
pushed a commit
that referenced
this pull request
Jun 1, 2022
This adds a second byte after the EIP-2718 Type byte to deposit transactions that versions the deposit. It is placed prior to the start of the RLP to make it easier to extend the transaction in the future. We choose to version inside the EIP-2718 envelope to limit the number of EIP-2718 prefixes we take for deposit transactions.
protolambda
pushed a commit
that referenced
this pull request
Jun 1, 2022
This adds a second byte after the EIP-2718 Type byte to deposit transactions that versions the deposit. It is placed prior to the start of the RLP to make it easier to extend the transaction in the future. We choose to version inside the EIP-2718 envelope to limit the number of EIP-2718 prefixes we take for deposit transactions.
protolambda
pushed a commit
that referenced
this pull request
Jun 2, 2022
This adds a second byte after the EIP-2718 Type byte to deposit transactions that versions the deposit. It is placed prior to the start of the RLP to make it easier to extend the transaction in the future. We choose to version inside the EIP-2718 envelope to limit the number of EIP-2718 prefixes we take for deposit transactions.
protolambda
pushed a commit
that referenced
this pull request
Jul 15, 2022
This adds a second byte after the EIP-2718 Type byte to deposit transactions that versions the deposit. It is placed prior to the start of the RLP to make it easier to extend the transaction in the future. We choose to version inside the EIP-2718 envelope to limit the number of EIP-2718 prefixes we take for deposit transactions.
protolambda
pushed a commit
that referenced
this pull request
Jul 15, 2022
This adds a second byte after the EIP-2718 Type byte to deposit transactions that versions the deposit. It is placed prior to the start of the RLP to make it easier to extend the transaction in the future. We choose to version inside the EIP-2718 envelope to limit the number of EIP-2718 prefixes we take for deposit transactions.
protolambda
pushed a commit
that referenced
this pull request
Aug 2, 2022
This adds a second byte after the EIP-2718 Type byte to deposit transactions that versions the deposit. It is placed prior to the start of the RLP to make it easier to extend the transaction in the future. We choose to version inside the EIP-2718 envelope to limit the number of EIP-2718 prefixes we take for deposit transactions.
protolambda
pushed a commit
that referenced
this pull request
Aug 2, 2022
This adds a second byte after the EIP-2718 Type byte to deposit transactions that versions the deposit. It is placed prior to the start of the RLP to make it easier to extend the transaction in the future. We choose to version inside the EIP-2718 envelope to limit the number of EIP-2718 prefixes we take for deposit transactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a second byte after the EIP-2718 Type byte to deposit
transactions that versions the deposit. It is placed prior to the start
of the RLP to make it easier to extend the transaction in the future. We
choose to version inside the EIP-2718 envelope to limit the number of
EIP-2718 prefixes we take for deposit transactions.
Metadata