Bedrock: driver/batcher refactor (Work in progress)#2693
Closed
protolambda wants to merge 3 commits intodevelopfrom
Closed
Bedrock: driver/batcher refactor (Work in progress)#2693protolambda wants to merge 3 commits intodevelopfrom
protolambda wants to merge 3 commits intodevelopfrom
Conversation
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
Contributor
Author
|
Closing this in favor of the other newer batch derivation refactor PR |
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
…uce test flakiness (#2693) ## Description This PR achieves the following goals: - Extend the simple p2p connection tests of #2679 with more comprehensive tests involving block signature and propagation (a follow PR will add the cases for higher block versions, it requires updating the rollup config with hardfork times) - Fixes the network bootstrap logic to remove flakiness. In particular, it uses kernel allocated ports for discovery/gossip to avoid static modification races. - It adds random valid block building logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
The new derivation/batching is not integrated yet.
TODO:
In a separate PR we can swap out the original functions that derive and build this data.
This implements batching V2, for: