This repository was archived by the owner on Aug 20, 2022. It is now read-only.
core: Include guaranteed gas in the gas pool#21
Merged
trianglesphere merged 1 commit intooptimism-prototypefrom Jun 1, 2022
Merged
core: Include guaranteed gas in the gas pool#21trianglesphere merged 1 commit intooptimism-prototypefrom
trianglesphere merged 1 commit intooptimism-prototypefrom
Conversation
protolambda
reviewed
May 19, 2022
Contributor
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
LGTM, would like to see a note about the intrisic gas usage in the spec before then removing the TODO and merging this PR.
This now requires L1 to limit the total amount of guaranteed gas that is provided to deposits. This includes the guaranteed gas in the total gas used in order to limit the number of normal transactions in a block and enable accurate EIP-1559 basefee updates.
trianglesphere
force-pushed
the
jg/include_deposit_gas
branch
from
5f955c3 to
aa312af
Compare
Contributor
Author
|
@protolambda intrinsic gas usage updated. Specs change here: https://github.com/ethereum-optimism/optimistic-specs/pull/401/files#diff-83684a8056b80b8473890eafdbcc2d0bf3e9909f3d0f2309ba0b54b4351aa0c5R146-R149 |
trianglesphere
added a commit
that referenced
this pull request
Jun 1, 2022
This now requires L1 to limit the total amount of guaranteed gas that is provided to deposits. This includes the guaranteed gas in the total gas used in order to limit the number of normal transactions in a block and enable accurate EIP-1559 basefee updates.
protolambda
pushed a commit
that referenced
this pull request
Jun 1, 2022
This now requires L1 to limit the total amount of guaranteed gas that is provided to deposits. This includes the guaranteed gas in the total gas used in order to limit the number of normal transactions in a block and enable accurate EIP-1559 basefee updates.
protolambda
pushed a commit
that referenced
this pull request
Jun 1, 2022
This now requires L1 to limit the total amount of guaranteed gas that is provided to deposits. This includes the guaranteed gas in the total gas used in order to limit the number of normal transactions in a block and enable accurate EIP-1559 basefee updates.
protolambda
pushed a commit
that referenced
this pull request
Jun 2, 2022
This now requires L1 to limit the total amount of guaranteed gas that is provided to deposits. This includes the guaranteed gas in the total gas used in order to limit the number of normal transactions in a block and enable accurate EIP-1559 basefee updates.
protolambda
pushed a commit
that referenced
this pull request
Jul 15, 2022
This now requires L1 to limit the total amount of guaranteed gas that is provided to deposits. This includes the guaranteed gas in the total gas used in order to limit the number of normal transactions in a block and enable accurate EIP-1559 basefee updates.
protolambda
pushed a commit
that referenced
this pull request
Jul 15, 2022
This now requires L1 to limit the total amount of guaranteed gas that is provided to deposits. This includes the guaranteed gas in the total gas used in order to limit the number of normal transactions in a block and enable accurate EIP-1559 basefee updates.
protolambda
pushed a commit
that referenced
this pull request
Aug 2, 2022
This now requires L1 to limit the total amount of guaranteed gas that is provided to deposits. This includes the guaranteed gas in the total gas used in order to limit the number of normal transactions in a block and enable accurate EIP-1559 basefee updates.
protolambda
pushed a commit
that referenced
this pull request
Aug 2, 2022
This now requires L1 to limit the total amount of guaranteed gas that is provided to deposits. This includes the guaranteed gas in the total gas used in order to limit the number of normal transactions in a block and enable accurate EIP-1559 basefee updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This now requires L1 to limit the total amount of guaranteed gas that is
provided to deposits. This includes the guaranteed gas in the total gas
used in order to limit the number of normal transactions in a block and
enable accurate EIP-1559 basefee updates.
Metadata