Skip to content

Comments

op-node: Adjust L1 Info Transaction Gas Parameters#2582

Merged
trianglesphere merged 1 commit intodevelopfrom
jg/new_l1_info_gas_usage
May 31, 2022
Merged

op-node: Adjust L1 Info Transaction Gas Parameters#2582
trianglesphere merged 1 commit intodevelopfrom
jg/new_l1_info_gas_usage

Conversation

@trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented May 18, 2022

Description

This reduces the gas on the L1 Info Transaction from 99,999,999
down to 75,000. This is required as the gas from deposits is now
being counted against the total gas used in the L2 block.

Typically the transaction only uses around 30k gas and 35k would
be fine; however, for the first transaction, it uses more gas to
set the storage slots from zero (around 70k gas). As such, we
set it to a single gas limit for the time being. We also give
it a buffer of 5k gas to ensure that this transaction will not
fail.

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2022

⚠️ No Changeset found

Latest commit: adad9e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from Inphi and mslipper May 18, 2022 20:43
@mergify
Copy link
Contributor

mergify bot commented May 18, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@trianglesphere
Copy link
Contributor Author

Note: may want to hold off on merging until confident in the value we're using.

@tynes
Copy link
Contributor

tynes commented May 19, 2022

This may have to change once #2583 lands depending on how much gas usage is added by keeping track of the average

@trianglesphere trianglesphere force-pushed the jg/new_l1_info_gas_usage branch from 8e1500f to 7ee2e41 Compare May 31, 2022 21:54
@trianglesphere
Copy link
Contributor Author

This may have to change once #2583 lands depending on how much gas usage is added by keeping track of the average

Let's do a follow up once the new L1 Info PR is ready. I think the biggest gas cost to this is the very first transaction (setting slots from 0).

This reduces the gas on the L1 Info Transaction from 99,999,999
down to 75,000. This is required as the gas from deposits is now
being counted against the total gas used in the L2 block.

Typically the transaction only uses around 30k gas and 35k would
be fine; however, for the first transaction, it uses more gas to
set the storage slots from zero (around 70k gas). As such, we
set it to a single gas limit for the time being. We also give
it a buffer of 5k gas to ensure that this transaction will not
fail.
@trianglesphere trianglesphere force-pushed the jg/new_l1_info_gas_usage branch from 7ee2e41 to adad9e2 Compare May 31, 2022 22:02
@trianglesphere trianglesphere merged commit 50d2b10 into develop May 31, 2022
@trianglesphere trianglesphere deleted the jg/new_l1_info_gas_usage branch May 31, 2022 22:14
@mergify
Copy link
Contributor

mergify bot commented May 31, 2022

This PR has been added to the merge queue, and will be merged soon.

theochap pushed a commit that referenced this pull request Dec 10, 2025
### Description

Use claude to add metrics to the `kona-providers-alloy`.

Replaces #2607 

Closes #2582

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
theochap pushed a commit that referenced this pull request Jan 14, 2026
### Description

Use claude to add metrics to the `kona-providers-alloy`.

Replaces #2607 

Closes #2582

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants