examples: Fix more deprecations/warnings in configs by phlax · Pull Request #13529 · envoyproxy/envoy

phlax · 2020-10-13T06:57:24Z

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: examples: Fix more deprecations/warnings in configs
Additional Description:

further to #13503

Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

phlax · 2020-10-13T08:47:04Z

doing git grep v2 examples/ i think i have caught most of the v2 deprecated configs - there are some remaining references, particularly in the go implementations

phlax · 2020-10-13T10:45:44Z

/retest-circle

repokitteh-read-only · 2020-10-13T10:45:48Z

🔨 rebuilding ci/circleci: api (failed build)
🔨 rebuilding ci/circleci: go_control_plane_mirror (failed build)

🐱

Caused by: a #13529 (comment) was created by @phlax.

see: more, trace.

Signed-off-by: Ryan Northey <ryan@synca.io>

mattklein123

Thanks (though again I would really like to understand why this is not failing as I thought we fail config checking when using a deprecated field).

/wait

examples/jaeger-tracing/front-envoy-jaeger.yaml

phlax · 2020-10-13T15:04:43Z

@mattklein123 im afraid that is beyond my immediate knowledge of how the config validation works

Shall i open a separate ticket, and then we can land this ?

mattklein123 · 2020-10-13T15:10:43Z

Shall i open a separate ticket, and then we can land this ?

Yes that's fine. I think this may be specific to the deprecated typed_config that @htuch recently worked on, but I'm not sure.

htuch · 2020-10-13T15:16:39Z

Let's discuss in the other thread.

phlax · 2020-10-13T15:18:45Z

Let's discuss in the other thread.

i pushed the thread to #13542

Signed-off-by: Ryan Northey <ryan@synca.io>

phlax · 2020-10-13T15:51:29Z

/retest

repokitteh-read-only · 2020-10-13T15:51:33Z

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Cannot retry non-completed check: envoy-presubmit (macOS), please wait.

🐱

Caused by: a #13529 (comment) was created by @phlax.

see: more, trace.

htuch

LGTM, thanks!

phlax · 2020-10-13T16:25:45Z

not sure what is happening with CI - this PR was passing with current config earlier

now im seeing errors about xstatic_resources across failing PRs

mattklein123 · 2020-10-13T16:28:20Z

now im seeing errors about xstatic_resources across failing PRs

xstatic is a typo...

phlax · 2020-10-13T16:33:41Z

sorry my bad (emacs key bindings) - ill fix

Signed-off-by: Ryan Northey <ryan@synca.io>

moderation · 2020-10-13T21:27:37Z

Woohoo @phlax. More v2 if you have the bandwidth. Here are the files with v2 in the name and there are more v2 references inside configs/:

configs/access_log_format_helper_v2.template.yaml
configs/envoy_double_proxy_v2.template.yaml
configs/envoy_front_proxy_v2.template.yaml
configs/envoy_router_v2.template.yaml
configs/envoy_service_to_service_v2.template.yaml
configs/google_com_proxy.v2.yaml
configs/routing_helper_v2.template.yaml
configs/using_deprecated_config.v2.yaml
examples/ext_authz/config/grpc-service/v2.yaml
examples/ext_authz/config/opa-service/v2.yaml
test/config/integration/google_com_proxy_port_0.v2.yaml

* master: (22 commits) http: using CONNECT_ERROR for HTTP/2 (envoyproxy#13519) listener: respect address.pipe.mode (it didn't work) (envoyproxy#13493) examples: Fix more deprecations/warnings in configs (envoyproxy#13529) overload: tcp connection refusal overload action (envoyproxy#13311) tcp: towards pluggable upstreams (envoyproxy#13331) conn_pool: fixing comments (envoyproxy#13520) Prevent SEGFAULT when disabling listener (envoyproxy#13515) Convert overload manager config literals to YAML (envoyproxy#13518) Fix runtime feature variable name (envoyproxy#13533) dependencies: refactor repository location schema utils, cleanups. (envoyproxy#13452) router: fix an invalid ASSERT when encoding metadata frames in the router. (envoyproxy#13511) http2: Proactively disconnect connections flooded when resetting stream (envoyproxy#13482) ci use azp to sync filter example (envoyproxy#13501) mongo_proxy: support configurable command list for metrics (envoyproxy#13494) http local rate limit: note token bucket is shared (envoyproxy#13525) wasm/extensions: Wasm extension policy. (envoyproxy#13526) http: removing envoy.reloadable_features.http1_flood_protection (envoyproxy#13508) build: update ppc64le CI build status shield (envoyproxy#13521) dependencies: enforce dependency shepherd sign-off via RepoKitteh. (envoyproxy#13522) Add no_traffic_healthy_interval (envoyproxy#13336) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>

Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Antonio Vicente <avd@google.com>

Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>

Backport of PR #13529 and #13503 Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Christoph Pakulski <christoph@tetrate.io> Co-authored-by: phlax <phlax@users.noreply.github.com>

phlax force-pushed the examples-more-deprecated-config-validation branch from cebe230 to 1f9185b Compare October 13, 2020 07:45

phlax mentioned this pull request Oct 13, 2020

Clarify typed_config extensions in docs #13531

Closed

phlax force-pushed the examples-more-deprecated-config-validation branch from 7e23ada to 1106863 Compare October 13, 2020 10:38

phlax changed the title ~~examples: Fix more deprecations/warnings in configs~~ [WIP] examples: Fix more deprecations/warnings in configs Oct 13, 2020

phlax marked this pull request as draft October 13, 2020 10:44

examples: Fix more deprecations/warnings in configs

6574bc0

Signed-off-by: Ryan Northey <ryan@synca.io>

phlax force-pushed the examples-more-deprecated-config-validation branch from 1106863 to 6574bc0 Compare October 13, 2020 12:23

phlax changed the title ~~[WIP] examples: Fix more deprecations/warnings in configs~~ examples: Fix more deprecations/warnings in configs Oct 13, 2020

phlax marked this pull request as ready for review October 13, 2020 12:23

mattklein123 self-assigned this Oct 13, 2020

mattklein123 requested changes Oct 13, 2020

View reviewed changes

examples/jaeger-tracing/front-envoy-jaeger.yaml Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Oct 13, 2020

phlax mentioned this pull request Oct 13, 2020

Some deprecated configs dont seem to be caught in config validation #13542

Closed

revert zipking v2/v3 /spans config

f4892b2

Signed-off-by: Ryan Northey <ryan@synca.io>

repokitteh-read-only bot removed the waiting label Oct 13, 2020

htuch previously approved these changes Oct 13, 2020

View reviewed changes

mattklein123 added the waiting label Oct 13, 2020

examples/

9fac80c

Signed-off-by: Ryan Northey <ryan@synca.io>

phlax dismissed htuch’s stale review via 9fac80c October 13, 2020 17:02

repokitteh-read-only bot removed the waiting label Oct 13, 2020

mattklein123 approved these changes Oct 13, 2020

View reviewed changes

mattklein123 merged commit 328ffbe into envoyproxy:master Oct 13, 2020

This was referenced Oct 14, 2020

Default configs in Docker images dont work very well out of the box #13497

Closed

configs: Update configs v2 -> v3 #13562

Merged

phlax mentioned this pull request Oct 21, 2020

2020/10/21 phlax/cncf-progress#3

Closed

antoniovicente pushed a commit to antoniovicente/envoy that referenced this pull request Nov 20, 2020

examples: Fix more deprecations/warnings in configs (envoyproxy#13529)

ffe637e

Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Antonio Vicente <avd@google.com>

cpakulski pushed a commit to cpakulski/envoy that referenced this pull request Nov 20, 2020

examples: Fix more deprecations/warnings in configs (envoyproxy#13529)

8b7e76c

Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>

cpakulski pushed a commit to cpakulski/envoy that referenced this pull request Nov 20, 2020

examples: Fix more deprecations/warnings in configs (envoyproxy#13529)

cd4dc95

Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>

cpakulski mentioned this pull request Nov 20, 2020

backport to 1.16: examples to use v3 configs #14125

Merged

Conversation

phlax commented Oct 13, 2020

Uh oh!

phlax commented Oct 13, 2020

Uh oh!

phlax commented Oct 13, 2020

Uh oh!

repokitteh-read-only bot commented Oct 13, 2020

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

phlax commented Oct 13, 2020

Uh oh!

mattklein123 commented Oct 13, 2020

Uh oh!

htuch commented Oct 13, 2020

Uh oh!

phlax commented Oct 13, 2020

Uh oh!

phlax commented Oct 13, 2020

Uh oh!

repokitteh-read-only bot commented Oct 13, 2020

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

phlax commented Oct 13, 2020

Uh oh!

mattklein123 commented Oct 13, 2020

Uh oh!

phlax commented Oct 13, 2020

Uh oh!

moderation commented Oct 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants