examples: Fix deprecations/warnings in configs

[phlax]

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: examples: Fix deprecations/warnings in configs
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #13467
[Optional Deprecated:]

[mattklein123]

Great thanks. cc @htuch it would be good to understand why this wasn't failing by default in config checking.

[phlax]

@mattklein123 there are some further warnings left, im happy to land this and address after (if tests pass) - or i can go through the remaining ones

[mattklein123]

We can just land this. I would still like to understand why we are not failing on these warnings in the config test, but we can look into that separately.

[moderation]

There are still dangling references to v2 in the examples. These should be bumped to v3.

examples/zipkin-tracing/service2-envoy-zipkin.yaml
17:                "@type": type.googleapis.com/envoy.config.trace.v2.ZipkinConfig
19:                collector_endpoint: "/api/v2/spans"

examples/zipkin-tracing/front-envoy-zipkin.yaml
18:                "@type": type.googleapis.com/envoy.config.trace.v2.ZipkinConfig
20:                collector_endpoint: "/api/v2/spans"

examples/jaeger-native-tracing/front-envoy-jaeger.yaml
18:                "@type": type.googleapis.com/envoy.config.trace.v2.DynamicOtConfig

examples/jaeger-native-tracing/service2-envoy-jaeger.yaml
17:                "@type": type.googleapis.com/envoy.config.trace.v2.DynamicOtConfig

examples/zipkin-tracing/service1-envoy-zipkin.yaml
17:                "@type": type.googleapis.com/envoy.config.trace.v2.ZipkinConfig
19:                collector_endpoint: "/api/v2/spans"
53:                "@type": type.googleapis.com/envoy.config.trace.v2.ZipkinConfig
55:                collector_endpoint: "/api/v2/spans"

examples/jaeger-native-tracing/service1-envoy-jaeger.yaml
45:                "@type": type.googleapis.com/envoy.config.trace.v2.DynamicOtConfig

examples/mysql/envoy.yaml
16:          "@type": type.googleapis.com/envoy.config.filter.network.tcp_proxy.v2.TcpProxy

examples/redis/envoy.yaml
12:          "@type": type.googleapis.com/envoy.config.filter.network.redis_proxy.v2.RedisProxy

examples/jaeger-tracing/service2-envoy-jaeger.yaml
17:                "@type": type.googleapis.com/envoy.config.trace.v2.ZipkinConfig
19:                collector_endpoint: "/api/v2/spans"

examples/jaeger-tracing/front-envoy-jaeger.yaml
18:                "@type": type.googleapis.com/envoy.config.trace.v2.ZipkinConfig
20:                collector_endpoint: "/api/v2/spans"

examples/jaeger-tracing/service1-envoy-jaeger.yaml
17:                "@type": type.googleapis.com/envoy.config.trace.v2.ZipkinConfig
19:                collector_endpoint: "/api/v2/spans"
54:                "@type": type.googleapis.com/envoy.config.trace.v2.ZipkinConfig
56:                collector_endpoint: "/api/v2/spans"

examples/fault-injection/envoy.yaml
33:              "@type": type.googleapis.com/envoy.config.filter.http.fault.v2.HTTPFault

[phlax]

@moderation cool, ill update...

[mattklein123]

(Would still like to figure out why this is not failing by default)

[htuch]

@mattklein123 are you asking:

1. Why aren't we failing in config examples when there is any warning?
2. Why aren't we rejecting v2 configs by default?
   For (2), this is on my TODO for the next week. For (1) I don't think we have support but it might make sense to add.

[phlax]

see #13542

[mattklein123]

I'm fairly sure that (1) has been implemented already for using deprecated fields. I know @alyssawilk fixed this to fail by default at some point, but I'm guessing it's somehow not working for the typed_config warnings for v2 types.

For (2) I'm just suggesting that if we are using a deprecated typed_config we should fail the config_test by default like we do for other deprecated config.

[mattklein123]

@htuch see

envoy/test/config_test/config_test.cc

Lines 75 to 84 in cb7691c

	// Here we setup runtime to mimic the actual deprecated feature list used in the
	// production code. Note that this test is actually more strict than production because
	// in production runtime is not setup until after the bootstrap config is loaded. This seems
	// better for configuration tests.
	ScopedRuntimeInjector scoped_runtime(server_.runtime());
	ON_CALL(server_.runtime_loader_.snapshot_, deprecatedFeatureEnabled(_, _))
	.WillByDefault(Invoke([](absl::string_view, bool default_value) { return default_value; }));
	ON_CALL(server_.runtime_loader_, threadsafeSnapshot()).WillByDefault(Invoke([this]() {
	return snapshot_;
	}));

[phlax]

@mattklein123 @htuch please can we move to the ticket - rather than a landed PR, thanks

[htuch]

I'll take care of this when I work on (2).