Add no_traffic_healthy_interval#13336
Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom Oct 12, 2020
Merged
Conversation
Chuongv
force-pushed
the
no_traffic_healthy_interval
branch
from
e925792 to
16f974a
Compare
snowp
suggested changes
Sep 30, 2020
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Thanks this makes sense to me. A few comments to get you started
mattklein123
reviewed
Oct 1, 2020
Chuongv
force-pushed
the
no_traffic_healthy_interval
branch
4 times, most recently
from
6c041cf to
a6145af
Compare
Contributor
Author
|
@snowp I think this is ready but I'm having trouble figuring out where this is occurring Where is this file outputted? |
Contributor
|
I think maybe it's not liking some of the trailing spaces in the proto comments? You can build docs locally with docs/build.sh |
Chuongv
force-pushed
the
no_traffic_healthy_interval
branch
2 times, most recently
from
e461e8a to
e0a8475
Compare
Adds a no_traffic_healthy_interval for when a cluster is marked healthy and we want to use a different interval than no_traffic_interval Fixes envoyproxy#13246 Risk level: Low Testing: Unit test Signed-off-by: Chuong Vu <chuongv@google.com>
Signed-off-by: Chuong Vu <chuongv@google.com>
Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: Chuong Vu <chuongv@google.com>
Signed-off-by: Chuong Vu <chuongv@google.com>
Signed-off-by: Chuong Vu <chuongv@google.com>
Chuongv
force-pushed
the
no_traffic_healthy_interval
branch
from
e0a8475 to
a35a4e2
Compare
Contributor
Author
Thanks, that made it much easier to find out what it was 😄 . I think this is ready now. |
snowp
approved these changes
Oct 12, 2020
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Thanks this LGTM.
@envoyproxy/api-shepherds for API review
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 14, 2020
* master: (22 commits) http: using CONNECT_ERROR for HTTP/2 (envoyproxy#13519) listener: respect address.pipe.mode (it didn't work) (envoyproxy#13493) examples: Fix more deprecations/warnings in configs (envoyproxy#13529) overload: tcp connection refusal overload action (envoyproxy#13311) tcp: towards pluggable upstreams (envoyproxy#13331) conn_pool: fixing comments (envoyproxy#13520) Prevent SEGFAULT when disabling listener (envoyproxy#13515) Convert overload manager config literals to YAML (envoyproxy#13518) Fix runtime feature variable name (envoyproxy#13533) dependencies: refactor repository location schema utils, cleanups. (envoyproxy#13452) router: fix an invalid ASSERT when encoding metadata frames in the router. (envoyproxy#13511) http2: Proactively disconnect connections flooded when resetting stream (envoyproxy#13482) ci use azp to sync filter example (envoyproxy#13501) mongo_proxy: support configurable command list for metrics (envoyproxy#13494) http local rate limit: note token bucket is shared (envoyproxy#13525) wasm/extensions: Wasm extension policy. (envoyproxy#13526) http: removing envoy.reloadable_features.http1_flood_protection (envoyproxy#13508) build: update ppc64le CI build status shield (envoyproxy#13521) dependencies: enforce dependency shepherd sign-off via RepoKitteh. (envoyproxy#13522) Add no_traffic_healthy_interval (envoyproxy#13336) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a no_traffic_healthy_interval for when a cluster is marked healthy
and we want to use a different interval than no_traffic_interval
Risk level: Low
Testing: Unit test
Fixes: #13246
Release Notes: added option to use
no_traffic_healthy_intervalwhich allows a different no traffic interval when the cluster is healthy.Signed-off-by: Chuong Vu chuongv@google.com