dependencies: refactor repository location schema utils, cleanups.#13452
Merged
htuch merged 8 commits intoenvoyproxy:masterfrom Oct 13, 2020
Merged
dependencies: refactor repository location schema utils, cleanups.#13452htuch merged 8 commits intoenvoyproxy:masterfrom
htuch merged 8 commits intoenvoyproxy:masterfrom
Conversation
* Refactor code responsible for processing repository location specs, i.e. checking for the presence of fields like last_updated and interpolation of version. The same code is now usable by both API repository_locations.bzl and bazel/repository_locations.bzl. * Cleanup reference to repo locations in repository_locations.bzl, now using a consistent set of macros. * Add API dependencies to dependency dashboard. Risk level: Low Testing: Docs build. Part of envoyproxy#12673 Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Contributor
|
LGTM and nice to centralize tools and standardize on the deps *.bzl files |
asraa
suggested changes
Oct 12, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thanks for consolidating these! Two very minor comments
Signed-off-by: Harvey Tuch <htuch@google.com>
asraa
previously approved these changes
Oct 12, 2020
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
repokitteh-read-only
bot
added
the
deps
Member
Author
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
asraa
approved these changes
Oct 13, 2020
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 14, 2020
* master: (22 commits) http: using CONNECT_ERROR for HTTP/2 (envoyproxy#13519) listener: respect address.pipe.mode (it didn't work) (envoyproxy#13493) examples: Fix more deprecations/warnings in configs (envoyproxy#13529) overload: tcp connection refusal overload action (envoyproxy#13311) tcp: towards pluggable upstreams (envoyproxy#13331) conn_pool: fixing comments (envoyproxy#13520) Prevent SEGFAULT when disabling listener (envoyproxy#13515) Convert overload manager config literals to YAML (envoyproxy#13518) Fix runtime feature variable name (envoyproxy#13533) dependencies: refactor repository location schema utils, cleanups. (envoyproxy#13452) router: fix an invalid ASSERT when encoding metadata frames in the router. (envoyproxy#13511) http2: Proactively disconnect connections flooded when resetting stream (envoyproxy#13482) ci use azp to sync filter example (envoyproxy#13501) mongo_proxy: support configurable command list for metrics (envoyproxy#13494) http local rate limit: note token bucket is shared (envoyproxy#13525) wasm/extensions: Wasm extension policy. (envoyproxy#13526) http: removing envoy.reloadable_features.http1_flood_protection (envoyproxy#13508) build: update ppc64le CI build status shield (envoyproxy#13521) dependencies: enforce dependency shepherd sign-off via RepoKitteh. (envoyproxy#13522) Add no_traffic_healthy_interval (envoyproxy#13336) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor code responsible for processing repository location specs,
i.e. checking for the presence of fields like last_updated and
interpolation of version. The same code is now usable by both
API repository_locations.bzl and bazel/repository_locations.bzl.
Cleanup reference to repo locations in repository_locations.bzl,
now using a consistent set of macros.
Add API dependencies to dependency dashboard.
Risk level: Low
Testing: Docs build.
Part of #12673
Signed-off-by: Harvey Tuch htuch@google.com