iOS: Change release artifacts to use xcframeworks by jpsim · Pull Request #2217 · envoyproxy/envoy-mobile

jpsim · 2022-04-26T20:25:45Z

Risk Level: Low to existing users since the previous frameworks don't appear to have really been working, or been in use
Testing: Validated on CI, locally with pod spec lint pointing to the new zip format, locally with SwiftPM, locally by dragging & dropping the xcframework into an Xcode project.
Docs Changes: None
Release Notes: Added

Signed-off-by: JP Simard jp@jpsim.com

Fixes #2215 & #2216 Signed-off-by: JP Simard <jp@jpsim.com>

* main: Add new version history section (#2209) build: simplify jnilib copy (#2214) Signed-off-by: JP Simard <jp@jpsim.com>

library/swift/resources/BUILD

Signed-off-by: JP Simard <jp@jpsim.com>

jpsim · 2022-04-27T16:42:37Z

I measured the final app size impact of integrating Envoy Mobile in an iOS app to be ~5MB when statically linked and ~9MB when dynamically linked.

We can optimize binary size further in the future, but for now I believe that moving to dynamic xcframeworks gives the best developer experience by resolving the issues described in #2215 & #2216.

Update rules_apple to have xcframework improvements bazelbuild/rules_apple#1443 Signed-off-by: JP Simard <jp@jpsim.com>

Started a conversation in the Envoy Slack about adopting rolling bazel releases in general: https://envoyproxy.slack.com/archives/C7E6C71QB/p1651089150478729 It would be nice to stay in sync with Envoy to avoid any incompatibilities. Signed-off-by: JP Simard <jp@jpsim.com>

jpsim · 2022-04-27T20:07:31Z

I changed to use static xcframeworks in the last commits, since I got that working after pulling in bazelbuild/rules_apple#1443 and updating the bazel version to 6.0.0-pre.20220414.2.

I started a conversation in the Envoy Slack about adopting rolling bazel releases in general: https://envoyproxy.slack.com/archives/C7E6C71QB/p1651089150478729

It would be nice to stay in sync with Envoy to avoid any incompatibilities, but we used to have separate bazel versions prior to #1925 and I think if we get clear wins from updating sooner it should be considered.

jpsim · 2022-04-27T20:44:46Z

Seems like our java runtime setup broke somewhere in bazelbuild/bazel@6.0.0-pre.20220208.2...6.0.0-pre.20220216.3

keith · 2022-04-27T20:46:30Z

Yea I hit that locally when testing this as well, there are some flags in the .bazelrc, I think ideally we would be passing --java_runtime_version=remotejdk_11 --tool_java_runtime_version=remotejdk_11 but I haven't debugged more

Signed-off-by: JP Simard <jp@jpsim.com>

* main: Cleanup: remove the unused stats sink metrics_service (#2220) bazel: move back to symbol mapping table files (#2218) Signed-off-by: JP Simard <jp@jpsim.com>

jpsim · 2022-04-28T16:03:23Z

Another benefit of moving to xcframeworks is that we get Swift Package Manager support for free.

.binaryTarget(
  name: "Envoy",
  url: "https://github.com/envoyproxy/envoy-mobile/releases/download/v0.4.6/Envoy.xcframework.zip",
  checksum: "..."
)

SwiftPM & CocoaPods expect different structures in the zip archive * SwiftPM needs the framework to be at the top-level of the zip file * CocoaPods needs the framework to be zipped in a folder including the license file Signed-off-by: JP Simard <jp@jpsim.com>

Signed-off-by: JP Simard <jp@jpsim.com>

jpsim · 2022-04-28T18:26:35Z

Seems like our java runtime setup broke somewhere in bazelbuild/bazel@6.0.0-pre.20220208.2...6.0.0-pre.20220216.3

Bisected the failure to bazelbuild/bazel@d5559c1

I don't have any ideas to explore to resolve the issue. Passing --java_runtime_version=remotejdk_11 --tool_java_runtime_version=remotejdk_11 doesn't appear to help.

keith · 2022-04-28T23:17:33Z

Thanks that was super helpful, I believe this fixes that issue: #2227

https://github.com/bazelbuild/bazel/releases/tag/6.0.0-pre.20220414.2 As [discussed in Slack][slack], there are a number of disadvantages to staying on LTS releases. This can also help unblock Envoy Mobile's iOS releases: envoyproxy/envoy-mobile#2217 [slack]: https://envoyproxy.slack.com/archives/C7E6C71QB/p1651089150478729 Signed-off-by: JP Simard <jp@jpsim.com>

* origin/main: Bump rules_apple to 0.34.2 (#2236) Bump Lyft Support Rotation (#2232) ci: add support for `/retest` command (#2219) format: add SwiftLint to check-format script (#2230) use 64 bit emulators for test (#2228) envoy: update to `d0befbb` & add `h2ExtendKeepaliveTimeout` (#2229) Add Ryan Hamilton to OWNERS.md (#2224) Android cert verifier: first import from chromium/net (#2222) Signed-off-by: JP Simard <jp@jpsim.com>

Signed-off-by: JP Simard <jp@jpsim.com>

jpsim · 2022-05-02T21:30:53Z

/retest

* main: envoy: update to efbbb04 (#2258) Update rules_java, rules_detekt, rules_jvm_external (#2249) Upgrade rules_jvm_external from 4.1 -> 4.2 (#2254) CancelProofEnvoyStream (#2250) swift: add DrString tool & fix documentation comment issues (#2233) Fix `bump_lyft_support_rotation.sh` posting to Slack (#2234) jni: fix mismatched return value types (#2252) Remove bintray as a maven source (#2248) test: refine connection drain test (#2245) cleanup: remove comment in Http::Client that no longer applies (#2203) cleanup: fix test with inaccurate description (#2202) network: perform post-DNS connection drain on a per-host basis (#2240) network: add enableDrainPostDnsRefresh to iOS (#2242) envoy: update to em-cherry (#2241) network: support draining connections after triggered DNS refresh (#2225) Signed-off-by: JP Simard <jp@jpsim.com>

jpsim · 2022-05-06T19:09:23Z

With main now on bazel 6.x, this is ready for review without any egregious hacks.

jpsim · 2022-05-09T21:25:25Z

I'm waiting on #2184 to merge this to not cause more work in that PR.

* main: build: remove dist/ (#2184) Fix Envoy Mobile bug where writing prevents the read loop from running, (#2221) Add comments to CronetBidirectionalStream (#2266) CronetBidirectionalStream (#2164) ci: update build image (#2261) Bump Lyft Support Rotation (#2260) Signed-off-by: JP Simard <jp@jpsim.com>

jpsim · 2022-05-10T21:23:17Z

I didn't merge the release.yml GitHub Actions workflow properly. Updating.

Signed-off-by: JP Simard <jp@jpsim.com>

* main: Add assert when failing to get_env (#2253) Update Kotlin standard libraries to 1.6.21 (#2256) iOS: Change release artifacts to use xcframeworks (#2217) build: remove dist/ (#2184) Fix Envoy Mobile bug where writing prevents the read loop from running, (#2221) Add comments to CronetBidirectionalStream (#2266) CronetBidirectionalStream (#2164) Signed-off-by: JP Simard <jp@jpsim.com>

https://github.com/bazelbuild/bazel/releases/tag/6.0.0-pre.20220414.2 As [discussed in Slack][slack], there are a number of disadvantages to staying on LTS releases. This can also help unblock Envoy Mobile's iOS releases: envoyproxy/envoy-mobile#2217 [slack]: https://envoyproxy.slack.com/archives/C7E6C71QB/p1651089150478729 Signed-off-by: JP Simard <jp@jpsim.com>

iOS: Change release artifacts to use xcframeworks

0b94143

Fixes #2215 & #2216 Signed-off-by: JP Simard <jp@jpsim.com>

jpsim marked this pull request as ready for review April 26, 2022 20:29

jpsim requested review from Augustyniak and keith April 26, 2022 20:29

jpsim linked an issue Apr 26, 2022 that may be closed by this pull request

iOS framework missing arm64 simulator slice #2216

Closed

Merge branch 'main' into jp-xcframework

3ba86d5

* main: Add new version history section (#2209) build: simplify jnilib copy (#2214) Signed-off-by: JP Simard <jp@jpsim.com>

keith reviewed Apr 26, 2022

View reviewed changes

library/swift/resources/BUILD Outdated Show resolved Hide resolved

Reference Info.plist directly

5f8f0a4

Signed-off-by: JP Simard <jp@jpsim.com>

jpsim requested a review from keith April 27, 2022 16:42

jpsim added 2 commits April 27, 2022 16:02

apple_static_xcframework

629d3db

Update rules_apple to have xcframework improvements bazelbuild/rules_apple#1443 Signed-off-by: JP Simard <jp@jpsim.com>

jpsim added 3 commits April 27, 2022 16:54

Update rules_apple to latest PR commit

5996d99

Signed-off-by: JP Simard <jp@jpsim.com>

Only modify bazel version when building the iOS release

1e6260c

Signed-off-by: JP Simard <jp@jpsim.com>

Merge branch 'main' into jp-xcframework

4d9c5d1

* main: Cleanup: remove the unused stats sink metrics_service (#2220) bazel: move back to symbol mapping table files (#2218) Signed-off-by: JP Simard <jp@jpsim.com>

jpsim mentioned this pull request Apr 28, 2022

bazel: update to latest rolling release envoyproxy/envoy#21070

Merged

jpsim added 3 commits April 28, 2022 13:06

Update rules_apple again

90b0e99

Signed-off-by: JP Simard <jp@jpsim.com>

Build release artifacts on PRs and main commits to validate

a12d44c

Signed-off-by: JP Simard <jp@jpsim.com>

jpsim added 3 commits May 2, 2022 15:18

Update to latest rules_apple HEAD

c95ac25

Signed-off-by: JP Simard <jp@jpsim.com>

Reset envoy submodule to what's on main

c433ea4

Signed-off-by: JP Simard <jp@jpsim.com>

jpsim marked this pull request as draft May 6, 2022 18:03

jpsim marked this pull request as ready for review May 6, 2022 19:08

keith previously approved these changes May 9, 2022

View reviewed changes

Augustyniak previously approved these changes May 9, 2022

View reviewed changes

jpsim dismissed stale reviews from Augustyniak and keith via ba0e987 May 10, 2022 21:06

jpsim requested a review from keith May 10, 2022 21:06

jpsim force-pushed the jp-xcframework branch from ba0e987 to e2763aa Compare May 10, 2022 21:06

keith previously approved these changes May 10, 2022

View reviewed changes

Fix release.yml GitHub Actions workflow

cabbc00

Signed-off-by: JP Simard <jp@jpsim.com>

jpsim dismissed keith’s stale review via cabbc00 May 10, 2022 21:25

keith approved these changes May 10, 2022

View reviewed changes

jpsim merged commit 46d84f6 into main May 10, 2022

jpsim deleted the jp-xcframework branch May 10, 2022 21:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

iOS: Change release artifacts to use xcframeworks#2217

iOS: Change release artifacts to use xcframeworks#2217
jpsim merged 17 commits intomainfrom
jp-xcframework

jpsim commented Apr 26, 2022 •

edited

Loading

Uh oh!

Uh oh!

jpsim commented Apr 27, 2022

Uh oh!

jpsim commented Apr 27, 2022

Uh oh!

jpsim commented Apr 27, 2022

Uh oh!

keith commented Apr 27, 2022

Uh oh!

jpsim commented Apr 28, 2022

Uh oh!

jpsim commented Apr 28, 2022

Uh oh!

keith commented Apr 28, 2022

Uh oh!

jpsim commented May 2, 2022

Uh oh!

jpsim commented May 6, 2022

Uh oh!

jpsim commented May 9, 2022

Uh oh!

jpsim commented May 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jpsim commented Apr 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jpsim commented Apr 27, 2022

Uh oh!

jpsim commented Apr 27, 2022

Uh oh!

jpsim commented Apr 27, 2022

Uh oh!

keith commented Apr 27, 2022

Uh oh!

jpsim commented Apr 28, 2022

Uh oh!

jpsim commented Apr 28, 2022

Uh oh!

keith commented Apr 28, 2022

Uh oh!

jpsim commented May 2, 2022

Uh oh!

jpsim commented May 6, 2022

Uh oh!

jpsim commented May 9, 2022

Uh oh!

jpsim commented May 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jpsim commented Apr 26, 2022 •

edited

Loading