envoy: update to d0befbb & add h2ExtendKeepaliveTimeout#2229
Merged
Conversation
Signed-off-by: JP Simard <jp@jpsim.com>
We'll update this to drain the main host in an upcoming PR, but this keeps the existing behavior. Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Contributor
Author
|
Converting back to draft as I add an engine builder configuration for envoyproxy/envoy#21077. |
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
changed the title
d0befbbd0befbb & add h2ExtendKeepaliveTimeout
Augustyniak
previously approved these changes
Apr 29, 2022
Contributor
Augustyniak
left a comment
Augustyniak
left a comment
There was a problem hiding this comment.
Nice! The flag is going to help us to measure the impact of a change. Hopefully it's going to improve things and we will be able to eventually remove h2ExtendKeepaliveTimeout method from the public API (and just have the functionality enabled by default)
Signed-off-by: JP Simard <jp@jpsim.com>
Augustyniak
approved these changes
Apr 29, 2022
| * | ||
| * @return This builder. | ||
| */ | ||
| fun h2ExtendKeepaliveTimeout(h2ExtendKeepaliveTimeout: Boolean): EngineBuilder { |
Contributor
There was a problem hiding this comment.
ah, one thing that I noticed is that other methods related to h2 ping are named using h2CONNECTIONKeepalive prefix- if you want to add it that's great, if not I think that it's not a big deal as we are going to remove this method at some point anyway (most probably)
Contributor
Author
There was a problem hiding this comment.
Yeah this is already pretty verbose that I'd rather not make it even longer.
jpsim
added a commit
that referenced
this pull request
May 2, 2022
* origin/main: Bump rules_apple to 0.34.2 (#2236) Bump Lyft Support Rotation (#2232) ci: add support for `/retest` command (#2219) format: add SwiftLint to check-format script (#2230) use 64 bit emulators for test (#2228) envoy: update to `d0befbb` & add `h2ExtendKeepaliveTimeout` (#2229) Add Ryan Hamilton to OWNERS.md (#2224) Android cert verifier: first import from chromium/net (#2222) Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
May 3, 2022
…rtion * origin/main: (57 commits) network: add enableDrainPostDnsRefresh to iOS (#2242) envoy: update to em-cherry (#2241) network: support draining connections after triggered DNS refresh (#2225) Bump rules_apple to 0.34.2 (#2236) Bump Lyft Support Rotation (#2232) ci: add support for `/retest` command (#2219) format: add SwiftLint to check-format script (#2230) use 64 bit emulators for test (#2228) envoy: update to `d0befbb` & add `h2ExtendKeepaliveTimeout` (#2229) Add Ryan Hamilton to OWNERS.md (#2224) Android cert verifier: first import from chromium/net (#2222) Cleanup: remove the unused stats sink metrics_service (#2220) bazel: move back to symbol mapping table files (#2218) Add new version history section (#2209) build: simplify jnilib copy (#2214) ci: Update macOS version to macOS 12 (#2208) Update releasing.rst (#2200) support: Post Lyft support rotation changes to Slack (#2207) Don't run bump_support_rotation GitHub Action on forks (#2204) Release 0.4.6 (#2201) ... Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff: envoyproxy/envoy@03f2376...d0befbb
To Do:
h2ExtendKeepaliveTimeoutoption to engine buildersh2ExtendKeepaliveTimeoutproperly sets thehttp2_delay_keepalive_timeoutreloadable feature in the yaml configuration