Skip to content

bazel: update rules_kotlin and rules_detekt#2227

Closed
keith wants to merge 3 commits intomainfrom
ks/bazel-update-rules_kotlin-and-rules_detekt
Closed

bazel: update rules_kotlin and rules_detekt#2227
keith wants to merge 3 commits intomainfrom
ks/bazel-update-rules_kotlin-and-rules_detekt

Conversation

@keith
Copy link
Member

@keith keith commented Apr 28, 2022

rules_detekt pins rules_java, which needed to be updated to support
bazelbuild/bazel@d5559c1
and bazel rolling releases.

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

@keith keith enabled auto-merge (rebase) April 28, 2022 23:13
rules_detekt pins rules_java, which needed to be updated to support
bazelbuild/bazel@d5559c1
and bazel rolling releases.

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
jpsim
jpsim previously approved these changes Apr 29, 2022
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@keith keith force-pushed the ks/bazel-update-rules_kotlin-and-rules_detekt branch from f9b089e to 8321e4c Compare April 29, 2022 18:08
@jpsim
Copy link
Contributor

jpsim commented May 2, 2022

I can get the kotlin_tests_mac CI job to pass when using java-version: 18 and disabling remote exec: ks/bazel-update-rules_kotlin-and-rules_detekt...jp-ks/bazel-update-rules_kotlin-and-rules_detekt

java_tests_mac may also be passing with the same changes, although it's still building so I can't say for sure.

kotlin_tests_linux runs into a gcc error when I apply the same changes:

error: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Werror,-Wunknown-warning-option]

@keith
Copy link
Member Author

keith commented May 6, 2022

#2249

@keith keith closed this May 6, 2022
auto-merge was automatically disabled May 6, 2022 18:03

Pull request was closed

@keith keith deleted the ks/bazel-update-rules_kotlin-and-rules_detekt branch May 6, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants