bazel: change .bazelversion to be symlink from envoy#1925
Merged
Conversation
These should likely always match since envoy's build configs could depend on it. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
force-pushed
the
ks/bazel-change-.bazelversion-to-be-symlink-from-envoy
branch
from
08fda85 to
87f3c91
Compare
Contributor
|
Thanks @keith! This sounds good to me. We have historically had a couple of stretches where we needed to build on a different version of bazel from the version on Envoy main, but this seems good to have as a default and it's not like we can't change it if we're forced to down the road. |
goaway
deleted the
ks/bazel-change-.bazelversion-to-be-symlink-from-envoy
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These should likely always match since envoy's build configs could
depend on it.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com