Skip to content

bazel: update to latest rolling release#21070

Merged
keith merged 2 commits intoenvoyproxy:mainfrom
jpsim:jp-bazel-6.0.0-pre.20220414.2
Apr 29, 2022
Merged

bazel: update to latest rolling release#21070
keith merged 2 commits intoenvoyproxy:mainfrom
jpsim:jp-bazel-6.0.0-pre.20220414.2

Conversation

@jpsim
Copy link
Copy Markdown
Contributor

@jpsim jpsim commented Apr 28, 2022

https://github.com/bazelbuild/bazel/releases/tag/6.0.0-pre.20220414.2

As discussed in Slack, there are a number of disadvantages to staying on LTS releases.

This can also help unblock Envoy Mobile's iOS releases: envoyproxy/envoy-mobile#2217

Risk Level: Moderate, changing the bazel version, though issues are most likely to be caught at build/test time
Testing: Existing, CI

https://github.com/bazelbuild/bazel/releases/tag/6.0.0-pre.20220414.2

As [discussed in Slack][slack], there are a number of disadvantages to
staying on LTS releases.

This can also help unblock Envoy Mobile's iOS releases:
envoyproxy/envoy-mobile#2217

[slack]: https://envoyproxy.slack.com/archives/C7E6C71QB/p1651089150478729

Signed-off-by: JP Simard <jp@jpsim.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #21070 was opened by jpsim.

see: more, trace.

@jpsim jpsim changed the title bazel: update .bazelversion to latest rolling release bazel: update to latest rolling release Apr 28, 2022
@jpsim jpsim marked this pull request as ready for review April 28, 2022 15:45
The previous job was automatically canceled after 120 minutes.

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added a commit to envoyproxy/envoy-mobile that referenced this pull request Apr 28, 2022
To get ahead of any issues with envoyproxy/envoy#21070

Signed-off-by: JP Simard <jp@jpsim.com>
jobs:
- job: release
timeoutInMinutes: 120
timeoutInMinutes: 180
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably we'll be able to revert this once caches are warm.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if this was required once we should leave it, since it could happen at any normal tooling update too then.

@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented Apr 28, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21070 (comment) was created by @jpsim.

see: more, trace.

@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented Apr 29, 2022

@keith @lizan @moderation @yanavlasov CI hasn't uncovered any issues with this, mentioning you since you were involved in the Slack discussion.

There was a windows job that timed out but I think that's because the bazel version change invalidated the world so I believe we'll be able to reduce the timeout back to the previous amount once bazel caches are warm again.

Copy link
Copy Markdown
Contributor

@yanavlasov yanavlasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wait-any

@@ -1 +1 @@
5.1.1
6.0.0-pre.20220414.2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need toolchain update for this or do we use bazilisk in build images?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this log from CI, it seems like bazelisk is used and the correct bazel version is pulled when building:

2022/04/28 19:31:04 Downloading https://github.com/bazelbuild/bazel/releases/download/6.0.0-pre.20220414.2/bazel-6.0.0-pre.20220414.2-linux-x86_64...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in general the toolchains are pretty stable, so Ideally we won't have to change them much

jobs:
- job: release
timeoutInMinutes: 120
timeoutInMinutes: 180
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if this was required once we should leave it, since it could happen at any normal tooling update too then.

@keith keith merged commit 25cc9ea into envoyproxy:main Apr 29, 2022
@jpsim jpsim deleted the jp-bazel-6.0.0-pre.20220414.2 branch April 29, 2022 22:25
@moderation
Copy link
Copy Markdown
Contributor

For years I hand curated my Bazel versions (somewhat out of necessity in the early days of Bazel on aarch64 Linux). This change prompted me to try bazelelisk and I'm clearly an idiot for not adopting it earlier 😄

jpsim added a commit to envoyproxy/envoy-mobile that referenced this pull request May 6, 2022
This pulls in envoyproxy/envoy#21070 to update
bazel to `6.0.0-pre.20220414.2` which is the second-most recent 6.x
rolling release.

Bazel release: https://github.com/bazelbuild/bazel/releases/tag/6.0.0-pre.20220414.2
Diff: envoyproxy/envoy@f17b32f...efbbb04

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added a commit to envoyproxy/envoy-mobile that referenced this pull request May 6, 2022
This pulls in envoyproxy/envoy#21070 to update
bazel to `6.0.0-pre.20220414.2` which is the second-most recent 6.x
rolling release.

Bazel release: https://github.com/bazelbuild/bazel/releases/tag/6.0.0-pre.20220414.2
Diff: envoyproxy/envoy@f17b32f...efbbb04

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added a commit that referenced this pull request Nov 29, 2022
This pulls in #21070 to update
bazel to `6.0.0-pre.20220414.2` which is the second-most recent 6.x
rolling release.

Bazel release: https://github.com/bazelbuild/bazel/releases/tag/6.0.0-pre.20220414.2
Diff: f17b32f...efbbb04

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants