bazel: update to latest rolling release#21070
bazel: update to latest rolling release#21070keith merged 2 commits intoenvoyproxy:mainfrom jpsim:jp-bazel-6.0.0-pre.20220414.2
Conversation
https://github.com/bazelbuild/bazel/releases/tag/6.0.0-pre.20220414.2 As [discussed in Slack][slack], there are a number of disadvantages to staying on LTS releases. This can also help unblock Envoy Mobile's iOS releases: envoyproxy/envoy-mobile#2217 [slack]: https://envoyproxy.slack.com/archives/C7E6C71QB/p1651089150478729 Signed-off-by: JP Simard <jp@jpsim.com>
.bazelversion to latest rolling releaseThe previous job was automatically canceled after 120 minutes. Signed-off-by: JP Simard <jp@jpsim.com>
To get ahead of any issues with envoyproxy/envoy#21070 Signed-off-by: JP Simard <jp@jpsim.com>
| jobs: | ||
| - job: release | ||
| timeoutInMinutes: 120 | ||
| timeoutInMinutes: 180 |
There was a problem hiding this comment.
Presumably we'll be able to revert this once caches are warm.
There was a problem hiding this comment.
I think if this was required once we should leave it, since it could happen at any normal tooling update too then.
|
/retest |
|
Retrying Azure Pipelines: |
|
@keith @lizan @moderation @yanavlasov CI hasn't uncovered any issues with this, mentioning you since you were involved in the Slack discussion. There was a windows job that timed out but I think that's because the bazel version change invalidated the world so I believe we'll be able to reduce the timeout back to the previous amount once bazel caches are warm again. |
| @@ -1 +1 @@ | |||
| 5.1.1 | |||
| 6.0.0-pre.20220414.2 | |||
There was a problem hiding this comment.
Do we need toolchain update for this or do we use bazilisk in build images?
There was a problem hiding this comment.
Based on this log from CI, it seems like bazelisk is used and the correct bazel version is pulled when building:
2022/04/28 19:31:04 Downloading https://github.com/bazelbuild/bazel/releases/download/6.0.0-pre.20220414.2/bazel-6.0.0-pre.20220414.2-linux-x86_64...
There was a problem hiding this comment.
I think in general the toolchains are pretty stable, so Ideally we won't have to change them much
| jobs: | ||
| - job: release | ||
| timeoutInMinutes: 120 | ||
| timeoutInMinutes: 180 |
There was a problem hiding this comment.
I think if this was required once we should leave it, since it could happen at any normal tooling update too then.
|
For years I hand curated my Bazel versions (somewhat out of necessity in the early days of Bazel on aarch64 Linux). This change prompted me to try |
This pulls in envoyproxy/envoy#21070 to update bazel to `6.0.0-pre.20220414.2` which is the second-most recent 6.x rolling release. Bazel release: https://github.com/bazelbuild/bazel/releases/tag/6.0.0-pre.20220414.2 Diff: envoyproxy/envoy@f17b32f...efbbb04 Signed-off-by: JP Simard <jp@jpsim.com>
This pulls in envoyproxy/envoy#21070 to update bazel to `6.0.0-pre.20220414.2` which is the second-most recent 6.x rolling release. Bazel release: https://github.com/bazelbuild/bazel/releases/tag/6.0.0-pre.20220414.2 Diff: envoyproxy/envoy@f17b32f...efbbb04 Signed-off-by: JP Simard <jp@jpsim.com>
This pulls in #21070 to update bazel to `6.0.0-pre.20220414.2` which is the second-most recent 6.x rolling release. Bazel release: https://github.com/bazelbuild/bazel/releases/tag/6.0.0-pre.20220414.2 Diff: f17b32f...efbbb04 Signed-off-by: JP Simard <jp@jpsim.com>
https://github.com/bazelbuild/bazel/releases/tag/6.0.0-pre.20220414.2
As discussed in Slack, there are a number of disadvantages to staying on LTS releases.
This can also help unblock Envoy Mobile's iOS releases: envoyproxy/envoy-mobile#2217
Risk Level: Moderate, changing the bazel version, though issues are most likely to be caught at build/test time
Testing: Existing, CI