Update rules_java, rules_detekt, rules_jvm_external#2249
Merged
Conversation
Bencodes
force-pushed
the
update-rules_java-rules_detekt-rules_jvm_external
branch
3 times, most recently
from
5604948 to
72216c4
Compare
Signed-off-by: Benjamin Lee <ben@ben.cm>
Bencodes
force-pushed
the
update-rules_java-rules_detekt-rules_jvm_external
branch
from
72216c4 to
76b3788
Compare
Signed-off-by: Benjamin Lee <ben@ben.cm>
Bencodes
commented
May 6, 2022
| # Envoy's runtime system. This option prevents them from being compiled out. | ||
| build --copt -DABSL_FLAGS_STRIP_NAMES=0 | ||
|
|
||
| # The defaults are JDK 11 on newer versions of Bazel |
Contributor
Author
There was a problem hiding this comment.
This could potentially live under an Android specific bazelrc config if we'd prefer that not all builds have the JDK pinned to this.
Member
There was a problem hiding this comment.
In EM this shouldn't matter for non android targets anyways
Bencodes
commented
May 6, 2022
| type = "zip", | ||
| urls = ["https://github.com/bazelbuild/rules_kotlin/archive/legacy-1.3.0-rc2.zip"], | ||
| sha256 = "f1a4053eae0ea381147f5056bb51e396c5c494c7f8d50d0dee4cc2f9d5c701b0", | ||
| urls = ["https://github.com/bazelbuild/rules_kotlin/releases/download/1.6.0-RC-1/rules_kotlin_release.tgz"], |
Contributor
Author
There was a problem hiding this comment.
rules_kotlin 1.6.0-RC-1 pins the Kotlin compiler to 1.6.21
jpsim
approved these changes
May 6, 2022
Contributor
jpsim
left a comment
jpsim
left a comment
There was a problem hiding this comment.
I'm glad you got this working, I was stumped.
Contributor
Author
|
@jpsim is there any extra testing that you think needs to be done before we land this PR? |
Contributor
I don’t think so, if we find issues downstream I can investigate at that point. |
This was referenced May 6, 2022
jpsim
added a commit
that referenced
this pull request
May 6, 2022
* main: envoy: update to efbbb04 (#2258) Update rules_java, rules_detekt, rules_jvm_external (#2249) Upgrade rules_jvm_external from 4.1 -> 4.2 (#2254) CancelProofEnvoyStream (#2250) swift: add DrString tool & fix documentation comment issues (#2233) Fix `bump_lyft_support_rotation.sh` posting to Slack (#2234) jni: fix mismatched return value types (#2252) Remove bintray as a maven source (#2248) test: refine connection drain test (#2245) cleanup: remove comment in Http::Client that no longer applies (#2203) cleanup: fix test with inaccurate description (#2202) network: perform post-DNS connection drain on a per-host basis (#2240) network: add enableDrainPostDnsRefresh to iOS (#2242) envoy: update to em-cherry (#2241) network: support draining connections after triggered DNS refresh (#2225) Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
rules_javato 5.0.0 so that nothing unexpected gets pulled transitivelyrules_detektfrom 0.3.0 -> 0.6.0rules_kotlinfrom rules_kotlin-legacy-1.3.0-rc2 -> 1.6.0-RC-1This also unblocks updating to Bazel 6.x.
Signed-off-by: ben@ben.cm