[Endpoint] Update cli mapping to match endpoint package by kqualters-elastic · Pull Request #63372 · elastic/kibana

kqualters-elastic · 2020-04-13T16:05:11Z

Summary

The mapping installed by the endpoint package has a different type for file_extension. #62871 updated this mapping for functional tests, but missed the cli generator. Updates that mapping to match.

Checklist

N/A

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-04-13T16:05:13Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

bkimmel · 2020-04-13T16:17:10Z

x-pack/plugins/endpoint/scripts/event_mapping.json

              "file_extension": {
-                "type": "long"
+                "ignore_above": 1024,
+                "type": "keyword"


❔ this one too?

kibana/x-pack/plugins/endpoint/scripts/alert_mapping.json

Line 396 in c109f55

"file_extension": {

james-elastic

👍

bkimmel · 2020-04-13T19:09:34Z

kibana/x-pack/plugins/endpoint/scripts/resolver_generator.ts

Line 32 in 14ef3cf

default: '.alerts-endpoint-000001',

could we change that to events-endpoint-1 or import the constant?

kibanamachine · 2020-04-14T05:28:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 758efa6

History

💚 Build #40509 succeeded 915aa13
💚 Build #40495 succeeded 3a10415
💚 Build #40441 succeeded 14ef3cf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (132 commits) document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) [Maps] fix bug where toggling Scaling type does not re-fetch data (elastic#63326) [Alerting] set correct parameter for unauthented email action (elastic#63086) [Telemetry] force staging urls in tests (elastic#63356) Migrate legacy maps service to NP & update refs (elastic#60942) Fix task manager query to return tasks to retry (elastic#63360) [Endpoint] Policy list support for URL pagination state (elastic#63291) [Canvas] Migrate saved object mappings and migrations to Kibana Platform (elastic#58891) [DOCS] Add ILM tutorial (elastic#59502) [Maps] Add SOURCE_TYPES enumeration (elastic#62975) [Maps] update geospatial filters to use geo_shape query for geo_point fields (elastic#62966) Move away from npStart for embeddables in canvas (elastic#62680) Use MapInput type from Maps plugin (elastic#61539) Update to pagination for workpad and templates (elastic#62050) [SIEM] Fix AlertsTable id (elastic#63368) Consistent terminology around cypress test data (elastic#63279) ...

* master: document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) [Maps] fix bug where toggling Scaling type does not re-fetch data (elastic#63326) [Alerting] set correct parameter for unauthented email action (elastic#63086) [Telemetry] force staging urls in tests (elastic#63356) Migrate legacy maps service to NP & update refs (elastic#60942) Fix task manager query to return tasks to retry (elastic#63360) [Endpoint] Policy list support for URL pagination state (elastic#63291) [Canvas] Migrate saved object mappings and migrations to Kibana Platform (elastic#58891) [DOCS] Add ILM tutorial (elastic#59502) [Maps] Add SOURCE_TYPES enumeration (elastic#62975) [Maps] update geospatial filters to use geo_shape query for geo_point fields (elastic#62966) Move away from npStart for embeddables in canvas (elastic#62680)

* alerting/alert-services-mock: (107 commits) removed unused import added alert services mock and use it in siem [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) [Lens] Migration from 7.7 (elastic#62879) [Lens] Fix bug where suggestions didn't use filters (elastic#63293) Task/linux events (elastic#63400) [Remote clusters] guard against usageCollection plugin if unav… (elastic#63284) [Uptime] Remove pings graphql (elastic#59392) Index Pattern Field class - factor out copy_field code for future typescripting (elastic#63083) [EPM] add/remove package in package settings page (elastic#63389) Adjust API authorization logging (elastic#63350) Revert FTR: add chromium-based Edge browser support (elastic#61684) (elastic#63448) [Event Log] Adds namespace into save objects (elastic#62974) document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) ...

* Update cli mapping to match endpoint package

kibanamachine · 2020-04-16T06:08:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 63372 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-04-17T06:18:43Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 63372 or prevent reminders by adding the backport:skip label.

* Update cli mapping to match endpoint package

kibanamachine · 2020-04-20T06:28:43Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

Update cli mapping to match endpoint package

c109f55

kqualters-elastic added v8.0.0 Feature:Endpoint Elastic Endpoint feature v7.8.0 labels Apr 13, 2020

kqualters-elastic requested a review from a team as a code owner April 13, 2020 16:05

kqualters-elastic changed the title ~~Update cli mapping to match endpoint package~~ [Endpoint] Update cli mapping to match endpoint package Apr 13, 2020

kqualters-elastic added the release_note:skip Skip the PR/issue when compiling release notes label Apr 13, 2020

bkimmel approved these changes Apr 13, 2020

View reviewed changes

bkimmel reviewed Apr 13, 2020

View reviewed changes

Update alert mapping to match

14ef3cf

marshallmain approved these changes Apr 13, 2020

View reviewed changes

james-elastic approved these changes Apr 13, 2020

View reviewed changes

kqualters-elastic added 3 commits April 13, 2020 15:34

Use endpoint app constants for defaults in cli

3a10415

Don't use consts containing wildcards

915aa13

Remove using variables for index names

758efa6

kqualters-elastic merged commit 5d7c651 into elastic:master Apr 14, 2020

kqualters-elastic deleted the update-endpoint-cli-mappings branch April 14, 2020 06:05

wayneseymour pushed a commit that referenced this pull request Apr 15, 2020

[Endpoint] Update cli mapping to match endpoint package (#63372)

3d308ca

* Update cli mapping to match endpoint package

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 16, 2020

kqualters-elastic mentioned this pull request Apr 17, 2020

[7.x] [Endpoint] Update cli mapping to match endpoint package (#63372) #63895

Merged

kqualters-elastic added a commit to kqualters-elastic/kibana that referenced this pull request Apr 17, 2020

[Endpoint] Update cli mapping to match endpoint package (elastic#63372)

02ebee6

* Update cli mapping to match endpoint package

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Endpoint] Update cli mapping to match endpoint package#63372

[Endpoint] Update cli mapping to match endpoint package#63372
kqualters-elastic merged 5 commits intoelastic:masterfrom
kqualters-elastic:update-endpoint-cli-mappings

kqualters-elastic commented Apr 13, 2020

Uh oh!

elasticmachine commented Apr 13, 2020

Uh oh!

bkimmel Apr 13, 2020

Uh oh!

james-elastic left a comment

Uh oh!

bkimmel commented Apr 13, 2020

Uh oh!

kibanamachine commented Apr 14, 2020

Uh oh!

kibanamachine commented Apr 16, 2020

Uh oh!

kibanamachine commented Apr 17, 2020

Uh oh!

kibanamachine commented Apr 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

kqualters-elastic commented Apr 13, 2020

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Apr 13, 2020

Uh oh!

bkimmel Apr 13, 2020

Choose a reason for hiding this comment

Uh oh!

james-elastic left a comment

Choose a reason for hiding this comment

Uh oh!

bkimmel commented Apr 13, 2020

Uh oh!

kibanamachine commented Apr 14, 2020

💚 Build Succeeded

History

Uh oh!

kibanamachine commented Apr 16, 2020

Uh oh!

kibanamachine commented Apr 17, 2020

Uh oh!

kibanamachine commented Apr 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants